Disable Turbo for form submissions with custom packs

With Turbo enabled on forms with custom JavaScript / CSS packs and a successful change (no validation error), the final page would be rendered twice: The first rendering would occur after sending the form data using Turbo. This response is fetched and potentially displayed (first visit). The resulting DOM contains a change in the packs (with `'data-turbo-track': 'reload'`), causing a page reload (without Turbo). This is the second visit. Through this "double-visit", any flash message intended to be shown after the form submission is simply "lost". Therefore, we disable Turbo in these cases.

This holds also true for signout actions, that can (potentially) originate from any page, including those with custom packs, and redirect to the root page (without any additional packs).

Author: MrSerth

app/views/application/_session.html.slim

@@ -17,11 +17,11 @@
         - if current_user.admin? || current_user.teacher? || current_user.internal_user?
           li = link_to(t('consumers.show.link'), current_user.consumer, class: 'dropdown-item') if current_user.consumer && policy(current_user.consumer).show?
           li = link_to(t('internal_users.show.link'), current_user, class: 'dropdown-item') if policy(current_user).show?
-          li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
+          li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item', data: {turbo: false})
         - elsif current_user.webauthn_configured?
-          li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
+          li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item', data: {turbo: false})
       - else
-        li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
+        li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item', data: {turbo: false})
 - else
   li.nav-item = link_to(sign_in_path, class: 'nav-link') do
     i.fa-solid.fa-arrow-right-to-bracket

app/views/execution_environments/_form.html.slim

@@ -5,7 +5,7 @@
   - append_javascript_pack_tag('toast-ui')
   - append_stylesheet_pack_tag('toast-ui')
 
-= form_for(@execution_environment, builder: MarkdownFormBuilder) do |f|
+= form_for(@execution_environment, builder: MarkdownFormBuilder, data: {turbo: false}) do |f|
   = render('shared/form_errors', object: @execution_environment)
   .mb-3
     = f.label(:name, class: 'form-label')

app/views/exercises/_form.html.slim

@@ -10,7 +10,7 @@
 - execution_environments = ExecutionEnvironment.where.not(file_type_id: nil).select(:file_type_id, :id)
 - file_types = FileType.where.not(file_extension: nil).select(:file_extension, :id)
 
-= form_for(@exercise, data: {execution_environments:, file_types:}, multipart: true, builder: MarkdownFormBuilder) do |f|
+= form_for(@exercise, data: {execution_environments:, file_types:, turbo: false}, multipart: true, builder: MarkdownFormBuilder) do |f|
   = render('shared/form_errors', object: @exercise)
   .mb-3
     = f.label(:title, class: 'form-label')

app/views/exercises/index.html.slim

@@ -52,7 +52,7 @@ h1 = Exercise.model_name.human(count: :other)
                 li = link_to(RequestForComment.model_name.human(count: :other), exercise_request_for_comments_path(exercise), class: 'dropdown-item') if policy(exercise).rfcs_for_exercise?
                 li = link_to(ProgrammingGroup.model_name.human(count: :other), exercise_programming_groups_path(exercise), class: 'dropdown-item') if policy(exercise).programming_groups_for_exercise?
                 li = button_to(t('shared.destroy'), exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(exercise).destroy?
-                li = button_to(t('.clone'), clone_exercise_path(exercise), data: {confirm: t('shared.confirm_destroy')}, method: :post, class: 'dropdown-item') if policy(exercise).clone?
+                li = button_to(t('.clone'), clone_exercise_path(exercise), data: {confirm: t('shared.confirm_destroy'), turbo: false}, method: :post, class: 'dropdown-item') if policy(exercise).clone?
                 li = link_to(t('exercises.export_codeharbor.label'), '', class: 'dropdown-item export-start', data: {'exercise-id': exercise.id, 'bs-toggle': 'modal', 'bs-target': '#transfer-modal'}) if policy(exercise).export_external_confirm?
                 li = link_to(t('exercises.download_proforma.label'), download_proforma_exercise_path(exercise), class: 'dropdown-item', target: '_blank', rel: 'noopener noreferrer') if policy(exercise).download_proforma?
 

app/views/proxy_exercises/_form.html.slim

@@ -5,7 +5,7 @@
   - append_javascript_pack_tag('toast-ui')
   - append_stylesheet_pack_tag('toast-ui')
 
-= form_for(@proxy_exercise, multipart: true, builder: MarkdownFormBuilder) do |f|
+= form_for(@proxy_exercise, multipart: true, builder: MarkdownFormBuilder, data: {turbo: false}) do |f|
   = render('shared/form_errors', object: @proxy_exercise)
   .mb-3
     = f.label(:title, class: 'form-label')

app/views/tips/_form.html.slim

@@ -6,7 +6,7 @@
   - append_javascript_pack_tag('toast-ui')
   - append_stylesheet_pack_tag('toast-ui')
 
-= form_for(@tip, builder: MarkdownFormBuilder) do |f|
+= form_for(@tip, builder: MarkdownFormBuilder, data: {turbo: false}) do |f|
   = render('shared/form_errors', object: @tip)
   .mb-3
     = f.label(:title, class: 'form-label')

app/views/webauthn_credential_authentication/_form.html.slim

@@ -3,4 +3,4 @@
     = hidden_field_tag('webauthn_credential[credential]', '')
   .actions.mb-0
     = submit_tag(t('.verify_identity'), class: 'btn btn-primary me-2 mb-2')
-    = button_to(t('.cancel'), sign_out_path, method: :delete, class: 'btn btn-outline-secondary mb-2')
+    = button_to(t('.cancel'), sign_out_path, method: :delete, class: 'btn btn-outline-secondary mb-2', data: {turbo: false})