Spec improvments

Author: arkirchner

spec/mailers/user_content_report_mailer_spec.rb

@@ -11,12 +11,15 @@
     let(:human_model_name) { 'Reported model' }
     let(:course_url) { 'https://example.com/course/1' }
 
-    before do
-      user_content_report = instance_double(UserContentReport,
+    let(:user_content_report) do
+      instance_double(UserContentReport,
         human_model_name:,
         reported_message:,
         related_request_for_comment: instance_double(RequestForComment),
         course_url:)
+    end
+
+    before do
       allow(UserContentReport).to receive(:new).with(reported_content:).and_return(user_content_report)
     end
 

spec/policies/comment_policy_spec.rb

@@ -24,13 +24,19 @@
       end
     end
 
-    it 'does not grant access to users who have no access to the RfC' do
-      learner = build_stubbed(:learner)
-      rfc_policy = instance_double(RequestForCommentPolicy, show?: false)
-      allow(RequestForCommentPolicy).to receive(:new).with(learner, comment.request_for_comment)
-        .and_return(rfc_policy)
+    context 'without access to the RfC' do
+      let(:learner) { build_stubbed(:learner) }
+      let(:rfc_policy) { instance_double(RequestForCommentPolicy, show?: false) }
 
-      expect(described_class).not_to permit(learner, comment)
+      before do
+        allow(RequestForCommentPolicy).to receive(:new)
+          .with(learner, comment.request_for_comment)
+          .and_return(rfc_policy)
+      end
+
+      it 'does not grant access' do
+        expect(described_class).not_to permit(learner, comment)
+      end
     end
   end