Use delegation for to_s in models

Also use a proper localization for more models.

Author: MrSerth

app/models/codeharbor_link.rb

@@ -7,5 +7,7 @@ class CodeharborLink < ApplicationRecord
 
   belongs_to :user, class_name: 'InternalUser'
 
-  delegate :to_s, to: :id
+  def to_s
+    "#{model_name.human} #{id}"
+  end
 end

app/models/consumer.rb

@@ -16,15 +16,13 @@ class Consumer < ApplicationRecord
 
   after_create :generate_internal_study_group
 
+  delegate :to_s, to: :name
+
   def generate_internal_study_group
     StudyGroup.create!(consumer: self, name: "Default Study Group for #{name}", external_id: nil)
   end
   private :generate_internal_study_group
 
-  def to_s
-    name
-  end
-
   def self.ransackable_attributes(_auth_object = nil)
     %w[id]
   end

app/models/contributor.rb

@@ -9,6 +9,8 @@ class Contributor < ApplicationRecord
 
   has_many :submissions, as: :contributor
 
+  delegate :to_s, to: :displayname
+
   def learner?
     raise NotImplementedError
   end
@@ -33,10 +35,6 @@ def programming_group?
     is_a?(ProgrammingGroup)
   end
 
-  def to_s
-    displayname
-  end
-
   def to_page_context
     {
       id:,

app/models/error_template.rb

@@ -4,7 +4,5 @@ class ErrorTemplate < ApplicationRecord
   belongs_to :execution_environment
   has_and_belongs_to_many :error_template_attributes
 
-  def to_s
-    name
-  end
+  delegate :to_s, to: :name
 end

app/models/error_template_attribute.rb

@@ -3,7 +3,5 @@
 class ErrorTemplateAttribute < ApplicationRecord
   has_and_belongs_to_many :error_template
 
-  def to_s
-    key
-  end
+  delegate :to_s, to: :key
 end

app/models/execution_environment.rb

@@ -40,9 +40,7 @@ class ExecutionEnvironment < ApplicationRecord
   after_rollback :delete_runner_environment, on: :create
   after_rollback :sync_runner_environment, on: %i[update destroy]
 
-  def to_s
-    name
-  end
+  delegate :to_s, to: :name
 
   def to_json(*_args)
     {

app/models/exercise.rb

@@ -46,6 +46,8 @@ class Exercise < ApplicationRecord
   validates :token, presence: true, uniqueness: true
   validates :uuid, uniqueness: {if: -> { uuid.present? }}
 
+  delegate :to_s, to: :title
+
   @working_time_statistics = nil
   attr_reader :working_time_statistics
 
@@ -558,10 +560,6 @@ def set_default_values
   end
   private :set_default_values
 
-  def to_s
-    title
-  end
-
   def valid_main_file?
     if files.count(&:main_file?) > 1
       errors.add(:files, :at_most_one_main_file)

app/models/file_template.rb

@@ -3,7 +3,5 @@
 class FileTemplate < ApplicationRecord
   belongs_to :file_type
 
-  def to_s
-    name
-  end
+  delegate :to_s, to: :name
 end

app/models/file_type.rb

@@ -28,6 +28,8 @@ class FileType < ApplicationRecord
   validates :renderable, inclusion: [true, false]
   validates :file_extension, length: {minimum: 0, allow_nil: false}
 
+  delegate :to_s, to: :name
+
   %i[audio compressed csv excel image pdf powerpoint video word].each do |type|
     define_method(:"#{type}?") do
       self.class.const_get(:"#{type.upcase}_FILE_EXTENSIONS").include?(file_extension)
@@ -42,8 +44,4 @@ def set_default_values
   def programming_language
     editor_mode&.gsub('ace/mode/', '')
   end
-
-  def to_s
-    name
-  end
 end

app/models/intervention.rb

@@ -6,9 +6,7 @@ class Intervention < ApplicationRecord
   has_many :internal_users, through: :user_exercise_interventions, source: :contributor, source_type: 'InternalUser'
   has_many :programming_groups, through: :user_exercise_interventions, source: :contributor, source_type: 'ProgrammingGroup'
 
-  def to_s
-    name
-  end
+  delegate :to_s, to: :name
 
   def contributors
     @contributors ||= internal_users.distinct + external_users.distinct + programming_groups.distinct