Memorize use of configuration in Policy

Author: arkirchner

app/policies/request_for_comment_policy.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 class RequestForCommentPolicy < ApplicationPolicy
+  REPORT_RECEIVER_CONFIGURED = CodeOcean::Config.new(:code_ocean).read.dig(:content_moderation, :report_emails).present?
+
   def create?
     everyone
   end
@@ -42,15 +44,11 @@ def rfcs_with_my_comments?
   end
 
   def report?
-    report_receiver_configured? && show? && !author?
+    REPORT_RECEIVER_CONFIGURED && show? && !author?
   end
 
   private
 
-  def report_receiver_configured?
-    CodeOcean::Config.new(:code_ocean).read.dig(:content_moderation, :report_emails).present?
-  end
-
   def rfc_visibility
     # The consumer with the most restricted visibility determines the visibility of the RfC
     case [@user.consumer.rfc_visibility, @record.author.consumer.rfc_visibility]

spec/policies/request_for_comment_policy_spec.rb

@@ -5,14 +5,10 @@
 RSpec.describe RequestForCommentPolicy do
   subject(:policy) { described_class }
 
-  let(:report_emails) { [] }
+  let(:reports_enabled) { false }
 
   before do
-    codeocean_config = instance_double(CodeOcean::Config)
-    allow(CodeOcean::Config).to receive(:new).with(:code_ocean).and_return(codeocean_config)
-    allow(codeocean_config).to receive(:read).and_return({
-      content_moderation: {report_emails:},
-    })
+    stub_const('RequestForCommentPolicy::REPORT_RECEIVER_CONFIGURED', reports_enabled)
   end
 
   context 'when the RfC visibility is not considered' do
@@ -59,7 +55,7 @@
 
     permissions(:report?) do
       context 'when report emails are configured' do
-        let(:report_emails) { ['[email protected]'] }
+        let(:reports_enabled) { true }
 
         it 'allows anyone to report RfCs' do
           %i[admin external_user teacher].each do |factory_name|
@@ -69,8 +65,6 @@
       end
 
       context 'when no report email is configured' do
-        let(:report_emails) { [] }
-
         it 'does not allow reports from anyone' do
           %i[admin external_user teacher].each do |factory_name|
             expect(policy).not_to permit(create(factory_name), RequestForComment.new)
@@ -172,7 +166,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to everyone', {block_author: true}
           end
@@ -189,7 +183,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -206,7 +200,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -230,7 +224,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to everyone', {block_author: true}
           end
@@ -250,7 +244,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to everyone', {block_author: true}
           end
@@ -273,7 +267,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -290,7 +284,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -307,7 +301,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -331,7 +325,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to everyone', {block_author: true}
           end
@@ -351,7 +345,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to everyone', {block_author: true}
           end
@@ -374,7 +368,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -391,7 +385,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -408,7 +402,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -428,7 +422,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to admins only'
           end
@@ -448,7 +442,7 @@
           end
 
           permissions(:report?) do
-            let(:report_emails) { ['[email protected]'] }
+            let(:reports_enabled) { true }
 
             it_behaves_like 'grants access to everyone', {block_author: true}
           end

spec/system/request_for_comments_filter_system_spec.rb

@@ -47,11 +47,12 @@
 
   describe 'reporting of user content' do
     before do
+      stub_const('RequestForCommentPolicy::REPORT_RECEIVER_CONFIGURED', reports_enabled)
       visit(request_for_comment_path(create(:rfc)))
     end
 
     context 'when reporting is enabled' do
-      let(:report_emails) { ['[email protected]'] }
+      let(:reports_enabled) { true }
 
       it 'allows reporting of RfCs', :js do
         accept_confirm do
@@ -63,6 +64,8 @@
     end
 
     context 'when reporting is disabled' do
+      let(:reports_enabled) { false }
+
       it 'dose not display the report button' do
         expect(page).to have_no_button(I18n.t('request_for_comments.report.report'))
       end