Fix Rubocop offenses

Author: MrSerth

app/controllers/community_solutions_controller.rb

@@ -32,14 +32,14 @@ def edit
       # If the first user did not save, the ReadMe file already exists
       @files << CodeOcean::File.find_or_create_by!(new_readme_file)
     end
-    all_visible_files = last_contribution.files.select(&:visible)
+    all_visible_files = last_contribution.files.select(&:visible?)
     # Add the ReadMe file first
     @files += all_visible_files.select {|f| CodeOcean::File.find_by(id: f.file_id)&.context_type == 'CommunitySolution' }
     # Then, add all remaining files and sort them by name with extension
     @files += (all_visible_files - @files).sort_by(&:filepath)
 
     # Own Submission as a reference
-    @own_files = @submission.collect_files.select(&:visible).sort_by(&:filepath)
+    @own_files = @submission.collect_files.select(&:visible?).sort_by(&:filepath)
     # Remove the file_id from the second graph. Otherwise, the comparison and file-tree selection does not work as expected
     @own_files.map do |file|
       file.file_id = nil

app/controllers/exercises_controller.rb

@@ -418,7 +418,7 @@ def implement # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedC
     @hide_rfc_button = @embed_options[:disable_rfc]
 
     @submission = current_contributor.submissions.order(created_at: :desc).find_by(exercise: @exercise)
-    @files = (@submission ? @submission.collect_files : @exercise.files).select(&:visible).sort_by(&:filepath)
+    @files = (@submission ? @submission.collect_files : @exercise.files).select(&:visible?).sort_by(&:filepath)
     @paths = collect_paths(@files)
   end
 

app/controllers/submissions_controller.rb

@@ -469,7 +469,7 @@ def set_files_and_specific_file
   end
 
   def set_files
-    @files = @submission.collect_files.select(&:visible)
+    @files = @submission.collect_files.select(&:visible?)
   end
 
   def set_submission

app/models/code_ocean/file.rb

@@ -153,7 +153,7 @@ def set_default_values
     end
     private :set_default_values
 
-    def visible
+    def visible?
       !hidden
     end
 

app/models/exercise.rb

@@ -377,7 +377,7 @@ def get_quantiles(quantiles)
       SELECT   unnest(percentile_cont(#{self.class.sanitize_sql(['array[?]', quantiles])}) within GROUP (ORDER BY working_time))
       FROM     result
       ")
-    if result.count.positive?
+    if result.any?
       quantiles.each_with_index.map {|_q, i| parse_duration(result[i]['unnest']).to_f }
     else
       quantiles.map {|_q| 0 }
@@ -512,7 +512,7 @@ def set_default_values
   private :set_default_values
 
   def valid_main_file?
-    if files.count(&:main_file?) > 1
+    if files.many?(&:main_file?)
       errors.add(:files, :at_most_one_main_file)
     end
   end

app/models/testrun_message.rb

@@ -99,7 +99,7 @@ def self.validate_and_store!(messages)
   private_class_method :validate_and_store!
 
   def either_data_or_log
-    if [data, log].count(&:present?) > 1
+    if [data, log].many?(&:present?)
       errors.add(log, "can't be present if data is also present")
     end
   end

app/views/shared/_form_errors.html.slim

@@ -1,6 +1,6 @@
 - if object.errors.any?
   #error_explanation.alert.alert-warning
-    h4 = "#{t("shared.errors_#{object.errors.count == 1 ? 'one' : 'other'}", count: object.errors.count, model: object.class.model_name.human)}:"
+    h4 = "#{t("shared.errors_#{object.errors.one? ? 'one' : 'other'}", count: object.errors.count, model: object.class.model_name.human)}:"
     ul
       - object.errors.full_messages.each do |message|
         li = message

app/views/submissions/show.json.jbuilder

@@ -5,7 +5,7 @@ json.files @submission.files do |file|
   json.extract! file, :id, :file_id
 end
 unless @embed_options[:disable_download]
-  json.render_url @submission.collect_files.select(&:visible) do |files|
+  json.render_url @submission.collect_files.select(&:visible?) do |files|
     host = ApplicationController::RENDER_HOST || request.host
     url = render_submission_url(@submission, files.filepath, host:)
 

lib/java21_study.rb

@@ -1,30 +1,30 @@
 # frozen_string_literal: true
 
 class Java21Study
-  def self.get_for(exercise)
+  def self.get_for?(exercise)
     java21_collection = ExerciseCollection.find_by(name: 'java2021', id: 13)
 
     exercise.exercise_collections.include? java21_collection
   end
 
   def self.show_tips_intervention?(user, exercise)
-    java21_exercise = get_for(exercise)
+    java21_exercise = get_for?(exercise)
     return false unless java21_exercise # Exercise is not part of the experiment
 
     user_group = UserGroupSeparator.get_intervention_group(user.id)
     user_group == :show_tips_intervention
   end
 
   def self.show_break_intervention?(user, exercise)
-    java21_exercise = get_for(exercise)
+    java21_exercise = get_for?(exercise)
     return false unless java21_exercise # Exercise is not part of the experiment
 
     user_group = UserGroupSeparator.get_intervention_group(user.id)
     user_group == :show_break_intervention
   end
 
   def self.allow_redirect_to_community_solution?(user, exercise)
-    java21_exercise = get_for(exercise)
+    java21_exercise = get_for?(exercise)
     return false unless java21_exercise # Exercise is not part of the experiment
 
     user_group = UserGroupSeparator.get_community_solution_group(user.id)

spec/system/editor_system_spec.rb

@@ -44,7 +44,7 @@
 
   it 'displays all visible files in a file tree' do
     within('#files') do
-      exercise.files.select(&:visible).each do |file|
+      exercise.files.select(&:visible?).each do |file|
         expect(page).to have_content(file.name_with_extension)
       end
     end