FINERACT-2181: Swagger enhancement for PostSavingsProductsRequest

Author: Jose Alberto Hernandez

fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/factory/SavingsProductRequestFactory.java

@@ -18,8 +18,8 @@
  */
 package org.apache.fineract.test.factory;
 
-import java.util.HashSet;
-import java.util.Set;
+import java.util.ArrayList;
+import java.util.List;
 import org.apache.fineract.client.models.PostSavingsCharges;
 import org.apache.fineract.client.models.PostSavingsProductsRequest;
 
@@ -43,7 +43,7 @@ public final class SavingsProductRequestFactory {
     private SavingsProductRequestFactory() {}
 
     public static PostSavingsProductsRequest defaultSavingsProductRequest() {
-        Set<PostSavingsCharges> charges = new HashSet<>();
+        List<PostSavingsCharges> charges = new ArrayList<>();
 
         return new PostSavingsProductsRequest().name(DEFAULT_SAVINGS_PRODUCT_NAME)//
                 .shortName(DEFAULT_SAVINGS_PRODUCT_SHORT_NAME)//

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsProductsApiResourceSwagger.java

@@ -69,9 +69,19 @@ private PostSavingsCharges() {}
         public Integer interestCalculationDaysInYearType;
         @Schema(example = "1")
         public Integer accountingRule;
-        public Set<PostSavingsCharges> charges;
+        public List<PostSavingsCharges> charges;
         @Schema(example = "accountMappingForPayment")
         public String accountMappingForPayment;
+        @Schema(example = "false")
+        public Boolean withdrawalFeeForTransfers;
+        @Schema(example = "false")
+        public Boolean enforceMinRequiredBalance;
+        @Schema(example = "false")
+        public Boolean allowOverdraft;
+        @Schema(example = "false")
+        public Boolean withHoldTax;
+        @Schema(example = "false")
+        public Boolean isDormancyTrackingActive;
     }
 
     @Schema(description = "PostSavingsProductsResponse")

integration-tests/src/test/java/org/apache/fineract/integrationtests/savings/base/BaseSavingsIntegrationTest.java

@@ -119,7 +119,12 @@ protected PostSavingsProductsRequest dailyInterestPostingProduct() {
                 .accountingRule(1) // none
                 .interestCalculationDaysInYearType(DaysInYearType.DAYS_365).interestCompoundingPeriodType(InterestPeriodType.DAILY)
                 .interestCalculationType(InterestCalculationType.AVERAGE_DAILY_BALANCE) //
-                .interestPostingPeriodType(InterestPeriodType.DAILY);//
+                .interestPostingPeriodType(InterestPeriodType.DAILY) //
+                .withdrawalFeeForTransfers(false) //
+                .enforceMinRequiredBalance(false) //
+                .allowOverdraft(false) //
+                .withHoldTax(false) //
+                .isDormancyTrackingActive(false); //
     }
 
     protected PostSavingsProductsResponse createProduct(PostSavingsProductsRequest productsRequest) {