Skip to content

Commit 9d55b23

Browse files
biplab1niyajali
andauthored
fix(faq, settings, notification): resolve overlapping screens during transitions (#1913)
Co-authored-by: Sk Niyaj Ali <[email protected]>
1 parent 9b2e013 commit 9d55b23

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

feature/faq/src/commonMain/kotlin/org/mifospay/feature/faq/FaqScreen.kt

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import androidx.compose.foundation.layout.fillMaxWidth
2424
import androidx.compose.foundation.layout.padding
2525
import androidx.compose.foundation.lazy.LazyColumn
2626
import androidx.compose.foundation.lazy.itemsIndexed
27+
import androidx.compose.foundation.lazy.rememberLazyListState
2728
import androidx.compose.material3.Card
2829
import androidx.compose.material3.CardDefaults
2930
import androidx.compose.material3.HorizontalDivider
@@ -46,7 +47,7 @@ import mobile_wallet.feature.faq.generated.resources.feature_faq
4647
import org.jetbrains.compose.resources.stringResource
4748
import org.jetbrains.compose.ui.tooling.preview.Preview
4849
import org.koin.compose.viewmodel.koinViewModel
49-
import org.mifospay.core.designsystem.component.MifosTopBar
50+
import org.mifospay.core.designsystem.component.MifosScaffold
5051
import org.mifospay.core.designsystem.icon.MifosIcons
5152
import org.mifospay.core.ui.utils.EventsEffect
5253
import template.core.base.designsystem.theme.KptTheme
@@ -80,20 +81,20 @@ private fun FaqScreen(
8081
onAction: (FaqAction) -> Unit,
8182
modifier: Modifier = Modifier,
8283
) {
83-
Column(
84-
modifier = modifier
85-
.fillMaxSize(),
86-
) {
87-
MifosTopBar(
88-
topBarTitle = stringResource(Res.string.feature_faq),
89-
backPress = {
90-
onAction(FaqAction.NavigateBack)
91-
},
92-
)
84+
MifosScaffold(
85+
modifier = modifier,
86+
topBarTitle = stringResource(Res.string.feature_faq),
87+
backPress = {
88+
onAction(FaqAction.NavigateBack)
89+
},
90+
containerColor = KptTheme.colorScheme.background,
91+
) { contentPadding ->
92+
val listState = rememberLazyListState()
93+
9394
LazyColumn(
94-
modifier = Modifier
95-
.weight(1f)
96-
.fillMaxWidth(),
95+
state = listState,
96+
modifier = Modifier.fillMaxSize(),
97+
contentPadding = contentPadding,
9798
) {
9899
itemsIndexed(
99100
items = state.faqList,

feature/notification/src/commonMain/kotlin/org/mifospay/feature/notification/NotificationScreen.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ internal fun NotificationScreen(
7474
topBarTitle = stringResource(Res.string.feature_notification_notifications),
7575
backPress = navigateBack,
7676
modifier = modifier,
77+
containerColor = KptTheme.colorScheme.background,
7778
) {
7879
Box(
7980
modifier = Modifier

feature/settings/src/commonMain/kotlin/org/mifospay/feature/settings/SettingsScreen.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ private fun SettingsScreenContent(
102102
backPress = {
103103
onAction(SettingsAction.NavigateBack)
104104
},
105+
containerColor = KptTheme.colorScheme.background,
105106
) { contentPadding ->
106107
Column(
107108
modifier = Modifier

0 commit comments

Comments
 (0)