Skip to content

Commit 0136b82

Browse files
committed
Fix(WEB-114): Implement modern empty state for Group list
Signed-off-by: Harsh Deep <deepkashyapharsh@gmail.com>
1 parent 191033f commit 0136b82

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

src/app/groups/groups.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
<div *ngIf="(dataSource?.records$ | async) === 0" class="empty-state-container">
2929
<div class="m-t-40 m-b-40 text-center">
3030
<fa-icon icon="users" size="6x" class="gray-text m-b-20"></fa-icon>
31-
<h2 class="mat-h2">No Groups Found</h2>
32-
<p class="gray-text">We couldn't find any groups. Try a different search or create one now.</p>
31+
<h2 class="mat-h2">{{ 'labels.text.No Groups Found' | translate }}</h2>
32+
<p class="gray-text">{{ 'labels.text.No Groups Found Description' | translate }}</p>
3333
<button mat-raised-button color="primary" [routerLink]="['create']">
34-
<fa-icon icon="plus" class="m-r-10"></fa-icon> Create Your First Group
34+
<fa-icon icon="plus" class="m-r-10"></fa-icon> {{ 'labels.buttons.Create Your First Group' | translate }}
3535
</button>
3636
</div>
3737
</div>

src/app/groups/groups.component.scss

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,31 @@
77
*/
88

99
@use '../shared/styles/list-layout' as *;
10+
@use '../../assets/styles/colours' as *; // This imports the official Mifos colors
1011

1112
.empty-state-container {
1213
display: flex;
1314
flex-direction: column;
1415
align-items: center;
1516
justify-content: center;
16-
padding: 80px 20px;
17-
background-color: #f9f9f9;
18-
border: 2px dashed #e0e0e0;
19-
border-radius: 12px;
20-
margin: 20px 0;
17+
padding: 80px 24px; // 24 is a multiple of 8
18+
background-color: $light-grey; // Uses official variable instead of #f9f9f9
19+
border: 2px dashed $silver; // Uses official variable instead of #e0e0e0
20+
border-radius: 8px; // 8 is a multiple of 8
21+
margin: 24px 0;
2122

2223
.gray-text {
23-
color: #757575;
24+
color: $asbestos; // Uses official variable instead of #757575
2425
font-size: 1.1rem;
25-
margin-bottom: 25px;
26+
margin-bottom: 24px;
2627
}
2728

2829
fa-icon {
29-
color: #bdbdbd;
30+
color: $silver;
3031
}
3132

3233
h2 {
33-
margin-top: 10px;
34+
margin-top: 8px;
3435
font-weight: 500;
3536
}
3637
}

src/assets/translations/en-US.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,7 @@
351351
"Home": "Home"
352352
},
353353
"buttons": {
354+
"Create Your First Group": "Create Your First Group",
354355
"Accept Transfer": "Accept Transfer",
355356
"Actions": "Actions",
356357
"Activate": "Activate",
@@ -3059,6 +3060,8 @@
30593060
"the Transaction Type": "the Transaction Type"
30603061
},
30613062
"text": {
3063+
"No Groups Found": "No Groups Found",
3064+
"No Groups Found Description": "We couldn't find any groups. Try a different search or create one now.",
30623065
"About Us": "About Us",
30633066
"A": "A",
30643067
"Account Transfers": "Account Transfers",

0 commit comments

Comments
 (0)