fix: Add error message localization and fix JSON translation syntax

- Fixed missing commas in Spanish translation files (es-MX.json, es-CL.json)
- Fixed JSON structure issues in en-US.json
- Added comprehensive error message keys for all HTTP error types
- Enhanced ErrorHandlerInterceptor to support Fineract userMessageGlobalisationCode
- Implemented proper i18n translation for error alerts (401, 403, 404, 500, 501)

fix: WEB-862 Localise the error as per the selected language

Author: saksham869

package-lock.json

@@ -11,7 +11,7 @@ import { Injectable, inject } from '@angular/core';
 import { HttpEvent, HttpInterceptor, HttpHandler, HttpRequest, HttpErrorResponse } from '@angular/common/http';
 
 /** rxjs Imports */
-import { EMPTY, Observable } from 'rxjs';
+import { Observable } from 'rxjs';
 import { catchError } from 'rxjs/operators';
 
 /** Environment Configuration */
@@ -20,13 +20,14 @@ import { environment } from '../../../environments/environment';
 /** Custom Services */
 import { Logger } from '../logger/logger.service';
 import { AlertService } from '../alert/alert.service';
-import { TranslateService } from '@ngx-translate/core'; // Added import for TranslateService
+import { TranslateService } from '@ngx-translate/core';
 
 /** Initialize Logger */
 const log = new Logger('ErrorHandlerInterceptor');
 
 /**
  * Http Request interceptor to add a default error handler to requests.
+ * Supports localisation of error messages using Fineract's userMessageGlobalisationCode.
  */
 @Injectable()
 export class ErrorHandlerInterceptor implements HttpInterceptor {
@@ -42,60 +43,98 @@ export class ErrorHandlerInterceptor implements HttpInterceptor {
 
   /**
    * Error handler.
+   * Uses userMessageGlobalisationCode from Fineract error response to localise error messages.
    */
   private handleError(response: HttpErrorResponse, request: HttpRequest<any>): Observable<HttpEvent<any>> {
     const status = response.status;
-    let errorMessage = response.error.developerMessage || response.message;
-    if (response.error.errors) {
+    let errorMessage = response.error?.developerMessage || response.message;
+    let globalisationCode: string | null = null;
+
+    // Extract globalisation code and message from Fineract error response
+    if (response.error?.errors) {
       if (response.error.errors[0]) {
+        globalisationCode = response.error.errors[0].userMessageGlobalisationCode || null;
         errorMessage = response.error.errors[0].defaultUserMessage || response.error.errors[0].developerMessage;
       }
     }
 
+    // Also check top-level userMessageGlobalisationCode
+    if (response.error?.userMessageGlobalisationCode) {
+      globalisationCode = response.error.userMessageGlobalisationCode;
+    }
+
+    // If we have a globalisation code, try to translate it with variable substitution
+    if (globalisationCode) {
+      const translated = this.translate.instant(globalisationCode, response.error?.errors?.[0] || response.error || {});
+      // Only use translation if the key actually exists (translate returns the key itself if not found)
+      if (translated !== globalisationCode) {
+        errorMessage = translated;
+      }
+    }
+
     const isClientImage404 = status === 404 && request.url.includes('/clients/') && request.url.includes('/images');
 
     if (!environment.production && !isClientImage404) {
       log.error(`Request Error: ${errorMessage}`);
     }
 
-    if (status === 401 || (environment.oauth.enabled && status === 400)) {
-      this.alertService.alert({ type: 'Authentication Error', message: 'Invalid User Details. Please try again!' });
-    } else if (status === 403 && errorMessage === 'The provided one time token is invalid') {
-      this.alertService.alert({ type: 'Invalid Token', message: 'Invalid Token. Please try again!' });
+    // Check specific 403 error (invalid token) BEFORE generic 403 (higher priority)
+    if (status === 403 && globalisationCode === 'error.token.invalid') {
+      this.alertService.alert({
+        type: this.translate.instant('error.token.invalid.type'),
+        message: this.translate.instant('error.token.invalid.message')
+      });
+    } else if (status === 401) {
+      // Allow Fineract translations for 401 errors
+      this.alertService.alert({
+        type: this.translate.instant('error.auth.type'),
+        message: errorMessage || this.translate.instant('error.auth.message')
+      });
+    } else if (environment.oauth.enabled && status === 400) {
+      this.alertService.alert({
+        type: this.translate.instant('error.auth.type'),
+        message: this.translate.instant('error.auth.message')
+      });
     } else if (status === 400) {
       this.alertService.alert({
-        type: 'Bad Request',
-        message: errorMessage || 'Invalid parameters were passed in the request!'
+        type: this.translate.instant('error.bad.request.type'),
+        message: errorMessage || this.translate.instant('error.bad.request.message')
       });
     } else if (status === 403) {
       this.alertService.alert({
-        type: 'Unauthorized Request',
-        message: errorMessage || 'You are not authorized for this request!'
+        type: this.translate.instant('error.unauthorized.type'),
+        message: errorMessage || this.translate.instant('error.unauthorized.message')
       });
     } else if (status === 404) {
-      // Check if this is an image request that should be silently handled (client profile image)
       if (isClientImage404) {
-        // Don't show alerts for missing client images
-        // This is an expected condition, not an error
-        return EMPTY;
+        // Return observable of null for missing client images so imaging service can handle gracefully
+        return new Observable((observer) => {
+          observer.next(null);
+          observer.complete();
+        });
       } else {
         this.alertService.alert({
-          type: this.translate.instant('error.resource.not.found'),
-          message: errorMessage || 'Resource does not exist!'
+          type: this.translate.instant('error.resource.not.found.type'),
+          message: errorMessage || this.translate.instant('error.resource.not.found.message')
         });
       }
     } else if (status === 500) {
+      // Allow Fineract translations for 500 errors
       this.alertService.alert({
-        type: 'Internal Server Error',
-        message: 'Internal Server Error. Please try again later.'
+        type: this.translate.instant('error.server.internal.type'),
+        message: errorMessage || this.translate.instant('error.server.internal.message')
       });
     } else if (status === 501) {
+      // Allow Fineract translations for 501 errors
       this.alertService.alert({
         type: this.translate.instant('error.resource.notImplemented.type'),
-        message: this.translate.instant('error.resource.notImplemented.message')
+        message: errorMessage || this.translate.instant('error.resource.notImplemented.message')
       });
     } else {
-      this.alertService.alert({ type: 'Unknown Error', message: 'Unknown Error. Please try again later.' });
+      this.alertService.alert({
+        type: this.translate.instant('error.unknown.type'),
+        message: this.translate.instant('error.unknown.message')
+      });
     }
 
     throw response;

src/app/core/http/error-handler.interceptor.ts

@@ -4,6 +4,20 @@
   "Remember me": "Zapamatuj si mě",
   "error.resource.notImplemented.type": "Nenaimplementovaná chyba",
   "error.resource.notImplemented.message": "Funkce není implementována!",
+  "error.auth.type": "Chyba ověřování",
+  "error.auth.message": "Neplatné údaje o uživateli. Zkuste prosím znovu!",
+  "error.token.invalid.type": "Neplatný token",
+  "error.token.invalid.message": "Neplatný token. Zkuste prosím znovu!",
+  "error.bad.request.type": "Špatný požadavek",
+  "error.bad.request.message": "V požadavku byly předány neplatné parametry!",
+  "error.unauthorized.type": "Neautorizovaný požadavek",
+  "error.unauthorized.message": "Nemáte oprávnění pro tento požadavek!",
+  "error.resource.not.found.type": "Zdroj nenalezen",
+  "error.resource.not.found.message": "Zdroj neexistuje!",
+  "error.server.internal.type": "Interní chyba serveru",
+  "error.server.internal.message": "Interní chyba serveru. Zkuste prosím později.",
+  "error.unknown.type": "Neznámá chyba",
+  "error.unknown.message": "Neznámá chyba. Zkuste prosím později.",
   "errors": {
     "accountingRule": {
       "duplicateName": "Omlouváme se, ale účetní pravidlo s tímto názvem již existuje."

src/assets/translations/cs-CS.json

@@ -4,6 +4,20 @@
   "Remember me": "Erinnere dich an mich",
   "error.resource.notImplemented.type": "Nicht implementierter Fehler",
   "error.resource.notImplemented.message": "Nicht implementierte Funktion!",
+  "error.auth.type": "Authentifizierungsfehler",
+  "error.auth.message": "Ungültige Benutzerdetails. Bitte versuchen Sie es erneut!",
+  "error.token.invalid.type": "Ungültiger Token",
+  "error.token.invalid.message": "Ungültiger Token. Bitte versuchen Sie es erneut!",
+  "error.bad.request.type": "Ungültige Anfrage",
+  "error.bad.request.message": "Ungültige Parameter wurden in der Anfrage übergeben!",
+  "error.unauthorized.type": "Unbefugte Anfrage",
+  "error.unauthorized.message": "Sie sind nicht berechtigt für diese Anfrage!",
+  "error.resource.not.found.type": "Ressource nicht gefunden",
+  "error.resource.not.found.message": "Die Ressource existiert nicht!",
+  "error.server.internal.type": "Interner Serverfehler",
+  "error.server.internal.message": "Interner Serverfehler. Bitte versuchen Sie es später erneut.",
+  "error.unknown.type": "Unbekannter Fehler",
+  "error.unknown.message": "Unbekannter Fehler. Bitte versuchen Sie es später erneut.",
   "errors": {
     "accountingRule": {
       "duplicateName": "Entschuldigung, aber eine Buchungsregel mit diesem Namen existiert bereits."

src/assets/translations/de-DE.json

@@ -4,6 +4,20 @@
   "Remember me": "Remember me",
   "error.resource.notImplemented.type": "Not Implemented Error",
   "error.resource.notImplemented.message": "Not implemented functionality!",
+  "error.auth.type": "Authentication Error",
+  "error.auth.message": "Invalid User Details. Please try again!",
+  "error.token.invalid.type": "Invalid Token",
+  "error.token.invalid.message": "Invalid Token. Please try again!",
+  "error.bad.request.type": "Bad Request",
+  "error.bad.request.message": "Invalid parameters were passed in the request!",
+  "error.unauthorized.type": "Unauthorized Request",
+  "error.unauthorized.message": "You are not authorized for this request!",
+  "error.resource.not.found.type": "Resource Not Found",
+  "error.resource.not.found.message": "Resource does not exist!",
+  "error.server.internal.type": "Internal Server Error",
+  "error.server.internal.message": "Internal Server Error. Please try again later.",
+  "error.unknown.type": "Unknown Error",
+  "error.unknown.message": "Unknown Error. Please try again later.",
   "errors": {
     "accountingRule": {
       "duplicateName": "Sorry, but an Accounting Rule with this Name exists already."

src/assets/translations/en-US.json

@@ -8,6 +8,20 @@
     },
     "error.resource.notImplemented.type": "Error no implementado",
     "error.resource.notImplemented.message": "¡Funcionalidad no implementada!",
+    "error.auth.type": "Error de autenticación",
+    "error.auth.message": "Datos de usuario inválidos. ¡Por favor, inténtelo de nuevo!",
+    "error.token.invalid.type": "Token inválido",
+    "error.token.invalid.message": "Token inválido. ¡Por favor, inténtelo de nuevo!",
+    "error.bad.request.type": "Solicitud incorrecta",
+    "error.bad.request.message": "Se enviaron parámetros no válidos en la solicitud.",
+    "error.unauthorized.type": "Solicitud no autorizada",
+    "error.unauthorized.message": "No está autorizado para esta solicitud.",
+    "error.resource.not.found.type": "Recurso no encontrado",
+    "error.resource.not.found.message": "¡El recurso no existe!",
+    "error.server.internal.type": "Error interno del servidor",
+    "error.server.internal.message": "Error interno del servidor. Por favor, inténtelo más tarde.",
+    "error.unknown.type": "Error desconocido",
+    "error.unknown.message": "Error desconocido. Por favor, inténtelo más tarde.",
     "linkedSavingsAccountOwnership": "La cuenta de ahorro vinculada no pertenece al cliente seleccionado.",
     "clientNotInGSIM": "El cliente con ID {{id}} no está presente en GSIM.",
     "Capitalized Income amount adjusted already adjusted": "Monto de Ingreso Capitalizado ajustado ya ajustado",

src/assets/translations/es-CL.json

@@ -8,6 +8,20 @@
     },
     "error.resource.notImplemented.type": "Error no implementado",
     "error.resource.notImplemented.message": "¡Funcionalidad no implementada!",
+    "error.auth.type": "Error de autenticación",
+    "error.auth.message": "Datos de usuario inválidos. ¡Por favor, inténtelo de nuevo!",
+    "error.token.invalid.type": "Token inválido",
+    "error.token.invalid.message": "Token inválido. ¡Por favor, inténtelo de nuevo!",
+    "error.bad.request.type": "Solicitud incorrecta",
+    "error.bad.request.message": "Se enviaron parámetros no válidos en la solicitud.",
+    "error.unauthorized.type": "Solicitud no autorizada",
+    "error.unauthorized.message": "No está autorizado para esta solicitud.",
+    "error.resource.not.found.type": "Recurso no encontrado",
+    "error.resource.not.found.message": "¡El recurso no existe!",
+    "error.server.internal.type": "Error interno del servidor",
+    "error.server.internal.message": "Error interno del servidor. Por favor, inténtelo más tarde.",
+    "error.unknown.type": "Error desconocido",
+    "error.unknown.message": "Error desconocido. Por favor, inténtelo más tarde.",
     "linkedSavingsAccountOwnership": "La cuenta de ahorro vinculada no pertenece al cliente seleccionado.",
     "clientNotInGSIM": "El cliente con ID {{id}} no está presente en GSIM.",
     "Capitalized Income amount adjusted already adjusted": "Monto de Ingreso Capitalizado ajustado ya ajustado",

src/assets/translations/es-MX.json

@@ -8,7 +8,20 @@
     },
     "error.resource.notImplemented.type": "Erreur non implémentée",
     "error.resource.notImplemented.message": "Fonctionnalité non implémentée !",
-    "linkedSavingsAccountOwnership": "Le compte d'épargne lié n'appartient pas au client sélectionné.",
+    "error.auth.type": "Erreur d'authentification",
+    "error.auth.message": "Détails utilisateur invalides. Veuillez réessayer!",
+    "error.token.invalid.type": "Token invalide",
+    "error.token.invalid.message": "Token invalide. Veuillez réessayer!",
+    "error.bad.request.type": "Mauvaise demande",
+    "error.bad.request.message": "Des paramètres invalides ont été transmis dans la demande!",
+    "error.unauthorized.type": "Demande non autorisée",
+    "error.unauthorized.message": "Vous n'êtes pas autorisé pour cette demande!",
+    "error.resource.not.found.type": "Ressource non trouvée",
+    "error.resource.not.found.message": "La ressource n'existe pas!",
+    "error.server.internal.type": "Erreur interne du serveur",
+    "error.server.internal.message": "Erreur interne du serveur. Veuillez réessayer plus tard.",
+    "error.unknown.type": "Erreur inconnue",
+    "error.unknown.message": "Erreur inconnue. Veuillez réessayer plus tard.",
     "clientNotInGSIM": "Le client avec l'ID {{id}} n'est pas membre du GSIM.",
     "Capitalized Income amount adjusted already adjusted": "Montant du revenu capitalisé ajusté déjà ajusté",
     "Capitalized Income Adjustment amount must be lower or equal to": "Le montant de l'ajustement du revenu capitalisé doit être inférieur ou égal à",

src/assets/translations/fr-FR.json

@@ -8,7 +8,20 @@
     },
     "error.resource.notImplemented.type": "Errore non implementato",
     "error.resource.notImplemented.message": "Funzionalità non implementata!",
-    "linkedSavingsAccountOwnership": "Il conto di risparmio collegato non appartiene al cliente selezionato.",
+    "error.auth.type": "Errore di autenticazione",
+    "error.auth.message": "Dettagli utente non validi. Per favore riprova!",
+    "error.token.invalid.type": "Token non valido",
+    "error.token.invalid.message": "Token non valido. Per favore riprova!",
+    "error.bad.request.type": "Richiesta non valida",
+    "error.bad.request.message": "Parametri non validi sono stati trasmessi nella richiesta!",
+    "error.unauthorized.type": "Richiesta non autorizzata",
+    "error.unauthorized.message": "Non sei autorizzato per questa richiesta!",
+    "error.resource.not.found.type": "Risorsa non trovata",
+    "error.resource.not.found.message": "La risorsa non esiste!",
+    "error.server.internal.type": "Errore interno del server",
+    "error.server.internal.message": "Errore interno del server. Per favore riprova più tardi.",
+    "error.unknown.type": "Errore sconosciuto",
+    "error.unknown.message": "Errore sconosciuto. Per favore riprova più tardi.",
     "clientNotInGSIM": "Il cliente con ID {{id}} non è presente in GSIM.",
     "Capitalized Income amount adjusted already adjusted": "Importo del reddito capitalizzato rettificato già rettificato",
     "Capitalized Income Adjustment amount must be lower or equal to": "L'importo dell'adeguamento del reddito capitalizzato deve essere inferiore o uguale a",

src/assets/translations/it-IT.json

@@ -8,7 +8,20 @@
     },
     "error.resource.notImplemented.type": "구현되지 않은 오류",
     "error.resource.notImplemented.message": "구현되지 않은 기능입니다!",
-    "linkedSavingsAccountOwnership": "연결된 저축 계좌가 선택한 클라이언트에 속하지 않습니다.",
+    "error.auth.type": "인증 오류",
+    "error.auth.message": "잘못된 사용자 세부정보입니다. 다시 시도해주세요!",
+    "error.token.invalid.type": "유효하지 않은 토큰",
+    "error.token.invalid.message": "유효하지 않은 토큰입니다. 다시 시도해주세요!",
+    "error.bad.request.type": "잘못된 요청",
+    "error.bad.request.message": "요청에 잘못된 매개변수가 전달되었습니다!",
+    "error.unauthorized.type": "승인되지 않은 요청",
+    "error.unauthorized.message": "이 요청에 대해 권한이 없습니다!",
+    "error.resource.not.found.type": "리소스를 찾을 수 없음",
+    "error.resource.not.found.message": "리소스가 존재하지 않습니다!",
+    "error.server.internal.type": "내부 서버 오류",
+    "error.server.internal.message": "내부 서버 오류입니다. 나중에 다시 시도해주세요.",
+    "error.unknown.type": "알 수 없는 오류",
+    "error.unknown.message": "알 수 없는 오류입니다. 나중에 다시 시도해주세요.",
     "clientNotInGSIM": "ID가 {{id}}인 클라이언트가 GSIM에 없습니다.",
     "Capitalized Income amount adjusted already adjusted": "자본화된 소득 금액은 이미 조정되었습니다.",
     "Capitalized Income Adjustment amount must be lower or equal to": "자본화된 소득 조정 금액은 다음보다 낮거나 같아야 합니다.",