fix(WEB-370): handle Fineract 500 errors gracefully for provisioning entries

Author: YousufFFFF

src/app/accounting/provisioning-entries/create-provisioning-entry/create-provisioning-entry.component.ts

@@ -69,22 +69,32 @@ export class CreateProvisioningEntryComponent implements OnInit {
    * Submits the provisioning entry form and creates provisioning entry,
    * if successful redirects to view created entry.
    */
+
   submit() {
     const provisioningEntry = this.provisioningEntryForm.value;
-    // TODO: Update once language and date settings are setup
     provisioningEntry.locale = this.settingsService.language.code;
     provisioningEntry.dateFormat = this.settingsService.dateFormat;
     if (provisioningEntry.date instanceof Date) {
       provisioningEntry.date = this.dateUtils.formatDate(provisioningEntry.date, this.settingsService.dateFormat);
     }
-    this.accountingService.createProvisioningEntry(provisioningEntry).subscribe((response: any) => {
-      this.router.navigate(
-        [
-          '../view',
-          response.resourceId
-        ],
-        { relativeTo: this.route }
-      );
+
+    this.accountingService.createProvisioningEntry(provisioningEntry).subscribe({
+      next: (response: any) => {
+        this.router.navigate(
+          [
+            '../view',
+            response.resourceId
+          ],
+          { relativeTo: this.route }
+        );
+      },
+      error: (error: any) => {
+        if (error.status === 500) {
+          // Fineract returns 500 even when the entry is created successfully.
+          // Navigate to the list since we don't have a resourceId.
+          this.router.navigate(['../'], { relativeTo: this.route });
+        }
+      }
     });
   }
 }

src/app/accounting/provisioning-entries/view-provisioning-entry/provisioning-entry-entries.resolver.ts

@@ -9,26 +9,18 @@
 /** Angular Imports */
 import { Injectable, inject } from '@angular/core';
 import { ActivatedRouteSnapshot } from '@angular/router';
-
-/** rxjs Imports */
-import { Observable } from 'rxjs';
-
-/** Custom Services */
+import { Observable, of } from 'rxjs';
+import { catchError } from 'rxjs/operators';
 import { AccountingService } from '../../accounting.service';
 
-/**
- * Provisioning entry entries data resolver.
- */
 @Injectable()
 export class ProvisioningEntryEntriesResolver {
   private accountingService = inject(AccountingService);
 
-  /**
-   * Returns the provisioning entry entries data.
-   * @returns {Observable<any>}
-   */
   resolve(route: ActivatedRouteSnapshot): Observable<any> {
     const provisioningEntryId = route.paramMap.get('id');
-    return this.accountingService.getProvisioningEntryEntries(provisioningEntryId);
+    return this.accountingService
+      .getProvisioningEntryEntries(provisioningEntryId)
+      .pipe(catchError(() => of({ pageItems: [], error: true })));
   }
 }

src/app/accounting/provisioning-entries/view-provisioning-entry/provisioning-entry.resolver.ts

@@ -9,26 +9,18 @@
 /** Angular Imports */
 import { Injectable, inject } from '@angular/core';
 import { ActivatedRouteSnapshot } from '@angular/router';
-
-/** rxjs Imports */
-import { Observable } from 'rxjs';
-
-/** Custom Services */
+import { Observable, of } from 'rxjs';
+import { catchError } from 'rxjs/operators';
 import { AccountingService } from '../../accounting.service';
 
-/**
- * Provisioning entry data resolver.
- */
 @Injectable()
 export class ProvisioningEntryResolver {
   private accountingService = inject(AccountingService);
 
-  /**
-   * Returns the provisioning entry data.
-   * @returns {Observable<any>}
-   */
   resolve(route: ActivatedRouteSnapshot): Observable<any> {
     const provisioningEntryId = route.paramMap.get('id');
-    return this.accountingService.getProvisioningEntry(provisioningEntryId);
+    return this.accountingService
+      .getProvisioningEntry(provisioningEntryId)
+      .pipe(catchError(() => of({ id: provisioningEntryId, error: true })));
   }
 }

src/app/core/http/error-handler.interceptor.ts

@@ -85,10 +85,14 @@ export class ErrorHandlerInterceptor implements HttpInterceptor {
         });
       }
     } else if (status === 500) {
-      this.alertService.alert({
-        type: 'Internal Server Error',
-        message: 'Internal Server Error. Please try again later.'
-      });
+      const isProvisioningEntryGet = request.url.includes('/provisioningentries/') && request.method === 'GET';
+
+      if (!isProvisioningEntryGet) {
+        this.alertService.alert({
+          type: 'Internal Server Error',
+          message: 'Internal Server Error. Please try again later.'
+        });
+      }
     } else if (status === 501) {
       this.alertService.alert({
         type: this.translate.instant('error.resource.notImplemented.type'),