WEB-95: WEB-95 Fix problems with GLIM application: saved total, "Moratorium", "Overdue Charges""

Author: JaySoni1

src/app/app.module.ts

@@ -1,6 +1,7 @@
 /** Angular Imports */
 import { NgModule } from '@angular/core';
 import { BrowserModule } from '@angular/platform-browser';
+import { I18nService } from './core/i18n/i18n.service';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 import {
   HttpBackend,
@@ -129,7 +130,8 @@ export function HttpLoaderFactory(http: HttpClient) {
       provide: HTTP_INTERCEPTORS,
       useClass: !environment.OIDC.oidcServerEnabled ? TokenInterceptor : ZitadelTokenInterceptor,
       multi: true
-    }
+    },
+    I18nService
   ]
 })
 export class AppModule {}

src/app/loans/glim-account/create-glim-account/create-glim-account.component.ts

@@ -177,58 +177,42 @@ export class CreateGlimAccountComponent {
     };
   }
 
-  setData(client: any, totalLoan: number): any {
+  setData(applicationId: number, client: any, totalLoan: number, isFirst: boolean, isLast: boolean): any {
     const locale = this.settingsService.language.code;
     const dateFormat = this.settingsService.dateFormat;
     // const monthDayFormat = 'dd MMMM';
-    const data = {
+    const data: any = {
       ...this.loansAccount,
-      charges: (this.loansAccount.charges ?? [])
-        .map((charge: any) => {
-          const chargeId = charge.chargeId ?? charge.id;
-          if (chargeId == null) {
-            return null;
-          }
-          const mappedCharge: any = {
-            chargeId,
-            amount: charge.amount
-          };
-          if (charge.id && charge.id !== chargeId) {
-            mappedCharge.id = charge.id;
-          }
-          if (charge.dueDate) {
-            mappedCharge.dueDate = this.dateUtils.formatDate(charge.dueDate, dateFormat);
-          }
-          if (charge.feeInterval !== undefined) {
-            mappedCharge.feeInterval = charge.feeInterval;
-          }
-          if (charge.feeOnMonthDay !== undefined) {
-            mappedCharge.feeOnMonthDay = charge.feeOnMonthDay;
-          }
-          return mappedCharge;
-        })
-        .filter(Boolean),
+      charges: this.loansAccount.charges.map((charge: any) => ({
+        chargeId: charge.id,
+        amount: charge.amount,
+        currency: charge.currency
+      })),
       clientId: client.id,
       totalLoan: totalLoan,
       loanType: 'glim',
+      applicationId: applicationId,
       amortizationType: 1,
-      isParentAccount: true,
       principal: client.principal,
       syncDisbursementWithMeeting: false,
       expectedDisbursementDate: this.dateUtils.formatDate(this.loansAccount.expectedDisbursementDate, dateFormat),
       submittedOnDate: this.dateUtils.formatDate(this.loansAccount.submittedOnDate, dateFormat),
-      dateFormat,
-      // monthDayFormat,
-      locale
+      dateFormat: dateFormat,
+      locale: locale,
+      groupId: this.loansAccountTemplate.group.id
     };
-    data.groupId = this.loansAccountTemplate.group.id;
-
+    if (isFirst) {
+      data.isParentAccount = true;
+    }
+    if (isLast) {
+      data.lastApplication = true;
+    }
     delete data.principalAmount;
-    // TODO: 2025-03-17: Apparently (?!) unsupported for GLIM
     delete data.allowPartialPeriodInterestCalculation;
     delete data.multiDisburseLoan;
     delete data.isFloatingInterestRate;
-
+    delete data.moratoriumPrincipal;
+    delete data.moratoriumInterest;
     return JSON.stringify(data);
   }
 
@@ -237,12 +221,17 @@ export class CreateGlimAccountComponent {
     const requestData = [];
     const memberSelected = this.selectedMembers?.selectedMembers ?? [];
     const totalLoan = this.totalLoanAmount();
+    const applicationId = Math.floor(1000000000 + Math.random() * 9000000000);
+
     for (let index = 0; index < memberSelected.length; index++) {
+      const isFirst = index === 0;
+      const isLast = index === memberSelected.length - 1;
       requestData.push({
         requestId: index.toString(),
+        reference: index === 0 ? null : (index - 1).toString(),
         method: 'POST',
         relativeUrl: 'loans',
-        body: this.setData(memberSelected[index], totalLoan)
+        body: this.setData(applicationId, memberSelected[index], totalLoan, isFirst, isLast)
       });
     }
     return requestData;
@@ -257,57 +246,10 @@ export class CreateGlimAccountComponent {
     return total;
   }
 
-  /**
-   * Creates a new GLIM account.
-   */
-  submit() {
-    this.selectedMembers = this.loansActiveClientMembers?.selectedClientMembers;
-    const memberSelected = this.loansActiveClientMembers?.selectedClientMembers?.selectedMembers ?? [];
-    if (!memberSelected.length) return;
-    const gsimMemberIds = new Set(this.dataSource.map((m: any) => Number(m.id)));
-    for (const member of memberSelected) {
-      const memberId = Number(member.id);
-      // Validate savings account ownership
-      const ownerId = Number(member.linkAccountOwnerId);
-      if (member.linkAccountId && member.linkAccountOwnerId && ownerId !== memberId) {
-        this.i18nService.translate('errors.linkedSavingsAccountOwnership').subscribe((msg: string) => {
-          this.notify({ defaultUserMessage: msg, errors: [] }, { memberId });
-        });
-        return;
-      }
-      // Validate GSIM membership
-      if (!gsimMemberIds.has(memberId)) {
-        this.i18nService.translate('errors.clientNotInGSIM', { id: memberId }).subscribe((msg: string) => {
-          this.notify({ defaultUserMessage: msg, errors: [] }, { memberId });
-        });
-        return;
-      }
-    }
-
-    // Use date format from settingsService for interestChargedFromDate
-    const data = this.buildRequestData();
-    this.loansService.createGlimAccount(data).subscribe((response: any) => {
-      const body = JSON.parse(response[0].body);
-      if (body.glimId) {
-        this.router.navigate(
-          [
-            '../',
-            body.glimId
-          ],
-          { relativeTo: this.route }
-        );
-      } else {
-        this.notify(body, { batchSize: data.length });
-      }
-    });
-  }
-
-  notify(body: any, context?: { [k: string]: unknown }) {
-    const parts: string[] = [String(body?.defaultUserMessage ?? '')];
-    if (Array.isArray(body?.errors)) {
-      for (const e of body.errors) parts.push(String(e?.developerMessage ?? ''));
-    }
-    if (context) parts.push(`Context: ${JSON.stringify(context)}`);
-    console.error(parts.join(' ').trim());
+  notify(body: any, data: any) {
+    let message = body.defaultUserMessage + ' ';
+    body.errors?.forEach((error: any) => (message += error.developerMessage + ' '));
+    message += 'Data: ' + JSON.stringify(data);
+    console.error(message);
   }
 }

src/app/loans/loans-account-stepper/loans-account-charges-step/loans-account-charges-step.component.html

@@ -26,7 +26,7 @@
     <ng-container matColumnDef="name">
       <th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.name' | translate }}</th>
       <td mat-cell *matCellDef="let charge">
-        {{ charge.name + ', ' + (charge.currency?.displaySymbol || '') }}
+        {{ charge.name }}<span *ngIf="charge.currency">, {{ charge.currency.displaySymbol }}</span>
       </td>
     </ng-container>
 
@@ -41,7 +41,13 @@
       <th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Amount' | translate }}</th>
       <td mat-cell *matCellDef="let charge">
         {{ charge.amount }}
-        <button mat-icon-button color="primary" (click)="editChargeAmount(charge)">
+        <button
+          mat-icon-button
+          color="primary"
+          (click)="editChargeAmount(charge)"
+          type="button"
+          aria-label="Edit charge amount"
+        >
           <fa-icon icon="pen"></fa-icon>
         </button>
       </td>
@@ -94,7 +100,7 @@
     <ng-container matColumnDef="action">
       <th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Actions' | translate }}</th>
       <td mat-cell *matCellDef="let charge">
-        <button mat-icon-button color="warn" (click)="deleteCharge(charge)">
+        <button mat-icon-button color="warn" (click)="deleteCharge(charge)" type="button" aria-label="Delete charge">
           <fa-icon icon="trash"></fa-icon>
         </button>
       </td>
@@ -111,7 +117,9 @@ <h4 class="mat-h4 flex-98">{{ 'labels.heading.Overdue Charges' | translate }}</h
   <table mat-table class="mat-elevation-z1" [dataSource]="overDueChargesDataSource">
     <ng-container matColumnDef="name">
       <th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.name' | translate }}</th>
-      <td mat-cell *matCellDef="let charge">{{ charge.name + ', ' + (charge.currency?.displaySymbol || '') }}</td>
+      <td mat-cell *matCellDef="let charge">
+        {{ charge.name }}<span *ngIf="charge.currency">, {{ charge.currency.displaySymbol }}</span>
+      </td>
     </ng-container>
 
     <ng-container matColumnDef="type">
@@ -121,7 +129,18 @@ <h4 class="mat-h4 flex-98">{{ 'labels.heading.Overdue Charges' | translate }}</h
 
     <ng-container matColumnDef="amount">
       <th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Amount' | translate }}</th>
-      <td mat-cell *matCellDef="let charge">{{ charge.amount | formatNumber }}</td>
+      <td mat-cell *matCellDef="let charge">
+        {{ charge.amount | formatNumber }}
+        <button
+          mat-icon-button
+          color="primary"
+          (click)="editOverdueChargeAmount(charge)"
+          type="button"
+          aria-label="Edit overdue charge amount"
+        >
+          <fa-icon icon="pen"></fa-icon>
+        </button>
+      </td>
     </ng-container>
 
     <ng-container matColumnDef="collectedon">
@@ -135,17 +154,23 @@ <h4 class="mat-h4 flex-98">{{ 'labels.heading.Overdue Charges' | translate }}</h
 </div>
 
 <div class="layout-row responsive-column align-center gap-2px margin-t">
-  <button mat-raised-button matStepperPrevious>
+  <button mat-raised-button matStepperPrevious type="button">
     <fa-icon icon="arrow-left" class="m-r-10"></fa-icon>
     {{ 'labels.buttons.Previous' | translate }}
   </button>
-  <button mat-raised-button matStepperNext>
+  <button mat-raised-button matStepperNext type="button">
     {{ 'labels.buttons.Next' | translate }}
     <fa-icon icon="arrow-right" class="m-l-10"></fa-icon>
   </button>
+  <<<<<<< HEAD
   @if (loanId) {
     <button mat-raised-button [routerLink]="['../', 'general']">
       {{ 'labels.buttons.Cancel' | translate }}
     </button>
   }
+  =======
+  <button mat-raised-button *ngIf="loanId" [routerLink]="['../', 'general']" type="button">
+    {{ 'labels.buttons.Cancel' | translate }}
+  </button>
+  >>>>>>> 140a28dfb (WEB-95: Apply cherry-picked changes)
 </div>

src/app/loans/loans-account-stepper/loans-account-charges-step/loans-account-charges-step.component.ts

@@ -323,6 +323,32 @@ export class LoansAccountChargesStepComponent implements OnInit, OnChanges {
     });
   }
 
+  editOverdueChargeAmount(charge: { amount: number; [key: string]: any }) {
+    const formfields: FormfieldBase[] = [
+      new InputBase({
+        controlName: 'amount',
+        label: 'Amount',
+        value: charge.amount,
+        type: 'number',
+        required: false
+      })
+    ];
+    const data = {
+      title: 'Edit Overdue Charge Amount',
+      layout: { addButtonText: 'Confirm' },
+      formfields: formfields
+    };
+    const editNoteDialogRef = this.dialog.open(FormDialogComponent, { data });
+    editNoteDialogRef.afterClosed().subscribe((response?: { data?: { value: { amount: number } } }) => {
+      if (response?.data) {
+        const newCharge = { ...charge, amount: response.data.value.amount };
+        this.overDueChargesDataSource.splice(this.overDueChargesDataSource.indexOf(charge), 1, newCharge);
+        this.overDueChargesDataSource = this.overDueChargesDataSource.concat([]);
+        this.pristine = false;
+      }
+    });
+  }
+
   get isValid() {
     return true;
     // !this.activeClientMembers ||

src/app/loans/loans-account-stepper/loans-account-preview-step/loans-account-preview-step.component.html

@@ -332,10 +332,10 @@ <h3 class="mat-h3 flex-fill">{{ 'labels.heading.Charges' | translate }}</h3>
             }
             @if (
               !(
-                charge.chargeTimeType.value === 'Monthly Fee' ||
-                charge.chargeTimeType.value === 'Annual Fee' ||
-                charge.chargeTimeType.value === 'Specified due date' ||
-                charge.chargeTimeType.value === 'Weekly Fee'
+                charge.chargeTimeType?.value === 'Monthly Fee' ||
+                charge.chargeTimeType?.value === 'Annual Fee' ||
+                charge.chargeTimeType?.value === 'Specified due date' ||
+                charge.chargeTimeType?.value === 'Weekly Fee'
               )
             ) {
               <span>