Skip to content

Commit f429e99

Browse files
authored
Merge pull request #2543 from steinwinde/product-fixes
fix: Fixes many smaller layout issues in the read-only product views
2 parents 9c2f005 + 9ba1b72 commit f429e99

File tree

7 files changed

+503
-468
lines changed

7 files changed

+503
-468
lines changed

src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.html

Lines changed: 261 additions & 232 deletions
Large diffs are not rendered by default.

src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
@use 'assets/styles/helper';
12
@use 'assets/styles/colours' as *;
23

34
.tab-container {

src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@ import {
1919
import { LoanProducts } from '../../loan-products';
2020
import { CodeName, OptionData, StringEnumOptionData } from '../../../../shared/models/option-data.model';
2121
import { Accounting } from 'app/core/utils/accounting';
22-
import { NgIf, NgFor, DecimalPipe } from '@angular/common';
22+
import { DecimalPipe } from '@angular/common';
2323
import { MatDivider } from '@angular/material/divider';
24-
import { LongTextComponent } from '../../../../shared/long-text/long-text.component';
2524
import {
2625
MatTable,
2726
MatColumnDef,
@@ -50,7 +49,6 @@ import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module';
5049
imports: [
5150
...STANDALONE_SHARED_IMPORTS,
5251
MatDivider,
53-
LongTextComponent,
5452
MatTable,
5553
MatColumnDef,
5654
MatHeaderCellDef,

src/app/products/loan-products/loan-product-stepper/loan-product-accounting-step/loan-product-accounting-step.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ <h4 class="mat-h4 flex-33">
515515
</div>
516516
</div>
517517

518-
<div class="layout-row align-center margin-t responsive-column">
518+
<div class="layout-row align-center margin-t responsive-column gap-2percent">
519519
<button mat-raised-button matStepperPrevious>
520520
<fa-icon icon="arrow-left" class="m-r-10"></fa-icon>
521521
{{ 'labels.buttons.Previous' | translate }}

src/app/products/saving-products/view-saving-product/saving-product-general-tab/saving-product-general-tab.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
</button>
1111
</div>
1212

13-
<div class="tab-container mat-typography">
13+
<div class="tab-container">
1414
<div class="responsive-column">
15-
<h2 class="mat-h2 flex-fill">{{ savingProduct.name }}</h2>
15+
<h2 class="mat-h2 flex-100">{{ savingProduct.name }}</h2>
1616

1717
<mat-divider [inset]="true"></mat-divider>
1818

src/app/products/share-products/share-product-stepper/share-product-preview-step/share-product-preview-step.component.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@use 'assets/styles/colours' as *;
2+
13
table {
24
width: 100%;
35
}
@@ -24,3 +26,9 @@ mat-divider {
2426
.margin-t {
2527
margin-top: 1em;
2628
}
29+
30+
.mat-h3 {
31+
margin-top: 10px !important;
32+
font-weight: 300;
33+
color: $status-approved;
34+
}

0 commit comments

Comments
 (0)