bug-fix: in avoiding infinite recursion, it is whether we've seen "self" and the "property" before that matters, not whether we've seen the value before.

Author: apdavison

pipeline/src/base.py

@@ -172,8 +172,8 @@ def _validate(self, ignore=None, seen=None):
         failures = defaultdict(list)
         for property in self.properties:
             value = getattr(self, property.name, None)
-            if id(value) not in seen:
-                seen.add(id(value))
+            if (id(self), property.name) not in seen:
+                seen.add((id(self), property.name))
                 for key, values in property.validate(value, ignore=ignore, seen=seen).items():
                     failures[key] += values
         return failures