WIP: Testing

Author: franzpoeschel

CMakeLists.txt

@@ -804,6 +804,7 @@ if(openPMD_BUILD_TESTING)
                 test/Files_SerialIO/close_and_reopen_test.cpp
                 test/Files_SerialIO/filebased_write_test.cpp
                 test/Files_SerialIO/issue_1744_unique_ptrs_at_close_time.cpp
+                test/Files_SerialIO/components_without_extent.cpp
             )
         elseif(${test_name} STREQUAL "ParallelIO" AND openPMD_HAVE_MPI)
             list(APPEND ${out_list}

src/RecordComponent.cpp

@@ -216,8 +216,9 @@ RecordComponent &RecordComponent::resetDataset(Dataset d)
         rc.m_hasBeenExtended = true;
     }
 
-    if (d.extent.empty())
-        throw std::runtime_error("Dataset extent must be at least 1D.");
+    // @todo check this while flushing
+    // if (d.extent.empty())
+    //     throw std::runtime_error("Dataset extent must be at least 1D.");
     if (d.empty())
     {
         if (d.extent.empty())

test/Files_SerialIO/SerialIOTests.hpp

@@ -12,3 +12,7 @@ namespace issue_1744_unique_ptrs_at_close_time
 {
 auto issue_1744_unique_ptrs_at_close_time() -> void;
 }
+namespace components_without_extent
+{
+auto components_without_extent() -> void;
+}

test/Files_SerialIO/components_without_extent.cpp

@@ -0,0 +1,48 @@
+#include "SerialIOTests.hpp"
+
+#include "openPMD/openPMD.hpp"
+
+#include <catch2/catch.hpp>
+
+#include <memory>
+#include <numeric>
+
+namespace components_without_extent
+{
+auto components_without_extent() -> void
+{
+    auto filepath = "../samples/components_without_extent.bp5";
+    // write
+    {
+        openPMD::Series write(filepath, openPMD::Access::CREATE);
+        auto it0 = write.writeIterations()[0];
+        auto e = it0.particles["e"];
+        for (auto comp_id : {"x", "y", "z"})
+        {
+            auto position_comp = e["position"][comp_id];
+            position_comp.resetDataset({openPMD::Datatype::FLOAT, {5}});
+            std::unique_ptr<float[]> data{new float[5]};
+            std::iota(data.get(), data.get() + 5, 0);
+            position_comp.storeChunk(std::move(data), {0}, {5});
+
+            auto offset_comp = e["positionOffset"][comp_id];
+            offset_comp.resetDataset({openPMD::Datatype::INT, {}});
+            offset_comp.makeConstant(0);
+        }
+        write.close();
+    }
+
+    // read
+    {
+        openPMD::Series read(filepath, openPMD::Access::READ_RANDOM_ACCESS);
+        auto e = read.snapshots()[0].particles["e"];
+        for (auto const &record : e)
+        {
+            for (auto const &component : record.second)
+            {
+                REQUIRE(component.second.getExtent() == openPMD::Extent{5});
+            }
+        }
+    }
+}
+} // namespace components_without_extent

test/SerialIOTest.cpp

@@ -768,6 +768,11 @@ TEST_CASE("issue_1744_unique_ptrs_at_close_time", "[serial]")
 #endif
 }
 
+TEST_CASE("components_without_extent", "[serial]")
+{
+    components_without_extent::components_without_extent();
+}
+
 #if openPMD_HAVE_ADIOS2
 TEST_CASE("close_and_reopen_test", "[serial]")
 {