pythongh-90949: Fix an "unused function" compiler warning introduced in pythonGH-139234 (python#139558)

hartwork · danigm · commit 1aead6be8445 · 2025-10-07T08:10:06.000+02:00
Fix a compiler warning `-Wunused-function` after f04bea4. The `set_invalid_arg` function in `Modules/pyexpat.c` may be unused if the underlying Expat version is less than 2.4.0.
diff --git a/Modules/pyexpat.c b/Modules/pyexpat.c
@@ -198,12 +198,14 @@ set_error(pyexpat_state *state, xmlparseobject *self, enum XML_Error code)
     return NULL;
 }
 
+#if XML_COMBINED_VERSION >= 20400
 static PyObject *
 set_invalid_arg(pyexpat_state *state, xmlparseobject *self, const char *errmsg)
 {
     SET_XML_ERROR(state, self, XML_ERROR_INVALID_ARGUMENT, errmsg);
     return NULL;
 }
+#endif
 
 #undef SET_XML_ERROR
 

Original file line number	Diff line number	Diff line change
`@@ -198,12 +198,14 @@ set_error(pyexpat_state state, xmlparseobject self, enum XML_Error code)`
`198`	`198`	`return NULL;`
`199`	`199`	`}`
`200`	`200`
	`201`	`+#if XML_COMBINED_VERSION >= 20400`
`201`	`202`	`static PyObject *`
`202`	`203`	`set_invalid_arg(pyexpat_state state, xmlparseobject self, const char *errmsg)`
`203`	`204`	`{`
`204`	`205`	`SET_XML_ERROR(state, self, XML_ERROR_INVALID_ARGUMENT, errmsg);`
`205`	`206`	`return NULL;`
`206`	`207`	`}`
	`208`	`+#endif`
`207`	`209`
`208`	`210`	`#undef SET_XML_ERROR`
`209`	`211`