Skip to content

Commit 0bb2f49

Browse files
committed
Check for None & len() of ET.Element instead of bool()
The bool() of ET.Element is discouraged from being used, see: python/cpython#83122
1 parent d8bfd45 commit 0bb2f49

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

osc/_private/package.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ def _get_meta_node(self):
6666
raise NotImplementedError()
6767

6868
def get_meta_value(self, option):
69-
if not self._meta_node:
69+
if self._meta_node is None or len(self._meta_node) == 0:
7070
self._meta_node = self._get_meta_node()
71-
if not self._meta_node:
71+
if self._meta_node is None or len(self._meta_node) == 0:
7272
return None
7373
node = api.find_node(self._meta_node, "package", option)
7474
if node is None or not node.text:

0 commit comments

Comments
 (0)