feat: Deactivate feed on 410 Gone

When a feed returns a 410 Gone status, it is now marked as
inactive. If the `--save-config` option is used, this change is
persisted to the configuration file.

Add also test for deactivating feed on 410 Gone.

This commit adds a test case to verify that a feed is deactivated
and the configuration is updated when a 410 Gone status is
received and the `--save-config` option is used.

This addresses the TODO in `rss2email/feed.py` to save the
inactive status of a feed.

Author: mcepl

rss2email/feed.py

@@ -431,7 +431,8 @@ def _check_for_errors(self, parsed, save_config=False):
             _LOG.warning('deactivate {} because {} is gone'.format(
                     self.name, self.url))
             self.active = False
-            # TODO: `active` is not saved -- add config option to call feeds.save_config() in run command
+            if save_config:
+                self.save_to_config()
             return
         elif status >= 400:
             raise _error.HTTPError(status=status, feed=self)

test/test.py

@@ -435,25 +435,25 @@ def test_cache_control(self):
 
         queue.put("stop")
 
-    def test_redirect(self):
-        "Saves feed URL on redirect"
+    def test_deactivate_on_410(self):
+        "Deactivates feed on 410 Gone"
         cfg = """[DEFAULT]
         to = [email protected]"""
 
         queue = multiprocessing.Queue()
-        webserver_proc = multiprocessing.Process(target=webserver_for_test_redirect, args=(queue, 301))
+        webserver_proc = multiprocessing.Process(target=webserver_for_test_redirect, args=(queue, 410))
         webserver_proc.start()
         port = queue.get()
 
         with ExecContext(cfg) as ctx:
-            ctx.call("add", 'test', 'http://127.0.0.1:{port}/redirect'.format(port = port))
+            ctx.call("add", 'test', 'http://127.0.0.1:{port}/gone'.format(port = port))
 
             queue.put("next")
             ctx.call("run", "--no-send", "--save-config")
 
             with open(ctx.cfg_path, 'r') as f:
                 config = f.read()
-                self.assertIn("url = http://127.0.0.1:{port}/disqus/feed.rss".format(port=port), config)
+                self.assertIn("active = False", config)
 
         queue.put("stop")