refactor: migrate all test files from REXML to Nokogiri

Replace REXML::Document, REXML::Attribute, and REXML::Element with
Nokogiri equivalents across 9 test files (75 usages total).

Production code still uses REXML — this commit allows the test suite
to validate the Nokogiri API translations against the existing
REXML-based production behavior before production code is migrated.

Author: danidoni

src/api/test/functional/channel_maintenance_test.rb

@@ -132,8 +132,8 @@ def test_large_channel_test
 
     get "/request/#{id1}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    incident_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    incident_project = data.at_xpath('/request/action/target')['project'].to_s
     assert_not_equal incident_project, 'My:Maintenance'
 
     # test build and publish flags
@@ -243,8 +243,8 @@ def test_large_channel_test
 
     get "/request/#{id2}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    maintenance_not_new_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    maintenance_not_new_project = data.at_xpath('/request/action/target')['project'].to_s
     assert_equal incident_project, maintenance_not_new_project
 
     # try to do it again
@@ -260,8 +260,8 @@ def test_large_channel_test
 
     get "/request/#{id2}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    maintenance_not_new_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    maintenance_not_new_project = data.at_xpath('/request/action/target')['project'].to_s
     assert_equal incident_project, maintenance_not_new_project
 
     # validate releasename
@@ -374,8 +374,8 @@ def test_large_channel_test
     assert_response :success
     get "/request/#{id3}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    maintenance_yet_another_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    maintenance_yet_another_project = data.at_xpath('/request/action/target')['project'].to_s
     # no cleanup
     get '/source/home:tom:branches:OBS_Maintained:pack2/pack2.linked.BaseDistro2.0_LinkedUpdateProject'
     assert_response :success
@@ -893,8 +893,8 @@ def test_large_channel_test
     assert_response :success
     get "/request/#{reqid2}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    ontopof_update_incident_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    ontopof_update_incident_project = data.at_xpath('/request/action/target')['project'].to_s
     get "/source/#{ontopof_update_incident_project}"
     assert_response :success
     assert_xml_tag(tag: 'entry', attributes: { name: 'pack2.BaseDistro2.0_LinkedUpdateProject' })

src/api/test/functional/kgraft_maintenance_test.rb

@@ -56,18 +56,18 @@ def test_kgraft_update_setup
     get '/source/BaseDistro2.0/_meta'
     assert_response :success
     assert_no_xml_tag tag: 'lock' # or our fixtures have changed
-    doc = REXML::Document.new(@response.body)
-    doc.elements['/project'].add_element 'lock'
-    doc.elements['/project/lock'].add_element 'enable'
-    put '/source/BaseDistro2.0/_meta', params: doc.to_s
+    doc = Nokogiri::XML(@response.body)
+    doc.at_xpath('/project').add_child(Nokogiri::XML::Node.new('lock', doc))
+    doc.at_xpath('/project/lock').add_child(Nokogiri::XML::Node.new('enable', doc))
+    put '/source/BaseDistro2.0/_meta', params: doc.root.to_xml
     assert_response :success
 
     # create maintenance incident for first kernel update
     post '/source', params: { cmd: 'createmaintenanceincident' }
     assert_response :success
     assert_xml_tag(tag: 'data', attributes: { name: 'targetproject' })
-    data = REXML::Document.new(@response.body)
-    kernel_incident_project = data.elements['/status/data'].text
+    data = Nokogiri::XML(@response.body)
+    kernel_incident_project = data.at_xpath('/status/data')&.text
     kernel_incident_id = kernel_incident_project.gsub(/^My:Maintenance:/, '')
     # submit packages via mbranch
     post '/source', params: { cmd: 'branch', package: 'pack2', target_project: kernel_incident_project, add_repositories: 1 }
@@ -170,8 +170,8 @@ def test_kgraft_update_setup
     assert_response :success
     get "/request/#{id1}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    incident_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    incident_project = data.at_xpath('/request/action/target')['project'].to_s
     incident_id = incident_project.gsub(/^My:Maintenance:/, '')
 
     # validate sources
@@ -282,10 +282,10 @@ def test_kgraft_update_setup
     get '/source/' + kernel_incident_project + '/_meta'
     assert_response :success
     assert_no_xml_tag tag: 'lock' # or our fixtures have changed
-    doc = REXML::Document.new(@response.body)
-    doc.elements['/project'].add_element 'lock'
-    doc.elements['/project/lock'].add_element 'enable'
-    put '/source/' + kernel_incident_project + '/_meta', params: doc.to_s
+    doc = Nokogiri::XML(@response.body)
+    doc.at_xpath('/project').add_child(Nokogiri::XML::Node.new('lock', doc))
+    doc.at_xpath('/project/lock').add_child(Nokogiri::XML::Node.new('enable', doc))
+    put '/source/' + kernel_incident_project + '/_meta', params: doc.root.to_xml
     assert_response :success
 
     # collect the job results

src/api/test/functional/maintenance_test.rb

@@ -249,8 +249,8 @@ def test_maintenance_request_from_foreign_and_remote_project
 
     get "/request/#{id1}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    incident_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    incident_project = data.at_xpath('/request/action/target')['project'].to_s
 
     get "/source/#{incident_project}/kdelibs.BaseDistro2.0_LinkedUpdateProject"
     assert_response :success
@@ -322,8 +322,8 @@ def test_maintenance_request_from_foreign_and_remote_project
 
     get "/request/#{id2}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    incident_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    incident_project = data.at_xpath('/request/action/target')['project'].to_s
 
     get "/source/#{incident_project}/kdelibs.BaseDistro2.0_LinkedUpdateProject"
     assert_response :success
@@ -460,8 +460,8 @@ def test_instantiate_new_package_with_local_link_in_service_pack
     post '/source', params: { cmd: 'createmaintenanceincident', noaccess: 1 }
     assert_response :success
     assert_xml_tag(tag: 'data', attributes: { name: 'targetproject' })
-    data = REXML::Document.new(@response.body)
-    incident_project = data.elements['/status/data'].text
+    data = Nokogiri::XML(@response.body)
+    incident_project = data.at_xpath('/status/data')&.text
     assert_equal 'My:Maintenance:100', incident_project
 
     get '/source/ServicePack:Update/pack2/_meta'
@@ -757,8 +757,8 @@ def test_mbranch_and_maintenance_entire_project_request
 
     get "/request/#{id}"
     assert_response :success
-    data = REXML::Document.new(@response.body)
-    incident_project = data.elements['/request/action/target'].attributes.get_attribute('project').to_s
+    data = Nokogiri::XML(@response.body)
+    incident_project = data.at_xpath('/request/action/target')['project'].to_s
     assert_not_equal incident_project, 'My:Maintenance'
 
     # validate cleanup
@@ -842,8 +842,8 @@ def test_create_maintenance_incident
     post '/source/Temp:Maintenance', params: { cmd: 'createmaintenanceincident' }
     assert_response :success
     assert_xml_tag(tag: 'data', attributes: { name: 'targetproject' })
-    data = REXML::Document.new(@response.body)
-    incident_project = data.elements['/status/data'].text
+    data = Nokogiri::XML(@response.body)
+    incident_project = data.at_xpath('/status/data')&.text
     # incident_id=incident_project.gsub( /^Temp:Maintenance:/, "" )
     get "/source/#{incident_project}/_meta"
     assert_xml_tag(tag: 'project', attributes: { kind: 'maintenance_incident' })
@@ -856,8 +856,8 @@ def test_create_maintenance_incident
     post '/source/Temp:Maintenance?cmd=createmaintenanceincident&noaccess=1'
     assert_response :success
     assert_xml_tag(tag: 'data', attributes: { name: 'targetproject' })
-    data = REXML::Document.new(@response.body)
-    incident_project2 = data.elements['/status/data'].text
+    data = Nokogiri::XML(@response.body)
+    incident_project2 = data.at_xpath('/status/data')&.text
     # incident_id2=incident_project2.gsub( /^Temp:Maintenance:/, "" )
     get "/source/#{incident_project2}/_meta"
     assert_xml_tag(parent: { tag: 'build' }, tag: 'disable', content: nil)
@@ -928,9 +928,9 @@ def test_create_maintenance_project_and_release_packages
     login_king
     get '/source/My:Maintenance/_meta'
     assert_response :success
-    maintenance_project_meta = REXML::Document.new(@response.body)
-    maintenance_project_meta.elements['/project'].attributes['kind'] = 'maintenance'
-    put '/source/My:Maintenance/_meta', params: maintenance_project_meta.to_s
+    maintenance_project_meta = Nokogiri::XML(@response.body)
+    maintenance_project_meta.at_xpath('/project')['kind'] = 'maintenance'
+    put '/source/My:Maintenance/_meta', params: maintenance_project_meta.root.to_xml
     assert_response :success
 
     prepare_request_with_user('maintenance_coord', 'buildservice')
@@ -959,8 +959,8 @@ def test_create_maintenance_project_and_release_packages
     post '/source', params: { cmd: 'createmaintenanceincident', noaccess: 1 }
     assert_response :success
     assert_xml_tag(tag: 'data', attributes: { name: 'targetproject' })
-    data = REXML::Document.new(@response.body)
-    incident_project = data.elements['/status/data'].text
+    data = Nokogiri::XML(@response.body)
+    incident_project = data.at_xpath('/status/data')&.text
     incident_id = incident_project.gsub(/^My:Maintenance:/, '')
     get "/source/#{incident_project}/_meta"
     assert_response :success
@@ -1251,9 +1251,9 @@ def test_create_maintenance_project_and_release_packages
     # let's say the maintenance person wants to publish it now
     get "/source/#{incident_project}/_meta"
     assert_response :success
-    maintenance_project_meta = REXML::Document.new(@response.body)
-    maintenance_project_meta.elements['/project'].delete_element 'publish'
-    put "/source/#{incident_project}/_meta", params: maintenance_project_meta.to_s
+    maintenance_project_meta = Nokogiri::XML(@response.body)
+    maintenance_project_meta.at_xpath('/project/publish')&.remove
+    put "/source/#{incident_project}/_meta", params: maintenance_project_meta.root.to_xml
     assert_response :success
 
     # mess up patchinfo and try to create release request
@@ -1587,9 +1587,9 @@ def test_create_maintenance_project_and_release_packages
     assert_xml_tag tag: 'mtime'
     hashed = node = nil
     IO.popen("gunzip -cd #{ENV.fetch('OBS_BACKEND_TEMP', nil)}/data/repos/BaseDistro2.0:/LinkedUpdateProject/BaseDistro2LinkedUpdateProject_repo/repodata/*-updateinfo.xml.gz") do |io|
-      node = REXML::Document.new(io.read)
+      node = Nokogiri::XML(io.read)
     end
-    assert_equal "My-oldname-#{Time.now.year}-1", node.elements['/updates/update/id'].first.to_s
+    assert_equal "My-oldname-#{Time.now.year}-1", node.at_xpath('/updates/update/id')&.text
     # verify meta data created by createrepo
     IO.popen("gunzip -cd #{ENV.fetch('OBS_BACKEND_TEMP', nil)}/data/repos/BaseDistro2.0:/LinkedUpdateProject/BaseDistro2LinkedUpdateProject_repo/repodata/*-primary.xml.gz") do |io|
       hashed = Xmlhash.parse(io.read)
@@ -1966,9 +1966,9 @@ def test_create_invalid_release_request
     # remove release target
     get '/source/home:tom:branches:BaseDistro:Update/_meta'
     assert_response :success
-    pi = REXML::Document.new(@response.body)
-    pi.elements['//repository'].delete_element 'releasetarget'
-    put '/source/home:tom:branches:BaseDistro:Update/_meta', params: pi.to_s
+    pi = Nokogiri::XML(@response.body)
+    pi.at_xpath('//repository/releasetarget')&.remove
+    put '/source/home:tom:branches:BaseDistro:Update/_meta', params: pi.root.to_xml
     assert_response :success
 
     # Run without server side expansion
@@ -2003,11 +2003,12 @@ def test_create_invalid_release_request
     login_tom
     get '/source/home:tom:branches:BaseDistro:Update/_meta'
     assert_response :success
-    meta = REXML::Document.new(@response.body)
-    meta.elements['//repository'].add_element 'releasetarget'
-    meta.elements['//releasetarget'].add_attribute(REXML::Attribute.new('project', 'BaseDistro:Update'))
-    meta.elements['//releasetarget'].add_attribute(REXML::Attribute.new('repository', 'BaseDistroUpdateProject_repo'))
-    put '/source/home:tom:branches:BaseDistro:Update/_meta', params: meta.to_s
+    meta = Nokogiri::XML(@response.body)
+    releasetarget = Nokogiri::XML::Node.new('releasetarget', meta)
+    releasetarget['project'] = 'BaseDistro:Update'
+    releasetarget['repository'] = 'BaseDistroUpdateProject_repo'
+    meta.at_xpath('//repository').add_child(releasetarget)
+    put '/source/home:tom:branches:BaseDistro:Update/_meta', params: meta.root.to_xml
     assert_response :success
 
     # retry
@@ -2044,14 +2045,14 @@ def test_create_invalid_release_request
     login_tom
     get '/source/home:tom:branches:BaseDistro:Update/patchinfo/_patchinfo'
     assert_response :success
-    pi = REXML::Document.new(@response.body)
-    pi.elements['//summary'].text = 'My Summary'
-    put '/source/home:tom:branches:BaseDistro:Update/patchinfo/_patchinfo', params: pi.to_s
+    pi = Nokogiri::XML(@response.body)
+    pi.at_xpath('//summary').content = 'My Summary'
+    put '/source/home:tom:branches:BaseDistro:Update/patchinfo/_patchinfo', params: pi.root.to_xml
     assert_response :success
 
     # remove architecture
-    meta.elements['//repository'].delete_element 'arch'
-    put '/source/home:tom:branches:BaseDistro:Update/_meta', params: meta.to_s
+    meta.at_xpath('//repository/arch')&.remove
+    put '/source/home:tom:branches:BaseDistro:Update/_meta', params: meta.root.to_xml
     assert_response :success
 
     rq = '<request>

src/api/test/functional/person_controller_test.rb

@@ -215,16 +215,17 @@ def test_update_user_info
     # change the xml data set that came as response body
     new_name = 'Thommy Cool'
     userinfo_xml = @response.body
-    doc = REXML::Document.new(userinfo_xml)
-    doc.elements['//realname'].text = new_name
-    doc.elements['//watchlist'].add_element 'project'
-    doc.elements['//project'].add_attribute(REXML::Attribute.new('name', 'home:tom'))
-    r = REXML::Element.new('globalrole')
-    r.text = 'Admin'
-    doc.elements['/person'].insert_after(doc.elements['//state'], r)
+    doc = Nokogiri::XML(userinfo_xml)
+    doc.at_xpath('//realname').content = new_name
+    project_node = Nokogiri::XML::Node.new('project', doc)
+    project_node['name'] = 'home:tom'
+    doc.at_xpath('//watchlist').add_child(project_node)
+    r = Nokogiri::XML::Node.new('globalrole', doc)
+    r.content = 'Admin'
+    doc.at_xpath('//state').add_next_sibling(r)
     # Write changed data back and validate result
     prepare_request_valid_user
-    put '/person/tom', params: doc.to_s
+    put '/person/tom', params: doc.root.to_xml
     assert_response :success
     get '/person/tom'
     assert_response :success

src/api/test/functional/request_controller_test.rb

@@ -1403,12 +1403,13 @@ def test_release_package_via_request
     get '/source/home:Iggy/_meta'
     assert_response :success
     orig_project_meta = @response.body
-    doc = REXML::Document.new(@response.body)
-    rt = doc.elements['/project/repository'].add_element 'releasetarget'
-    rt.add_attribute(REXML::Attribute.new('project', 'home:adrian:RT'))
-    rt.add_attribute(REXML::Attribute.new('repository', 'rt'))
-    rt.add_attribute(REXML::Attribute.new('trigger', 'manual'))
-    put '/source/home:Iggy/_meta', params: doc.to_s
+    doc = Nokogiri::XML(@response.body)
+    rt = Nokogiri::XML::Node.new('releasetarget', doc)
+    rt['project'] = 'home:adrian:RT'
+    rt['repository'] = 'rt'
+    rt['trigger'] = 'manual'
+    doc.at_xpath('/project/repository').add_child(rt)
+    put '/source/home:Iggy/_meta', params: doc.root.to_xml
     assert_response :success
 
     # create request