Make the maximum request body size configurable

With Javalin, the maximum request body size is 1 MB by default.
This is quite limiting and would prevent even moderately sized plant
models from being loaded into the kernel via the web API. Therefore,
set the maximum request body size to a more reasonable 200 MB by
default, which should be more than sufficient for most use cases.

Merged-by: Stefan Walter <stefan.walter@iml.fraunhofer.de>

Author: martingr

opentcs-documentation/src/docs/release-notes/changelog.adoc

@@ -30,6 +30,7 @@ This change log lists the most relevant changes for past releases in reverse chr
 *** Add support for Server-Sent Events (SSE) to the web API.
     As an alternative to the `GET /events` endpoint, clients can use the `GET /sse` endpoint to subscribe to events that are sent by the kernel.
 *** Use Javalin instead of Spark as the framework for the web API implementation.
+    The maximum size of request bodies can now be configured via the `servicewebapi.maxRequestBodySize` configuration entry.
 * Bugs fixed:
 ** Properly allow updates of a vehicle's acceptable order types via the `PUT /vehicles/{NAME}/acceptableOrderTypes` web API endpoint.
 ** Avoid `NullPointerException` when trying to save transport order definitions in the continuous load panel.

opentcs-kernel-extension-http-services/src/main/java/org/opentcs/kernel/extensions/servicewebapi/ServiceWebApi.java

@@ -105,6 +105,15 @@ public void initialize() {
     Consumer<JavalinConfig> config = cfg -> {
       cfg.showJavalinBanner = false;
       cfg.router.apiBuilder(v1RequestHandler.createRoutes());
+      if (configuration.maxRequestBodySize() <= 0) {
+        LOG.warn(
+            "Maximum request body size must be at least 1 MB. Using default size of {} bytes.",
+            cfg.http.maxRequestSize
+        );
+      }
+      else {
+        cfg.http.maxRequestSize = configuration.maxRequestBodySize() * 1024L * 1024L;
+      }
 
       if (configuration.useSsl()) {
         cfg.registerPlugin(

opentcs-kernel-extension-http-services/src/main/java/org/opentcs/kernel/extensions/servicewebapi/ServiceWebApiConfiguration.java

@@ -63,4 +63,12 @@ public interface ServiceWebApiConfiguration {
       orderKey = "5"
   )
   boolean useSsl();
+
+  @ConfigurationEntry(
+      type = "Integer",
+      description = "The maximum size (in MB) that a request body may have for it to be processed.",
+      changesApplied = ConfigurationEntry.ChangesApplied.ON_APPLICATION_START,
+      orderKey = "6"
+  )
+  int maxRequestBodySize();
 }

opentcs-kernel/src/main/resources/org/opentcs/kernel/distribution/config/opentcs-kernel-defaults-baseline.properties

@@ -47,6 +47,7 @@ servicewebapi.bindAddress = 0.0.0.0
 servicewebapi.bindPort = 55200
 servicewebapi.accessKey =
 servicewebapi.statusEventsCapacity = 1000
+servicewebapi.maxRequestBodySize = 200
 
 defaultdispatcher.dismissUnroutableTransportOrders = true
 defaultdispatcher.assignRedundantOrders = false