Update Spotless' Eclipse formatter to 4.38

This also fixes formatting in some places that the formatter previously
didn't recognize.

Merged-by: Martin Grzenia <martin.grzenia@iml.fraunhofer.de>

Author: swltr

gradle/java-project.gradle

@@ -82,6 +82,6 @@ spotless {
     importOrder()
 
     // Use the Eclipse JDT formatter
-    eclipse('4.26').configFile("${rootDir}/config/eclipse-formatter-preferences.xml")
+    eclipse('4.38').configFile("${rootDir}/config/eclipse-formatter-preferences.xml")
   }
 }

opentcs-kernel/src/test/java/org/opentcs/kernel/vehicles/transformers/VehicleDataTransformerRegistryTest.java

@@ -71,7 +71,9 @@ void provideAcceptableFactoryForVehicle() {
   @Test
   void fallBackToDefaultFactoryForUnacceptableSelectedFactory() {
     when(dummyFactory.providesTransformersFor(vehicle)).thenReturn(false);
-    assertThat(vehicleDataTransformerRegistry.findFactoryFor(vehicle).getClass(),
-               is(DefaultVehicleDataTransformerFactory.class));
+    assertThat(
+        vehicleDataTransformerRegistry.findFactoryFor(vehicle).getClass(),
+        is(DefaultVehicleDataTransformerFactory.class)
+    );
   }
 }

opentcs-plantoverview-panel-loadgenerator/src/test/java/org/opentcs/guing/plugins/panels/loadgenerator/batchcreator/RandomOrderBatchCreatorTest.java

@@ -59,10 +59,12 @@ void givenUnsuitableTypeWithoutLinkThenCreateNoOrders() {
         .thenReturn(Set.of(unsuitableLocType));
     when(transportOrderService.fetch(Location.class))
         .thenReturn(Set.of(unsuitableLoc));
-    RandomOrderBatchCreator batchCreator = new RandomOrderBatchCreator(transportOrderService,
-                                                                       dispatcherService,
-                                                                       10,
-                                                                       3);
+    RandomOrderBatchCreator batchCreator = new RandomOrderBatchCreator(
+        transportOrderService,
+        dispatcherService,
+        10,
+        3
+    );
 
     Set<TransportOrder> result = batchCreator.createOrderBatch();
 
@@ -77,10 +79,12 @@ void givenSuitableTypeWithoutLinkThenCreateNoOrders() {
         .thenReturn(Set.of(suitableLocType));
     when(transportOrderService.fetch(Location.class))
         .thenReturn(Set.of(suitableLoc));
-    RandomOrderBatchCreator batchCreator = new RandomOrderBatchCreator(transportOrderService,
-                                                                       dispatcherService,
-                                                                       10,
-                                                                       3);
+    RandomOrderBatchCreator batchCreator = new RandomOrderBatchCreator(
+        transportOrderService,
+        dispatcherService,
+        10,
+        3
+    );
 
     Set<TransportOrder> result = batchCreator.createOrderBatch();
 

opentcs-strategies-default/src/test/java/org/opentcs/strategies/basic/dispatching/TransportOrderAssignmentCheckerTest.java

@@ -183,7 +183,9 @@ void acceptValidOrderAndVehicle() {
     when(objectService.fetch(Vehicle.class, vehicle.getReference()))
         .thenReturn(Optional.of(vehicle));
 
-    assertThat(checker.checkTransportOrderAssignment(transportOrder),
-               is(TransportOrderAssignmentVeto.NO_VETO));
+    assertThat(
+        checker.checkTransportOrderAssignment(transportOrder),
+        is(TransportOrderAssignmentVeto.NO_VETO)
+    );
   }
 }

opentcs-strategies-default/src/test/java/org/opentcs/strategies/basic/routing/edgeevaluator/EdgeEvaluatorExplicitPropertiesTest.java

@@ -60,8 +60,10 @@ void useConfiguredDefaultValue() {
     when(configuration.defaultValue()).thenReturn("123.456");
 
     Edge edge = new Edge(
-        new Path("pathName", new Point("srcPoint").getReference(),
-                 new Point("dstPoint").getReference()),
+        new Path(
+            "pathName", new Point("srcPoint").getReference(),
+            new Point("dstPoint").getReference()
+        ),
         false
     );
     Vehicle vehicle = new Vehicle("someVehicle");
@@ -79,8 +81,10 @@ void handleInvalidDefaultValue() {
     when(configuration.defaultValue()).thenReturn("some invalid value");
 
     Edge edge = new Edge(
-        new Path("pathName", new Point("srcPoint").getReference(),
-                 new Point("dstPoint").getReference()),
+        new Path(
+            "pathName", new Point("srcPoint").getReference(),
+            new Point("dstPoint").getReference()
+        ),
         false
     );
     Vehicle vehicle = new Vehicle("someVehicle");