Skip to content

Conversation

rxrw
Copy link

@rxrw rxrw commented Mar 13, 2025

What:

  • Bug Fix
  • New Feature

Description:

Add support for the reasoning_content field in chat completions API responses. This field is added at the same level as content in both streaming and non-streaming requests. The field is marked as optional to handle cases where it's not present in the API response.

Related:

#517

@iBotPeaches
Copy link
Collaborator

With the latest merges our pipeline should be runnable again. If you rebase we can see if this change will merge cleanly.

@iBotPeaches iBotPeaches marked this pull request as draft April 8, 2025 22:32
Add support for the reasoning_content field in chat completions API responses. This field is added at the same level as content in both streaming and non-streaming requests. The field is marked as optional to handle cases where it's not present in the API response.
@rxrw rxrw force-pushed the add-reasoning-content branch from 1d178e8 to 4415acd Compare April 9, 2025 01:51
@rxrw rxrw marked this pull request as ready for review April 9, 2025 01:52
@anhao
Copy link

anhao commented Jun 20, 2025

When can this PR be merged

@iBotPeaches
Copy link
Collaborator

When can this PR be merged

At the moment its decayed quite a bit with conflicts - so thats probably priority one, then a green pipeline as 2nd. Since its a non-OpenAI change as well it may take some thinking as this property then becomes exposed to all OpenAI implementations without careful filtering logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants