comment

Author: charley-oai

codex-rs/core/src/codex.rs

@@ -4398,16 +4398,17 @@ async fn run_pre_sampling_compact(
     {
         Ok(previous_turn_context) => previous_turn_context,
         Err(err) => {
+            // If pre-turn model-switch compaction fails, we just emit <model_switch>
+            // because on the next turn previous_model will equal current_model.
+            // This is a bit sad, might be better to revert the user to the previous model
+            // (with a warning) and avoid emitting <model_switch> at all.
             if let Some(model_switch_item) = sess.build_model_instructions_update_item(
                 None,
                 previous_model.as_deref(),
                 turn_context.as_ref(),
             ) {
                 sess.record_conversation_items(turn_context.as_ref(), &[model_switch_item])
                     .await;
-                // TODO(charley): This is a big sad fallback. If pre-turn model-switch compaction
-                // fails, a better behavior may be to revert the user to the previous model and
-                // avoid emitting <model_switch> at all.
             }
             return Err(err);
         }