Skip to content

Commit a05aadf

Browse files
chore(config) Default Personality Pragmatic (#10705)
## Summary Switch back to Pragmatic personality ## Testing - [x] Updated unit tests
1 parent 1dc06b6 commit a05aadf

File tree

5 files changed

+16
-16
lines changed

5 files changed

+16
-16
lines changed

codex-rs/app-server/tests/suite/v2/thread_resume.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ async fn thread_resume_accepts_personality_override() -> Result<()> {
403403
.send_thread_resume_request(ThreadResumeParams {
404404
thread_id: thread.id.clone(),
405405
model: Some("gpt-5.2-codex".to_string()),
406-
personality: Some(Personality::Pragmatic),
406+
personality: Some(Personality::Friendly),
407407
..Default::default()
408408
})
409409
.await?;

codex-rs/app-server/tests/suite/v2/turn_start.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ async fn turn_start_accepts_personality_override_v2() -> Result<()> {
455455
text: "Hello".to_string(),
456456
text_elements: Vec::new(),
457457
}],
458-
personality: Some(Personality::Pragmatic),
458+
personality: Some(Personality::Friendly),
459459
..Default::default()
460460
})
461461
.await?;
@@ -560,7 +560,7 @@ async fn turn_start_change_personality_mid_thread_v2() -> Result<()> {
560560
text: "Hello again".to_string(),
561561
text_elements: Vec::new(),
562562
}],
563-
personality: Some(Personality::Pragmatic),
563+
personality: Some(Personality::Friendly),
564564
..Default::default()
565565
})
566566
.await?;

codex-rs/core/src/config/mod.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1550,7 +1550,7 @@ impl Config {
15501550
.or_else(|| {
15511551
features
15521552
.enabled(Feature::Personality)
1553-
.then_some(Personality::Friendly)
1553+
.then_some(Personality::Pragmatic)
15541554
});
15551555

15561556
let experimental_compact_prompt_path = config_profile
@@ -3870,7 +3870,7 @@ model_verbosity = "high"
38703870
model_reasoning_summary: ReasoningSummary::Detailed,
38713871
model_supports_reasoning_summaries: None,
38723872
model_verbosity: None,
3873-
personality: Some(Personality::Friendly),
3873+
personality: Some(Personality::Pragmatic),
38743874
chatgpt_base_url: "https://chatgpt.com/backend-api/".to_string(),
38753875
base_instructions: None,
38763876
developer_instructions: None,
@@ -3956,7 +3956,7 @@ model_verbosity = "high"
39563956
model_reasoning_summary: ReasoningSummary::default(),
39573957
model_supports_reasoning_summaries: None,
39583958
model_verbosity: None,
3959-
personality: Some(Personality::Friendly),
3959+
personality: Some(Personality::Pragmatic),
39603960
chatgpt_base_url: "https://chatgpt.com/backend-api/".to_string(),
39613961
base_instructions: None,
39623962
developer_instructions: None,
@@ -4057,7 +4057,7 @@ model_verbosity = "high"
40574057
model_reasoning_summary: ReasoningSummary::default(),
40584058
model_supports_reasoning_summaries: None,
40594059
model_verbosity: None,
4060-
personality: Some(Personality::Friendly),
4060+
personality: Some(Personality::Pragmatic),
40614061
chatgpt_base_url: "https://chatgpt.com/backend-api/".to_string(),
40624062
base_instructions: None,
40634063
developer_instructions: None,
@@ -4144,7 +4144,7 @@ model_verbosity = "high"
41444144
model_reasoning_summary: ReasoningSummary::Detailed,
41454145
model_supports_reasoning_summaries: None,
41464146
model_verbosity: Some(Verbosity::High),
4147-
personality: Some(Personality::Friendly),
4147+
personality: Some(Personality::Pragmatic),
41484148
chatgpt_base_url: "https://chatgpt.com/backend-api/".to_string(),
41494149
base_instructions: None,
41504150
developer_instructions: None,

codex-rs/core/tests/suite/personality.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ async fn config_personality_none_sends_no_personality() -> anyhow::Result<()> {
233233
}
234234

235235
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
236-
async fn default_personality_is_friendly_without_config_toml() -> anyhow::Result<()> {
236+
async fn default_personality_is_pragmatic_without_config_toml() -> anyhow::Result<()> {
237237
skip_if_no_network!(Ok(()));
238238

239239
let server = start_mock_server().await;
@@ -269,7 +269,7 @@ async fn default_personality_is_friendly_without_config_toml() -> anyhow::Result
269269
let request = resp_mock.single_request();
270270
let instructions_text = request.instructions_text();
271271
assert!(
272-
instructions_text.contains(LOCAL_FRIENDLY_TEMPLATE),
272+
instructions_text.contains(LOCAL_PRAGMATIC_TEMPLATE),
273273
"expected default friendly template, got: {instructions_text:?}"
274274
);
275275

@@ -324,7 +324,7 @@ async fn user_turn_personality_some_adds_update_message() -> anyhow::Result<()>
324324
effort: None,
325325
summary: None,
326326
collaboration_mode: None,
327-
personality: Some(Personality::Pragmatic),
327+
personality: Some(Personality::Friendly),
328328
})
329329
.await?;
330330

@@ -365,7 +365,7 @@ async fn user_turn_personality_some_adds_update_message() -> anyhow::Result<()>
365365
"expected personality update preamble, got {personality_text:?}"
366366
);
367367
assert!(
368-
personality_text.contains(LOCAL_PRAGMATIC_TEMPLATE),
368+
personality_text.contains(LOCAL_FRIENDLY_TEMPLATE),
369369
"expected personality update to include the local pragmatic template, got: {personality_text:?}"
370370
);
371371

@@ -902,7 +902,7 @@ async fn user_turn_personality_remote_model_template_includes_update_message() -
902902
effort: None,
903903
summary: None,
904904
collaboration_mode: None,
905-
personality: Some(Personality::Pragmatic),
905+
personality: Some(Personality::Friendly),
906906
})
907907
.await?;
908908

@@ -942,7 +942,7 @@ async fn user_turn_personality_remote_model_template_includes_update_message() -
942942
"expected personality update preamble, got {personality_text:?}"
943943
);
944944
assert!(
945-
personality_text.contains(remote_pragmatic_message),
945+
personality_text.contains(remote_friendly_message),
946946
"expected personality update to include remote template, got: {personality_text:?}"
947947
);
948948

codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__personality_selection_popup.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ expression: popup
55
Select Personality
66
Choose a communication style for Codex. Disable in /experimental.
77

8-
1. Friendly (current) Warm, collaborative, and helpful.
9-
2. Pragmatic Concise, task-focused, and direct.
8+
1. Friendly Warm, collaborative, and helpful.
9+
2. Pragmatic (current) Concise, task-focused, and direct.
1010

1111
Press enter to confirm or esc to go back

0 commit comments

Comments
 (0)