File tree Expand file tree Collapse file tree 2 files changed +8
-3
lines changed Expand file tree Collapse file tree 2 files changed +8
-3
lines changed Original file line number Diff line number Diff line change @@ -1586,7 +1586,7 @@ async fn spawn_review_thread(
1586
1586
1587
1587
// Seed the child task with the review prompt as the initial user message.
1588
1588
let input: Vec < InputItem > = vec ! [ InputItem :: Text {
1589
- text: format! ( "{base_instructions} \n \n --- \n \n Now, here's your task: { review_prompt}" ) ,
1589
+ text: review_prompt,
1590
1590
} ] ;
1591
1591
let tc = Arc :: new ( review_turn_context) ;
1592
1592
Original file line number Diff line number Diff line change @@ -445,7 +445,7 @@ async fn review_input_isolated_from_parent_history() {
445
445
. await ;
446
446
let _complete = wait_for_event ( & codex, |ev| matches ! ( ev, EventMsg :: TaskComplete ( _) ) ) . await ;
447
447
448
- // Assert the request `input` contains the environment context followed by the review prompt.
448
+ // Assert the request `input` contains the environment context followed by the user review prompt.
449
449
let request = & server. received_requests ( ) . await . unwrap ( ) [ 0 ] ;
450
450
let body = request. body_json :: < serde_json:: Value > ( ) . unwrap ( ) ;
451
451
let input = body[ "input" ] . as_array ( ) . expect ( "input array" ) ;
@@ -473,9 +473,14 @@ async fn review_input_isolated_from_parent_history() {
473
473
assert_eq ! ( review_msg[ "role" ] . as_str( ) . unwrap( ) , "user" ) ;
474
474
assert_eq ! (
475
475
review_msg[ "content" ] [ 0 ] [ "text" ] . as_str( ) . unwrap( ) ,
476
- format!( "{REVIEW_PROMPT}\n \n ---\n \n Now, here's your task: Please review only this" , )
476
+ review_prompt,
477
+ "user message should only contain the raw review prompt"
477
478
) ;
478
479
480
+ // Ensure the REVIEW_PROMPT rubric is sent via instructions.
481
+ let instructions = body[ "instructions" ] . as_str ( ) . expect ( "instructions string" ) ;
482
+ assert_eq ! ( instructions, REVIEW_PROMPT ) ;
483
+
479
484
// Also verify that a user interruption note was recorded in the rollout.
480
485
codex. submit ( Op :: GetPath ) . await . unwrap ( ) ;
481
486
let history_event =
You can’t perform that action at this time.
0 commit comments