Skip to content

Commit eabe187

Browse files
authored
fix: use number instead of bigint for the generated TS for RequestId (#4575)
Before this PR: ```typescript export type RequestId = string | bigint; ``` After: ```typescript export type RequestId = string | number; ``` `bigint` introduces headaches in TypeScript without providing any real value.
1 parent ceaba36 commit eabe187

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

codex-rs/app-server-protocol/src/jsonrpc_lite.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ pub const JSONRPC_VERSION: &str = "2.0";
1111
#[serde(untagged)]
1212
pub enum RequestId {
1313
String(String),
14+
#[ts(type = "number")]
1415
Integer(i64),
1516
}
1617

0 commit comments

Comments
 (0)