feat: agent controller #8783
feat: agent controller #8783
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afa4f6ff73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e071c460d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Arc::clone(&parent_session.services.skills_manager), | ||
| initial_history.unwrap_or(InitialHistory::New), | ||
| SessionSource::SubAgent(SubAgentSource::Review), | ||
| parent_session.services.agent_control.clone(), |
There was a problem hiding this comment.
we'll need to replace codex_delegate with agentcontrol
There was a problem hiding this comment.
not blocking for this pr
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
I'd prefer to move status into Conversation and not have to manage a separate Hash for them but not blocking.
|
Will do in a follow-up PR to keep things clean |
Added an agent control plane that lets sessions spawn or message other conversations via
AgentControl.AgentBus(core/src/agent/bus.rs) keeps track of the last known status of a conversation.ConversationManager now holds shared state behind an Arc so AgentControl keeps only a weak back-reference, the goal is just to avoid explicit cycle reference.
Follow-ups: