core: ExecCommandEnd summary for concise failures #2225
+111
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
summary
toExecCommandEndEvent
with cwd/stdout_tail/stderr_tail and truncation flags.Why
How
summary: Option<ExecCommandSummary>
...
to ignore new field; no behavior change required.Before/After
ExecCommandEnd
contained full truncated streams only; errors in logs were often unhelpful.summary
captures cwd + tails so logs and users see the key failure context quickly.Tests
cargo test
,cargo clippy --tests
,cargo fmt
).Some(summary)
andNone
serialize/deserialize.Risks
DCO/CLA