fix(agents-core): process listeners (#45)

* fix process listeners

* changeset

* add return types

Author: rossrobino

.changeset/honest-lands-pump.md

@@ -0,0 +1,5 @@
+---
+'@openai/agents-core': patch
+---
+
+fix: Process hangs on SIGINT because `process.exit` is never called

packages/agents-core/src/index.ts

@@ -1,7 +1,5 @@
-import logger from './logger';
 import { addTraceProcessor } from './tracing';
 import { defaultProcessor } from './tracing/processor';
-import { getGlobalTraceProvider } from './tracing/provider';
 
 export { RuntimeEventEmitter } from '@openai/agents-core/_shims';
 export {
@@ -148,25 +146,3 @@ export * as protocol from './types/protocol';
  * 2. calling setTraceProcessors, which sets the processors and discards the default one
  */
 addTraceProcessor(defaultProcessor());
-
-const cleanup = async () => {
-  await getGlobalTraceProvider().shutdown();
-};
-
-if (typeof process !== 'undefined' && typeof process.on === 'function') {
-  // handling Node.js process termination
-
-  // Handle normal termination
-  process.on('beforeExit', cleanup);
-
-  // Handle CTRL+C (SIGINT)
-  process.on('SIGINT', cleanup);
-
-  // Handle termination (SIGTERM)
-  process.on('SIGTERM', cleanup);
-
-  process.on('unhandledRejection', (reason, promise) => {
-    logger.error('Unhandled rejection', reason, promise);
-    cleanup();
-  });
-}

packages/agents-core/src/tracing/index.ts

@@ -1,4 +1,3 @@
-import logger from '../logger';
 import { TracingProcessor } from './processor';
 import { getGlobalTraceProvider } from './provider';
 
@@ -47,25 +46,3 @@ export function setTraceProcessors(processors: TracingProcessor[]): void {
 export function setTracingDisabled(disabled: boolean): void {
   getGlobalTraceProvider().setDisabled(disabled);
 }
-
-const cleanup = async () => {
-  await getGlobalTraceProvider().shutdown();
-};
-
-if (typeof process !== 'undefined' && typeof process.on === 'function') {
-  // handling Node.js process termination
-
-  // Handle normal termination
-  process.on('beforeExit', cleanup);
-
-  // Handle CTRL+C (SIGINT)
-  process.on('SIGINT', cleanup);
-
-  // Handle termination (SIGTERM)
-  process.on('SIGTERM', cleanup);
-
-  process.on('unhandledRejection', (reason, promise) => {
-    logger.error('Unhandled rejection', reason, promise);
-    cleanup();
-  });
-}

packages/agents-core/src/tracing/provider.ts

@@ -23,6 +23,8 @@ export class TraceProvider {
       // disable tracing in tests by default
       this.#disabled = true;
     }
+
+    this.#addCleanupListeners();
   }
 
   /**
@@ -155,14 +157,54 @@ export class TraceProvider {
     );
   }
 
-  shutdown(timeout?: number): void {
+  async shutdown(timeout?: number): Promise<void> {
     try {
       logger.debug('Shutting down tracing provider');
-      this.#multiProcessor.shutdown(timeout);
+      await this.#multiProcessor.shutdown(timeout);
     } catch (error) {
       logger.error('Error shutting down tracing provider %o', error);
     }
   }
+
+  /** Adds listeners to `process` to ensure `shutdown` occurs before exit. */
+  #addCleanupListeners(): void {
+    if (typeof process !== 'undefined' && typeof process.on === 'function') {
+      // handling Node.js process termination
+      const cleanup = async () => {
+        const timeout = setTimeout(() => {
+          console.warn('Cleanup timeout, forcing exit');
+          process.exit(1);
+        }, 5000);
+
+        try {
+          await this.shutdown();
+        } finally {
+          clearTimeout(timeout);
+        }
+      };
+
+      // Handle normal termination
+      process.on('beforeExit', cleanup);
+
+      // Handle CTRL+C (SIGINT)
+      process.on('SIGINT', async () => {
+        await cleanup();
+        process.exit(130);
+      });
+
+      // Handle termination (SIGTERM)
+      process.on('SIGTERM', async () => {
+        await cleanup();
+        process.exit(0);
+      });
+
+      process.on('unhandledRejection', async (reason, promise) => {
+        logger.error('Unhandled rejection', reason, promise);
+        await cleanup();
+        process.exit(1);
+      });
+    }
+  }
 }
 
 let GLOBAL_TRACE_PROVIDER: TraceProvider | undefined = undefined;