Fix #131 Human in the Loop MCP approval fails (#156)

Author: seratch

packages/agents-core/src/runState.ts

@@ -165,6 +165,8 @@ const serializedProcessedResponseSchema = z.object({
             arguments: z.string().optional(),
             status: z.string().optional(),
             output: z.string().optional(),
+            // this always exists but marked as optional for early version compatibility; when releasing 1.0, we can remove the nullable and optional
+            providerData: z.record(z.string(), z.any()).nullable().optional(),
           }),
         }),
         // HostedMCPTool

packages/agents-core/test/runState.test.ts

@@ -278,7 +278,50 @@ describe('deserialize helpers', () => {
       functions: [],
       handoffs: [],
       computerActions: [{ toolCall: call, computer: tool }],
-      mcpApprovalRequests: [],
+      mcpApprovalRequests: [
+        {
+          requestItem: {
+            rawItem: {
+              type: 'hosted_tool_call',
+              name: 'fetch_generic_url_content',
+              status: 'in_progress',
+              providerData: {
+                id: 'mcpr_685bc3c47ed88192977549b5206db77504d4306d5de6ab36',
+                type: 'mcp_approval_request',
+                arguments:
+                  '{"url":"https://raw.githubusercontent.com/openai/codex/main/README.md"}',
+                name: 'fetch_generic_url_content',
+                server_label: 'gitmcp',
+              },
+            },
+            type: 'tool_approval_item',
+            agent: new Agent({ name: 'foo ' }),
+            toJSON: function (): any {
+              throw new Error('Function not implemented.');
+            },
+          },
+          mcpTool: {
+            type: 'hosted_tool',
+            name: 'hosted_mcp',
+            providerData: {
+              type: 'mcp',
+              server_label: 'gitmcp',
+              server_url: 'https://gitmcp.io/openai/codex',
+              require_approval: {
+                always: {
+                  tool_names: ['fetch_generic_url_content'],
+                },
+                never: {
+                  tool_names: [
+                    'search_codex_code',
+                    'fetch_codex_documentation',
+                  ],
+                },
+              },
+            },
+          },
+        },
+      ],
       toolsUsed: [],
       hasToolsOrApprovalsToRun: () => true,
     };
@@ -292,5 +335,15 @@ describe('deserialize helpers', () => {
     if (restored._currentStep?.type === 'next_step_handoff') {
       expect(restored._currentStep.newAgent).toBe(agent);
     }
+    expect(
+      restored._lastProcessedResponse?.mcpApprovalRequests[0].mcpTool,
+    ).toEqual(state._lastProcessedResponse?.mcpApprovalRequests[0].mcpTool);
+    expect(
+      restored._lastProcessedResponse?.mcpApprovalRequests[0].requestItem
+        .rawItem.providerData,
+    ).toEqual(
+      state._lastProcessedResponse?.mcpApprovalRequests[0].requestItem.rawItem
+        .providerData,
+    );
   });
 });