improve tests

Author: seratch

packages/agents-openai/test/openaiResponsesModel.test.ts

@@ -13,7 +13,7 @@ describe('OpenAIResponsesModel', () => {
     setTracingDisabled(true);
   });
   it('getResponse returns correct ModelResponse and calls client with right parameters', async () => {
-    withTrace('test', async () => {
+    await withTrace('test', async () => {
       const fakeResponse = {
         id: 'res1',
         usage: {
@@ -74,8 +74,8 @@ describe('OpenAIResponsesModel', () => {
     });
   });
 
-  it('omits instructions when systemInstructions is empty or whitespace', async () => {
-    withTrace('test', async () => {
+  it('normalizes systemInstructions so empty strings are omitted', async () => {
+    await withTrace('test', async () => {
       const fakeResponse = {
         id: 'res-empty-instructions',
         usage: {
@@ -85,15 +85,9 @@ describe('OpenAIResponsesModel', () => {
         },
         output: [],
       };
-      const createMock = vi.fn().mockResolvedValue(fakeResponse);
-      const fakeClient = {
-        responses: { create: createMock },
-      } as unknown as OpenAI;
-      const model = new OpenAIResponsesModel(fakeClient, 'gpt-empty');
-
-      for (const instructions of ['', '   ']) {
+      for (const systemInstructions of ['', '   ']) {
         const request = {
-          systemInstructions: instructions,
+          systemInstructions,
           input: 'hello',
           modelSettings: {},
           tools: [],
@@ -102,19 +96,45 @@ describe('OpenAIResponsesModel', () => {
           tracing: false,
           signal: undefined,
         };
-        await model.getResponse(request as any);
+        const createMock = vi.fn().mockResolvedValue(fakeResponse);
+        await new OpenAIResponsesModel(
+          { responses: { create: createMock } } as unknown as OpenAI,
+          'gpt-test',
+        ).getResponse(request as any);
 
         expect(createMock).toHaveBeenCalledTimes(1);
         const [args] = createMock.mock.calls[0];
         expect('instructions' in args).toBe(true);
         expect(args.instructions).toBeUndefined();
-        expect(args.instructions).toBeUndefined();
+      }
+
+      for (const systemInstructions of [' a ', 'foo']) {
+        const request = {
+          systemInstructions,
+          input: 'hello',
+          modelSettings: {},
+          tools: [],
+          outputType: 'text',
+          handoffs: [],
+          tracing: false,
+          signal: undefined,
+        };
+        const createMock = vi.fn().mockResolvedValue(fakeResponse);
+        await new OpenAIResponsesModel(
+          { responses: { create: createMock } } as unknown as OpenAI,
+          'gpt-test',
+        ).getResponse(request as any);
+
+        expect(createMock).toHaveBeenCalledTimes(1);
+        const [args] = createMock.mock.calls[0];
+        expect('instructions' in args).toBe(true);
+        expect(args.instructions).toBe(systemInstructions);
       }
     });
   });
 
   it('merges top-level reasoning and text settings into provider data for Responses API', async () => {
-    withTrace('test', async () => {
+    await withTrace('test', async () => {
       const fakeResponse = {
         id: 'res-settings',
         usage: {
@@ -173,7 +193,7 @@ describe('OpenAIResponsesModel', () => {
   });
 
   it('getStreamedResponse yields events and calls client with stream flag', async () => {
-    withTrace('test', async () => {
+    await withTrace('test', async () => {
       const fakeResponse = { id: 'res2', usage: {}, output: [] };
       const events: ResponseStreamEvent[] = [
         { type: 'response.created', response: fakeResponse as any },