Skip to content

Commit 7a3a1b6

Browse files
committed
Update AGENTS.md
1 parent b94432b commit 7a3a1b6

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

AGENTS.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,9 @@ The OpenAI Agents JS repository is a pnpm-managed monorepo that provides:
5353

5454
## Testing & Automated Checks
5555

56-
Before submitting changes, ensure all checks pass:
56+
Before submitting changes, ensure all checks pass and augment tests when you touch code:
57+
58+
- Add or update unit tests for any code change unless it is truly infeasible; if something prevents adding tests, explain why in the PR.
5759

5860
### Unit Tests and Type Checking
5961

@@ -106,6 +108,14 @@ See [this README](integration-tests/README.md) for details.
106108
```
107109
- Build runs `tsx scripts/embedMeta.ts` (prebuild) and `tsc` for each package.
108110

111+
### Mandatory Local Run Order
112+
113+
For every code change, run the full validation sequence locally:
114+
115+
```bash
116+
pnpm lint && pnpm build && pnpm -r build-check && pnpm test
117+
```
118+
109119
### Pre-commit Hooks
110120

111121
- You can skip failing precommit hooks using `--no-verify` during commit.
@@ -160,10 +170,10 @@ See [this README](integration-tests/README.md) for details.
160170
```bash
161171
git checkout -b feat/<short-description>
162172
```
163-
3. Make changes, add/update tests in `packages/<pkg>/test`.
164-
4. Run all checks:
173+
3. Make changes and add/update unit tests in `packages/<pkg>/test` unless doing so is truly infeasible.
174+
4. Run all checks (in this order):
165175
```bash
166-
pnpm build && pnpm test && pnpm lint
176+
pnpm lint && pnpm build && pnpm -r build-check && pnpm test
167177
```
168178
5. Commit using Conventional Commits.
169179
6. Push and open a pull request.

0 commit comments

Comments
 (0)