Commit 9ceeb97
committed
fix local codex review comment:
- [P0] Always capture previousResponseId — packages/agents-core/src/run.ts:1791-1796
When we start a Responses conversation without an explicit conversationId or previousResponseId, trackServerItems should capture the first response ID so that
follow-up turns can pass it back to the API. The new guard this.previousResponseId !== undefined prevents that first assignment, so previousResponseId stays
undefined forever and second turn requests go up without any conversation context even though we only send the delta. That means the model loses all history and
breaks server-managed conversation flows. Please drop that guard and always record the latest response ID whenever conversationId is absent.1 parent 46989c1 commit 9ceeb97
1 file changed
+1
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1799 | 1799 | | |
1800 | 1800 | | |
1801 | 1801 | | |
1802 | | - | |
1803 | | - | |
1804 | | - | |
1805 | | - | |
1806 | | - | |
| 1802 | + | |
1807 | 1803 | | |
1808 | 1804 | | |
1809 | 1805 | | |
| |||
0 commit comments