Skip to content

Conversation

@Manouchehri
Copy link
Contributor

Should fix #26

@Manouchehri Manouchehri marked this pull request as ready for review June 5, 2025 13:19
@Manouchehri
Copy link
Contributor Author

Confirmed, this fixed #26 for me.

@dkundel-openai
Copy link
Collaborator

Thank you @Manouchehri for the fix. Can you run pnpm changeset and create a changeset for this fix and push it to this branch? This helps us keep track of it in the changelog

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2025

🦋 Changeset detected

Latest commit: b265903

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@openai/agents-openai Minor
@openai/agents Patch
@openai/agents-extensions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dkundel-openai
Copy link
Collaborator

Apologies for the confusion you don't have to run pnpm changeset version just pnpm changeset to generate a file. We will do the version bump. Can you revert that change. I also set up now a bot that should help generate the changesets

@dkundel-openai
Copy link
Collaborator

Here is an example of how the output should look like --> #9

@Manouchehri
Copy link
Contributor Author

@dkundel-openai Done, I think? :)

Copy link
Collaborator

@dkundel-openai dkundel-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests in openaiChatCompletionsModel are breaking. Can you fix them and run pnpm test && pnpm test:examples afterwards? Thank you

@Manouchehri
Copy link
Contributor Author

@dkundel-openai Should be done.

@dkundel-openai dkundel-openai merged commit 0474de9 into openai:main Jun 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chat_completions breaks handoffs

3 participants