fix(agents-core): ensure handoff messages use valid JSON #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base Fix schema version serialization
…pdate Add patch changeset for schema version fix
…pdate Add patch changeset for schema version fix
…essage Fix/invalid json in transfer message
🦋 Changeset detectedLatest commit: 35ce3fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seratch
reviewed
Jun 6, 2025
| export function getTransferMessage<TContext, TOutput extends AgentOutputType>( | ||
| agent: Agent<TContext, TOutput>, | ||
| ) { | ||
| return `{'assistant': '${agent.name}'}`; |
Member
There was a problem hiding this comment.
The only reason why we went with this string is to align with Python SDK. As long as the standard JSON format works without any issues here, I think it should be fine to change this. @dkundel-openai thoughts?
dkundel-openai
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTransferMessage isn't returning a valid JSON, added a test to verify the output
added changeset