GPT‑5 model settings under providerData #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated modelSettings to include providerData structure.
|
seratch
added
documentation
seratch
approved these changes
Sep 15, 2025
Member
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
You're right that the document was incorrect
anshagrawal-plivo
pushed a commit
to anshagrawal-plivo/openai-agents-js
that referenced
this pull request
Sep 16, 2025
Co-authored-by: Kazuhiro Sera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update the models guide to show GPT‑5 settings inside the providerData object so provider-specific options are placed in the correct location.
Changes: edit docs/src/content/docs/guides/models.mdx to demonstrate modelSettings.providerData.
Example: see example usage in examples/basic/hello-world-gpt-5.ts (shows modelSettings.providerData and an OpenAIChatCompletionsModel example).
Impact: docs-only change; no changeset required.