fix: #473 upgrade openai package to the latest and fix breaking errors #476
Conversation
seratch
added
package:agents-core
package:agents-openai
dependencies
🦋 Changeset detectedLatest commit: 1025148 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| export type WebSearchTool = Omit<OpenAI.Responses.WebSearchTool, 'type'> & { | ||
| type: 'web_search'; | ||
| name: 'web_search' | 'web_search_preview' | string; | ||
| }; |
There was a problem hiding this comment.
[P1] Restore correct WebSearch tool type
The WebSearchTool alias now points at OpenAI.Responses.WebSearchTool, but in [email protected] that interface represents the preview tool (type: 'web_search_preview') and no longer declares properties like filters while requiring a user_location.type. Our implementation still builds the 'web_search' payload with filters and optional location, so this change produces TypeScript errors (extra property filters, missing user_location.type) and models the wrong API. The nested OpenAI.Responses.Tool.WebSearchTool still matches the real web search tool; switch the alias (and the corresponding UserLocation usage in tools.ts) back to that type.
Useful? React with 👍 / 👎.
This pull request resolves #473