-
Notifications
You must be signed in to change notification settings - Fork 497
fix: #483 expose Call ID in OpenAIRealtimeWebRTC #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #483 expose Call ID in OpenAIRealtimeWebRTC #487
Conversation
🦋 Changeset detectedLatest commit: 49998e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@codex review this |
|
Thanks for sending this! At a glance, the changes look good to me (I will check this with fresh eyes tomorrow). If you're willing to spend more time on this, adding some unit tests would be great (I know it could be tricky for this module, so no pressure) |
|
Codex Review: Didn't find any major issues. Chef's kiss. About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
|
@seratch I have added a few checks and tests in the latest commit, hope this helps! |
seratch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking the time to add this! I've confirmed this perfectly works.
Resolves #483
I exposed the WebRTC Call ID - included in the response headers in the /calls API call - as a WebRTCState attribute and getter.