Skip to content

Conversation

@cnaples79
Copy link

Summary

When a session config includes top-level , the converter treated the config as legacy and discarded GA audio formats. This change refines legacy detection and lifts top-level into in the GA path, preserving GA formats.

Rationale

Issue #495 reports that adding causes fallback to legacy, resetting telephony formats like . GA-shaped configs should remain GA even when is provided.

Changes

  • Remove top-level from the legacy detection heuristic.
  • In GA conversion, set from top-level if GA audio config is present, or construct a minimal GA audio block if not.
  • Add regression test to ensure GA formats persist when is present.

Tests

  • New test validates preserves and lifts .

Fixes #495

…voice is present; preserve GA audio formats (Fixes openai#495)

- Remove top-level  from legacy detection heuristic
- In GA path, lift top-level  into  when GA audio config is provided
- Add regression test to ensure GA audio formats are preserved with top-level voice present
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2025

⚠️ No Changeset found

Latest commit: 937b48e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@seratch seratch added the duplicate This issue or pull request already exists label Sep 22, 2025
@seratch
Copy link
Member

seratch commented Sep 22, 2025

Thanks for sending this but the issue was resolved by #497

@seratch seratch closed this Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Realtime session config falls back to legacy format when voice is set

2 participants