fix(randomUUID): add fallback when crypto.randomUUID is unavailable #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HTTP/older envs) In some environments (non-secure origins like http, older browsers, certain test runners), `crypto.randomUUID` is not available, causing runtime errors. This change preserves the existing fast path when `crypto.randomUUID` exists, and adds a RFC4122 v4-shaped fallback for other cases: - Detects availability via: typeof crypto !== 'undefined' && crypto.randomUUID - Uses `crypto.randomUUID.bind(crypto)` when present - Otherwise formats a UUID using 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(...) with Math.random, ensuring version (4) and variant (8|9|a|b) bits - Keeps strict typing with template-literal UUID type for DX No breaking changes.
🦋 Changeset detectedLatest commit: 62d8648 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
@ziyak97 This looks great. Could you add some unit tests to help with long-term maintenance? |
Contributor
Author
|
Done @seratch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments (non-secure origins like http, older browsers, certain test runners),
crypto.randomUUIDis not available, causing runtime errors.This change preserves the existing fast path when
crypto.randomUUIDexists, and adds a RFC4122 v4-shaped fallback for other cases:crypto.randomUUID.bind(crypto)when presentNo breaking changes.