Skip to content

Conversation

@AielloChan
Copy link
Contributor

Some OpenAI API compatible model will throw error with empty tools param.

To make OpenAIChatCompletionsModel more robust

@AielloChan AielloChan changed the title fix: Remove tools param when empty fix: Remove empty tools param Jun 7, 2025
@dkundel-openai
Copy link
Collaborator

Thank you! This looks good but can you add a changeset please?

@AielloChan
Copy link
Contributor Author

Thank you! This looks good but can you add a changeset please?

Sorry, I don't know how to add changeset, should I run pnpm changeset and bump up @openai/agents-openai to version 0.0.4?

@seratch
Copy link
Member

seratch commented Jun 9, 2025

When you run pnpm changeset command, the interactive mode asks you to select the changed module and whether it's a major, minor, or patch version upgrade. Please select only agents-openai and choose the "patch" upgrade. There is no need to specify a specific version.

@AielloChan
Copy link
Contributor Author

When I run pnpm changeset in GitHub workspace, it works not as expected.

Safari 2025-06-09 10 11 26 Safari 2025-06-09 10 11 36 image image

It doesn't ask me to choose patch version 🥲

@seratch
Copy link
Member

seratch commented Jun 9, 2025

I do understand the interaction could be a bit confusing 😅 , but you can just hit the enter button when you’re asked about major and minor version bumps. Then, the shell will then select "patch" for you.

@AielloChan AielloChan force-pushed the fix/ignore-empty-tools branch from 7fbfef6 to e38d896 Compare June 9, 2025 02:36
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: e38d896

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@openai/agents-openai Patch
@openai/agents Patch
@openai/agents-extensions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AielloChan
Copy link
Contributor Author

I do understand the interaction could be a bit confusing 😅 , but you can just hit the enter button when you’re asked about major and minor version bumps. Then, the shell will then select "patch" for you.

I just hit enter button, but it still generates major tag in changesets file. So I just changed it to patch.

Safari 2025-06-09 10 35 04

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to improve this! Your changes will be merged soon (on Monday US time)

@dkundel-openai dkundel-openai merged commit adeb218 into openai:main Jun 9, 2025
5 checks passed
@seratch seratch added the bug Something isn't working label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package:agents-openai

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants