rename methods to improve clarity and consistency

Author: habema

examples/memory/advanced_sqlite_session_example_2.py

@@ -88,7 +88,7 @@ async def main():
 
     # Soft delete from turn 2 to create a branch point
     print("\nSoft deleting from turn 2 onwards to create branch point...")
-    deleted = await session.soft_delete_from_turn(2)
+    deleted = await session.deactivate_from_turn(2)
     print(f"Deleted: {deleted}")
 
     # Show only active items (turn 1 only)

src/agents/extensions/memory/advanced_sqlite_session.py

@@ -194,7 +194,7 @@ def _add_structure_sync():
                         current_turn += 1
                         self._current_user_turn = current_turn
 
-                    msg_type = self._classify_simple(item)
+                    msg_type = self._classify_message_type(item)
                     tool_name = self._extract_tool_name(item)
 
                     structure_data.append(
@@ -228,7 +228,7 @@ def _add_structure_sync():
             )
             # Don't re-raise - structure metadata is supplementary
 
-    def _classify_simple(self, item: TResponseInputItem) -> str:
+    def _classify_message_type(self, item: TResponseInputItem) -> str:
         """Simple classification."""
         if isinstance(item, dict):
             if item.get("role") == "user":
@@ -328,10 +328,10 @@ def _get_active_items_sync():
 
         return await asyncio.to_thread(_get_active_items_sync)
 
-    async def soft_delete_from_turn(self, user_turn_number: int) -> bool:
+    async def deactivate_from_turn(self, user_turn_number: int) -> bool:
         """Soft delete conversation from a specific user turn onwards."""
 
-        def _soft_delete_sync():
+        def _deactivate_sync():
             conn = self._get_connection()
             with self._lock if self._is_memory_db else threading.Lock():
                 with closing(conn.cursor()) as cursor:
@@ -347,7 +347,7 @@ def _soft_delete_sync():
                     conn.commit()
                     return affected > 0
 
-        return await asyncio.to_thread(_soft_delete_sync)
+        return await asyncio.to_thread(_deactivate_sync)
 
     async def reactivate_from_turn(self, user_turn_number: int) -> bool:
         """Reactivate soft-deleted conversation from a specific turn."""

tests/extensions/memory/test_advanced_sqlite_session.py

@@ -185,7 +185,7 @@ async def test_soft_deletion_functionality(agent: Agent):
     assert len(all_items) == 6
 
     # Soft delete from turn 2 onwards
-    deleted = await session.soft_delete_from_turn(2)
+    deleted = await session.deactivate_from_turn(2)
     assert deleted is True
 
     # Verify only turn 1 items are active
@@ -414,7 +414,7 @@ async def test_empty_session_operations():
     assert session_usage is None
 
     # Test soft deletion on empty session
-    deleted = await session.soft_delete_from_turn(1)
+    deleted = await session.deactivate_from_turn(1)
     assert deleted is False
 
     session.close()