Skip to content

feat(tests): add tests for unicode content, special characters, and concurrent access in SQLiteSession #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PatrykBochenek
Copy link
Contributor

@PatrykBochenek PatrykBochenek commented Aug 7, 2025

Summary

The changes in the PR help the robustness of the SQLiteSesssion tests. It adds coverage for edge cases, including unicode content, special characters, SQL injection attempts, session isolation and concurrent access.

Test plan

  • Added new tests for unicode/non-ASCII content, special characters, SQL injection, session isolation and concurrent access.
  • Verified that all session memory tests pass after the changes.
  • Manually run test suite to confirm correctness and data integrity.

Issue number

N/A

Checks

  • I've added new tests (if relevant)
  • I've added/updated the relevant documentation
  • I've run make lint and make format
  • I've made sure tests pass

@seratch seratch enabled auto-merge (squash) August 11, 2025 03:47
@seratch
Copy link
Member

seratch commented Aug 11, 2025

Can you resolve mypy errors?

auto-merge was automatically disabled August 11, 2025 21:38

Head branch was pushed to by a user without write access

@PatrykBochenek
Copy link
Contributor Author

Fixed mypy errors in session tests. Apologies for the unnecessary merge commit earlier, please squash on merge if possible.

@seratch seratch enabled auto-merge (squash) August 11, 2025 21:57
@seratch seratch merged commit bad88e7 into openai:main Aug 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants