fix(strict_schema): correct error message and replace runtime assert #1920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two critical issues in the strict schema validation: 1. **Corrected error message for additionalProperties**: - Changed the misleading error message from "additionalProperties should not be set" to "additionalProperties should be set to False" - This accurately reflects the requirement that object types must explicitly set `additionalProperties: false` rather than implying it shouldn't be set at all - Prevents confusion for users encountering this validation error 2. **Replaced dangerous assert with proper exception handling**: - Replaced the `assert is_dict(value)` statement with proper runtime validation - Now raises a `ValueError` with clear message instead of relying on `assert` - Ensures validation works properly in optimized Python environments (when run with `-O` flag) - Maintains the same error semantics while making the code production-safe Both fixes maintain backward compatibility while improving error clarity and runtime safety.
Member
|
I don't think the current error message here is incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses two critical issues in the strict schema validation:
Corrected error message for additionalProperties:
additionalProperties: falserather than implying it shouldn't be set at allReplaced dangerous assert with proper exception handling:
assert is_dict(value)statement with proper runtime validationValueErrorwith clear message instead of relying onassert-Oflag)Both fixes maintain backward compatibility while improving error clarity and runtime safety.