Remove duplicate methods (#724)

christothes · web-flow · commit aa1c93087bfc · 2025-10-02T15:32:58.000Z
diff --git a/api/OpenAI.net8.0.cs b/api/OpenAI.net8.0.cs
@@ -5331,18 +5331,14 @@ public class OpenAIResponseClient {
         public virtual ClientResult<ResponseDeletionResult> DeleteResponse(string responseId, CancellationToken cancellationToken = default);
         public virtual Task<ClientResult> DeleteResponseAsync(string responseId, RequestOptions options);
         public virtual Task<ClientResult<ResponseDeletionResult>> DeleteResponseAsync(string responseId, CancellationToken cancellationToken = default);
-        public virtual CollectionResult<ResponseItem> GetInputItems(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
-        public virtual CollectionResult GetInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options);
-        public virtual AsyncCollectionResult<ResponseItem> GetInputItemsAsync(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
-        public virtual AsyncCollectionResult GetInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options);
         public virtual ClientResult GetResponse(string responseId, bool? stream, int? startingAfter, RequestOptions options);
         public virtual ClientResult<OpenAIResponse> GetResponse(string responseId, CancellationToken cancellationToken = default);
         public virtual Task<ClientResult> GetResponseAsync(string responseId, bool? stream, int? startingAfter, RequestOptions options);
         public virtual Task<ClientResult<OpenAIResponse>> GetResponseAsync(string responseId, CancellationToken cancellationToken = default);
         public virtual CollectionResult<ResponseItem> GetResponseInputItems(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
-        public virtual CollectionResult GetResponseInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options = null);
+        public virtual CollectionResult GetResponseInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options);
         public virtual AsyncCollectionResult<ResponseItem> GetResponseInputItemsAsync(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
-        public virtual AsyncCollectionResult GetResponseInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options = null);
+        public virtual AsyncCollectionResult GetResponseInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options);
         public virtual CollectionResult<StreamingResponseUpdate> GetResponseStreaming(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default);
         public virtual AsyncCollectionResult<StreamingResponseUpdate> GetResponseStreamingAsync(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default);
     }
diff --git a/api/OpenAI.netstandard2.0.cs b/api/OpenAI.netstandard2.0.cs
@@ -4703,18 +4703,14 @@ public class OpenAIResponseClient {
         public virtual ClientResult<ResponseDeletionResult> DeleteResponse(string responseId, CancellationToken cancellationToken = default);
         public virtual Task<ClientResult> DeleteResponseAsync(string responseId, RequestOptions options);
         public virtual Task<ClientResult<ResponseDeletionResult>> DeleteResponseAsync(string responseId, CancellationToken cancellationToken = default);
-        public virtual CollectionResult<ResponseItem> GetInputItems(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
-        public virtual CollectionResult GetInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options);
-        public virtual AsyncCollectionResult<ResponseItem> GetInputItemsAsync(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
-        public virtual AsyncCollectionResult GetInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options);
         public virtual ClientResult GetResponse(string responseId, bool? stream, int? startingAfter, RequestOptions options);
         public virtual ClientResult<OpenAIResponse> GetResponse(string responseId, CancellationToken cancellationToken = default);
         public virtual Task<ClientResult> GetResponseAsync(string responseId, bool? stream, int? startingAfter, RequestOptions options);
         public virtual Task<ClientResult<OpenAIResponse>> GetResponseAsync(string responseId, CancellationToken cancellationToken = default);
         public virtual CollectionResult<ResponseItem> GetResponseInputItems(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
-        public virtual CollectionResult GetResponseInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options = null);
+        public virtual CollectionResult GetResponseInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options);
         public virtual AsyncCollectionResult<ResponseItem> GetResponseInputItemsAsync(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
-        public virtual AsyncCollectionResult GetResponseInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options = null);
+        public virtual AsyncCollectionResult GetResponseInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options);
         public virtual CollectionResult<StreamingResponseUpdate> GetResponseStreaming(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default);
         public virtual AsyncCollectionResult<StreamingResponseUpdate> GetResponseStreamingAsync(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default);
     }
diff --git a/codegen/generator/src/Visitors/PaginationVisitor.cs b/codegen/generator/src/Visitors/PaginationVisitor.cs
@@ -88,11 +88,11 @@ public class PaginationVisitor : ScmLibraryVisitor
             ("ContainerFileResource", "ContainerFileCollectionOptions", _paginationParamsToReplace)
         },
         {
-            "GetInputItems",
+            "GetResponseInputItems",
             ("ResponseItem", "ResponseItemCollectionOptions", _paginationParamsToReplace)
         },
         {
-            "GetInputItemsAsync",
+            "GetResponseInputItemsAsync",
             ("ResponseItem", "ResponseItemCollectionOptions", _paginationParamsToReplace)
         },
         {
diff --git a/specification/client/responses.client.tsp b/specification/client/responses.client.tsp
@@ -69,6 +69,8 @@ using Azure.ClientGenerator.Core;
 
 @@clientName(MCPToolFilter.read_only, "IsReadOnly");
 
+@@clientName(Responses.listInputItems, "GetResponseInputItems");
+
 // ------------ Streaming ------------
 
 @@alternateType(ResponseFunctionCallArgumentsDoneEvent.arguments, unknown);
diff --git a/src/Custom/Responses/OpenAIResponseClient.Protocol.cs b/src/Custom/Responses/OpenAIResponseClient.Protocol.cs
@@ -32,30 +32,4 @@ public virtual ClientResult GetResponse(string responseId, bool? stream, int? st
         PipelineResponse protocolResponse = Pipeline.ProcessMessage(message, options);
         return ClientResult.FromResponse(protocolResponse);
     }
-
-    public virtual AsyncCollectionResult GetResponseInputItemsAsync(
-        string responseId,
-        int? limit,
-        string order,
-        string after,
-        string before,
-        RequestOptions options = null)
-    {
-        Argument.AssertNotNull(responseId, nameof(responseId));
-
-        return new AsyncResponseItemCollectionResult(this, responseId, limit, order, after, before, options);
-    }
-
-    public virtual CollectionResult GetResponseInputItems(
-        string responseId,
-        int? limit,
-        string order,
-        string after,
-        string before,
-        RequestOptions options = null)
-    {
-        Argument.AssertNotNull(responseId, nameof(responseId));
-
-        return new ResponseItemCollectionResult(this, responseId, limit, order, after, before, options);
-    }
 }
diff --git a/src/Custom/Responses/OpenAIResponseClient.cs b/src/Custom/Responses/OpenAIResponseClient.cs
@@ -266,34 +266,6 @@ public virtual CollectionResult<StreamingResponseUpdate> GetResponseStreaming(st
             cancellationToken);
     }
 
-    public virtual AsyncCollectionResult<ResponseItem> GetResponseInputItemsAsync(string responseId, ResponseItemCollectionOptions options = default, CancellationToken cancellationToken = default)
-    {
-        Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
-
-        AsyncCollectionResult result = GetResponseInputItemsAsync(responseId, options?.PageSizeLimit, options?.Order?.ToString(), options?.AfterId, options?.BeforeId, cancellationToken.ToRequestOptions());
-
-        if (result is not AsyncCollectionResult<ResponseItem> responsesItemCollection)
-        {
-            throw new InvalidOperationException("Failed to cast protocol return type to expected collection type 'AsyncCollectionResult<ResponsesItem>'.");
-        }
-
-        return responsesItemCollection;
-    }
-
-    public virtual CollectionResult<ResponseItem> GetResponseInputItems(string responseId, ResponseItemCollectionOptions options = default, CancellationToken cancellationToken = default)
-    {
-        Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
-
-        CollectionResult result = GetResponseInputItems(responseId, options?.PageSizeLimit, options?.Order?.ToString(), options?.AfterId, options?.BeforeId, cancellationToken.ToRequestOptions());
-
-        if (result is not CollectionResult<ResponseItem> responsesItemCollection)
-        {
-            throw new InvalidOperationException("Failed to cast protocol return type to expected collection type 'CollectionResult<ResponsesItem>'.");
-        }
-
-        return responsesItemCollection;
-    }
-
     public virtual async Task<ClientResult<ResponseDeletionResult>> DeleteResponseAsync(string responseId, CancellationToken cancellationToken = default)
     {
         Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
diff --git a/src/Custom/Responses/Pagination/Internal/AsyncResponseItemCollectionResult.cs b/src/Custom/Responses/Pagination/Internal/AsyncResponseItemCollectionResult.cs
@@ -83,7 +83,7 @@ public async Task<ClientResult> GetNextPageAsync(ClientResult result)
 
     internal virtual async Task<ClientResult> GetResponsesAsync(string responseId, int? limit, string? order, string? after, string? before, RequestOptions? options)
     {
-        using PipelineMessage message = _parentClient.CreateGetInputItemsRequest(responseId, limit, order, after, before, options);
+        using PipelineMessage message = _parentClient.CreateGetResponseInputItemsRequest(responseId, limit, order, after, before, options);
         return ClientResult.FromResponse(await _parentClient.Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
     }
 }
diff --git a/src/Custom/Responses/Pagination/Internal/ResponseItemCollectionResult.cs b/src/Custom/Responses/Pagination/Internal/ResponseItemCollectionResult.cs
@@ -91,7 +91,7 @@ public static bool HasNextPage(ClientResult result)
 
     internal virtual ClientResult GetResponseInputItems(string responseId, int? limit, string? order, string? after, string? before, RequestOptions? options)
     {
-        using PipelineMessage message = _parentClient.CreateGetInputItemsRequest(responseId, limit, order, after, before, options);
+        using PipelineMessage message = _parentClient.CreateGetResponseInputItemsRequest(responseId, limit, order, after, before, options);
         return ClientResult.FromResponse(_parentClient.Pipeline.ProcessMessage(message, options));
     }
 }
diff --git a/src/Generated/OpenAIResponseClient.RestClient.cs b/src/Generated/OpenAIResponseClient.RestClient.cs
@@ -84,7 +84,7 @@ internal virtual PipelineMessage CreateCancelResponseRequest(string responseId,
             return message;
         }
 
-        internal virtual PipelineMessage CreateGetInputItemsRequest(string responseId, int? limit, string order, string after, string before, RequestOptions options)
+        internal virtual PipelineMessage CreateGetResponseInputItemsRequest(string responseId, int? limit, string order, string after, string before, RequestOptions options)
         {
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
diff --git a/src/Generated/OpenAIResponseClient.cs b/src/Generated/OpenAIResponseClient.cs
@@ -77,11 +77,11 @@ public virtual async Task<ClientResult> CancelResponseAsync(string responseId, R
             return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
         }
 
-        public virtual CollectionResult GetInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options)
+        public virtual CollectionResult GetResponseInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options)
         {
             Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
 
-            return new OpenAIResponseClientGetInputItemsCollectionResult(
+            return new OpenAIResponseClientGetResponseInputItemsCollectionResult(
                 this,
                 responseId,
                 limit,
@@ -91,11 +91,11 @@ public virtual CollectionResult GetInputItems(string responseId, int? limit, str
                 options);
         }
 
-        public virtual AsyncCollectionResult GetInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options)
+        public virtual AsyncCollectionResult GetResponseInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options)
         {
             Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
 
-            return new OpenAIResponseClientGetInputItemsAsyncCollectionResult(
+            return new OpenAIResponseClientGetResponseInputItemsAsyncCollectionResult(
                 this,
                 responseId,
                 limit,
@@ -105,11 +105,11 @@ public virtual AsyncCollectionResult GetInputItemsAsync(string responseId, int?
                 options);
         }
 
-        public virtual CollectionResult<ResponseItem> GetInputItems(string responseId, ResponseItemCollectionOptions options = default, CancellationToken cancellationToken = default)
+        public virtual CollectionResult<ResponseItem> GetResponseInputItems(string responseId, ResponseItemCollectionOptions options = default, CancellationToken cancellationToken = default)
         {
             Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
 
-            return new OpenAIResponseClientGetInputItemsCollectionResultOfT(
+            return new OpenAIResponseClientGetResponseInputItemsCollectionResultOfT(
                 this,
                 responseId,
                 options?.PageSizeLimit,
@@ -119,11 +119,11 @@ public virtual CollectionResult<ResponseItem> GetInputItems(string responseId, R
                 cancellationToken.CanBeCanceled ? new RequestOptions { CancellationToken = cancellationToken } : null);
         }
 
-        public virtual AsyncCollectionResult<ResponseItem> GetInputItemsAsync(string responseId, ResponseItemCollectionOptions options = default, CancellationToken cancellationToken = default)
+        public virtual AsyncCollectionResult<ResponseItem> GetResponseInputItemsAsync(string responseId, ResponseItemCollectionOptions options = default, CancellationToken cancellationToken = default)
         {
             Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
 
-            return new OpenAIResponseClientGetInputItemsAsyncCollectionResultOfT(
+            return new OpenAIResponseClientGetResponseInputItemsAsyncCollectionResultOfT(
                 this,
                 responseId,
                 options?.PageSizeLimit,
diff --git a/src/Generated/OpenAIResponseClientGetResponseInputItemsAsyncCollectionResult.cs b/src/Generated/OpenAIResponseClientGetResponseInputItemsAsyncCollectionResult.cs
@@ -10,7 +10,7 @@
 
 namespace OpenAI.Responses
 {
-    internal partial class OpenAIResponseClientGetInputItemsAsyncCollectionResult : AsyncCollectionResult
+    internal partial class OpenAIResponseClientGetResponseInputItemsAsyncCollectionResult : AsyncCollectionResult
     {
         private readonly OpenAIResponseClient _client;
         private readonly string _responseId;
@@ -20,7 +20,7 @@ internal partial class OpenAIResponseClientGetInputItemsAsyncCollectionResult :
         private readonly string _before;
         private readonly RequestOptions _options;
 
-        public OpenAIResponseClientGetInputItemsAsyncCollectionResult(OpenAIResponseClient client, string responseId, int? limit, string order, string after, string before, RequestOptions options)
+        public OpenAIResponseClientGetResponseInputItemsAsyncCollectionResult(OpenAIResponseClient client, string responseId, int? limit, string order, string after, string before, RequestOptions options)
         {
             Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
 
@@ -35,7 +35,7 @@ public OpenAIResponseClientGetInputItemsAsyncCollectionResult(OpenAIResponseClie
 
         public override async IAsyncEnumerable<ClientResult> GetRawPagesAsync()
         {
-            PipelineMessage message = _client.CreateGetInputItemsRequest(_responseId, _limit, _order, _after, _before, _options);
+            PipelineMessage message = _client.CreateGetResponseInputItemsRequest(_responseId, _limit, _order, _after, _before, _options);
             string nextToken = null;
             while (true)
             {
@@ -50,7 +50,7 @@ public override async IAsyncEnumerable<ClientResult> GetRawPagesAsync()
                 {
                     yield break;
                 }
-                message = _client.CreateGetInputItemsRequest(_responseId, _limit, _order, nextToken, _before, _options);
+                message = _client.CreateGetResponseInputItemsRequest(_responseId, _limit, _order, nextToken, _before, _options);
             }
         }
 
diff --git a/src/Generated/OpenAIResponseClientGetResponseInputItemsAsyncCollectionResultOfT.cs b/src/Generated/OpenAIResponseClientGetResponseInputItemsAsyncCollectionResultOfT.cs
@@ -11,7 +11,7 @@
 
 namespace OpenAI.Responses
 {
-    internal partial class OpenAIResponseClientGetInputItemsAsyncCollectionResultOfT : AsyncCollectionResult<ResponseItem>
+    internal partial class OpenAIResponseClientGetResponseInputItemsAsyncCollectionResultOfT : AsyncCollectionResult<ResponseItem>
     {
         private readonly OpenAIResponseClient _client;
         private readonly string _responseId;
@@ -21,7 +21,7 @@ internal partial class OpenAIResponseClientGetInputItemsAsyncCollectionResultOfT
         private readonly string _before;
         private readonly RequestOptions _options;
 
-        public OpenAIResponseClientGetInputItemsAsyncCollectionResultOfT(OpenAIResponseClient client, string responseId, int? limit, string order, string after, string before, RequestOptions options)
+        public OpenAIResponseClientGetResponseInputItemsAsyncCollectionResultOfT(OpenAIResponseClient client, string responseId, int? limit, string order, string after, string before, RequestOptions options)
         {
             Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
 
@@ -36,7 +36,7 @@ public OpenAIResponseClientGetInputItemsAsyncCollectionResultOfT(OpenAIResponseC
 
         public override async IAsyncEnumerable<ClientResult> GetRawPagesAsync()
         {
-            PipelineMessage message = _client.CreateGetInputItemsRequest(_responseId, _limit, _order, _after, _before, _options);
+            PipelineMessage message = _client.CreateGetResponseInputItemsRequest(_responseId, _limit, _order, _after, _before, _options);
             string nextToken = null;
             while (true)
             {
@@ -51,7 +51,7 @@ public override async IAsyncEnumerable<ClientResult> GetRawPagesAsync()
                 {
                     yield break;
                 }
-                message = _client.CreateGetInputItemsRequest(_responseId, _limit, _order, nextToken, _before, _options);
+                message = _client.CreateGetResponseInputItemsRequest(_responseId, _limit, _order, nextToken, _before, _options);
             }
         }
 
diff --git a/src/Generated/OpenAIResponseClientGetResponseInputItemsCollectionResult.cs b/src/Generated/OpenAIResponseClientGetResponseInputItemsCollectionResult.cs
diff --git a/src/Generated/OpenAIResponseClientGetResponseInputItemsCollectionResultOfT.cs b/src/Generated/OpenAIResponseClientGetResponseInputItemsCollectionResultOfT.cs
diff --git a/tests/FineTuning/FineTuningClientTests.cs b/tests/FineTuning/FineTuningClientTests.cs
diff --git a/tests/Responses/ResponseStoreTests.cs b/tests/Responses/ResponseStoreTests.cs
diff --git a/tspCodeModel.json b/tspCodeModel.json

Original file line number	Diff line number	Diff line change
`@@ -88,11 +88,11 @@ public class PaginationVisitor : ScmLibraryVisitor`
`88`	`88`	`("ContainerFileResource", "ContainerFileCollectionOptions", _paginationParamsToReplace)`
`89`	`89`	`},`
`90`	`90`	`{`
`91`		`- "GetInputItems",`
	`91`	`+ "GetResponseInputItems",`
`92`	`92`	`("ResponseItem", "ResponseItemCollectionOptions", _paginationParamsToReplace)`
`93`	`93`	`},`
`94`	`94`	`{`
`95`		`- "GetInputItemsAsync",`
	`95`	`+ "GetResponseInputItemsAsync",`
`96`	`96`	`("ResponseItem", "ResponseItemCollectionOptions", _paginationParamsToReplace)`
`97`	`97`	`},`
`98`	`98`	`{`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public async Task<ClientResult> GetNextPageAsync(ClientResult result)`
`83`	`83`
`84`	`84`	`internal virtual async Task<ClientResult> GetResponsesAsync(string responseId, int? limit, string? order, string? after, string? before, RequestOptions? options)`
`85`	`85`	`{`
`86`		`- using PipelineMessage message = _parentClient.CreateGetInputItemsRequest(responseId, limit, order, after, before, options);`
	`86`	`+ using PipelineMessage message = _parentClient.CreateGetResponseInputItemsRequest(responseId, limit, order, after, before, options);`
`87`	`87`	`return ClientResult.FromResponse(await _parentClient.Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));`
`88`	`88`	`}`
`89`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ public static bool HasNextPage(ClientResult result)`
`91`	`91`
`92`	`92`	`internal virtual ClientResult GetResponseInputItems(string responseId, int? limit, string? order, string? after, string? before, RequestOptions? options)`
`93`	`93`	`{`
`94`		`- using PipelineMessage message = _parentClient.CreateGetInputItemsRequest(responseId, limit, order, after, before, options);`
	`94`	`+ using PipelineMessage message = _parentClient.CreateGetResponseInputItemsRequest(responseId, limit, order, after, before, options);`
`95`	`95`	`return ClientResult.FromResponse(_parentClient.Pipeline.ProcessMessage(message, options));`
`96`	`96`	`}`
`97`	`97`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ internal virtual PipelineMessage CreateCancelResponseRequest(string responseId,`
`84`	`84`	`return message;`
`85`	`85`	`}`
`86`	`86`
`87`		`- internal virtual PipelineMessage CreateGetInputItemsRequest(string responseId, int? limit, string order, string after, string before, RequestOptions options)`
	`87`	`+ internal virtual PipelineMessage CreateGetResponseInputItemsRequest(string responseId, int? limit, string order, string after, string before, RequestOptions options)`
`88`	`88`	`{`
`89`	`89`	`ClientUriBuilder uri = new ClientUriBuilder();`
`90`	`90`	`uri.Reset(_endpoint);`