Skip to content

Commit b0e91cb

Browse files
committed
remove duplicate methods
1 parent 6bb8493 commit b0e91cb

File tree

6 files changed

+3
-65
lines changed

6 files changed

+3
-65
lines changed

api/OpenAI.net8.0.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5338,10 +5338,6 @@ public class OpenAIResponseClient {
53385338
public virtual ClientResult<OpenAIResponse> GetResponse(string responseId, CancellationToken cancellationToken = default);
53395339
public virtual Task<ClientResult> GetResponseAsync(string responseId, bool? stream, int? startingAfter, RequestOptions options);
53405340
public virtual Task<ClientResult<OpenAIResponse>> GetResponseAsync(string responseId, CancellationToken cancellationToken = default);
5341-
public virtual CollectionResult<ResponseItem> GetResponseInputItems(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
5342-
public virtual CollectionResult GetResponseInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options = null);
5343-
public virtual AsyncCollectionResult<ResponseItem> GetResponseInputItemsAsync(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
5344-
public virtual AsyncCollectionResult GetResponseInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options = null);
53455341
public virtual CollectionResult<StreamingResponseUpdate> GetResponseStreaming(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default);
53465342
public virtual AsyncCollectionResult<StreamingResponseUpdate> GetResponseStreamingAsync(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default);
53475343
}

api/OpenAI.netstandard2.0.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4710,10 +4710,6 @@ public class OpenAIResponseClient {
47104710
public virtual ClientResult<OpenAIResponse> GetResponse(string responseId, CancellationToken cancellationToken = default);
47114711
public virtual Task<ClientResult> GetResponseAsync(string responseId, bool? stream, int? startingAfter, RequestOptions options);
47124712
public virtual Task<ClientResult<OpenAIResponse>> GetResponseAsync(string responseId, CancellationToken cancellationToken = default);
4713-
public virtual CollectionResult<ResponseItem> GetResponseInputItems(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
4714-
public virtual CollectionResult GetResponseInputItems(string responseId, int? limit, string order, string after, string before, RequestOptions options = null);
4715-
public virtual AsyncCollectionResult<ResponseItem> GetResponseInputItemsAsync(string responseId, ResponseItemCollectionOptions options = null, CancellationToken cancellationToken = default);
4716-
public virtual AsyncCollectionResult GetResponseInputItemsAsync(string responseId, int? limit, string order, string after, string before, RequestOptions options = null);
47174713
public virtual CollectionResult<StreamingResponseUpdate> GetResponseStreaming(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default);
47184714
public virtual AsyncCollectionResult<StreamingResponseUpdate> GetResponseStreamingAsync(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default);
47194715
}

src/Custom/Responses/OpenAIResponseClient.Protocol.cs

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -32,30 +32,4 @@ public virtual ClientResult GetResponse(string responseId, bool? stream, int? st
3232
PipelineResponse protocolResponse = Pipeline.ProcessMessage(message, options);
3333
return ClientResult.FromResponse(protocolResponse);
3434
}
35-
36-
public virtual AsyncCollectionResult GetResponseInputItemsAsync(
37-
string responseId,
38-
int? limit,
39-
string order,
40-
string after,
41-
string before,
42-
RequestOptions options = null)
43-
{
44-
Argument.AssertNotNull(responseId, nameof(responseId));
45-
46-
return new AsyncResponseItemCollectionResult(this, responseId, limit, order, after, before, options);
47-
}
48-
49-
public virtual CollectionResult GetResponseInputItems(
50-
string responseId,
51-
int? limit,
52-
string order,
53-
string after,
54-
string before,
55-
RequestOptions options = null)
56-
{
57-
Argument.AssertNotNull(responseId, nameof(responseId));
58-
59-
return new ResponseItemCollectionResult(this, responseId, limit, order, after, before, options);
60-
}
6135
}

src/Custom/Responses/OpenAIResponseClient.cs

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -266,34 +266,6 @@ public virtual CollectionResult<StreamingResponseUpdate> GetResponseStreaming(st
266266
cancellationToken);
267267
}
268268

269-
public virtual AsyncCollectionResult<ResponseItem> GetResponseInputItemsAsync(string responseId, ResponseItemCollectionOptions options = default, CancellationToken cancellationToken = default)
270-
{
271-
Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
272-
273-
AsyncCollectionResult result = GetResponseInputItemsAsync(responseId, options?.PageSizeLimit, options?.Order?.ToString(), options?.AfterId, options?.BeforeId, cancellationToken.ToRequestOptions());
274-
275-
if (result is not AsyncCollectionResult<ResponseItem> responsesItemCollection)
276-
{
277-
throw new InvalidOperationException("Failed to cast protocol return type to expected collection type 'AsyncCollectionResult<ResponsesItem>'.");
278-
}
279-
280-
return responsesItemCollection;
281-
}
282-
283-
public virtual CollectionResult<ResponseItem> GetResponseInputItems(string responseId, ResponseItemCollectionOptions options = default, CancellationToken cancellationToken = default)
284-
{
285-
Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
286-
287-
CollectionResult result = GetResponseInputItems(responseId, options?.PageSizeLimit, options?.Order?.ToString(), options?.AfterId, options?.BeforeId, cancellationToken.ToRequestOptions());
288-
289-
if (result is not CollectionResult<ResponseItem> responsesItemCollection)
290-
{
291-
throw new InvalidOperationException("Failed to cast protocol return type to expected collection type 'CollectionResult<ResponsesItem>'.");
292-
}
293-
294-
return responsesItemCollection;
295-
}
296-
297269
public virtual async Task<ClientResult<ResponseDeletionResult>> DeleteResponseAsync(string responseId, CancellationToken cancellationToken = default)
298270
{
299271
Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));

tests/Responses/ResponsesTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -819,7 +819,7 @@ public async Task AllInstructionMethodsWork(ResponsesTestInstructionMethod instr
819819
}
820820

821821
List<ResponseItem> listedItems = [];
822-
await client.GetResponseInputItemsAsync(response.Id).ForEachAsync(item => listedItems.Add(item));
822+
await client.GetInputItemsAsync(response.Id).ForEachAsync(item => listedItems.Add(item));
823823

824824
if (instructionMethod == ResponsesTestInstructionMethod.InstructionsProperty)
825825
{
@@ -952,7 +952,7 @@ public async Task FunctionCallWorks()
952952
Assert.That(turn2Message.Content, Has.Count.EqualTo(1));
953953
Assert.That(turn2Message.Content[0].Text, Does.Contain("22"));
954954

955-
await foreach (ResponseItem item in client.GetResponseInputItemsAsync(turn2Response.Id))
955+
await foreach (ResponseItem item in client.GetInputItemsAsync(turn2Response.Id))
956956
{ }
957957
}
958958

tests/Responses/ResponsesToolTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ public async Task FileSearch()
392392
Assert.That(annotation.FileId, Is.EqualTo(testFile.Id));
393393
Assert.That(annotation.Index, Is.GreaterThan(0));
394394

395-
await foreach (ResponseItem inputItem in client.GetResponseInputItemsAsync(response.Id))
395+
await foreach (ResponseItem inputItem in client.GetInputItemsAsync(response.Id))
396396
{
397397
Console.WriteLine(ModelReaderWriter.Write(inputItem).ToString());
398398
}

0 commit comments

Comments
 (0)