Skip to content

Commit e75e260

Browse files
Remove unnecessary factory methods for message types with public constructors
Co-authored-by: KrzysztofCwalina <[email protected]>
1 parent b244997 commit e75e260

File tree

2 files changed

+0
-133
lines changed

2 files changed

+0
-133
lines changed

src/Custom/ChatModelFactory.cs

Lines changed: 0 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -87,70 +87,7 @@ public static ChatCompletionDeletionResult ChatCompletionDeletionResult(
8787
additionalBinaryDataProperties: null);
8888
}
8989

90-
/// <summary> Initializes a new instance of <see cref="OpenAI.Chat.UserChatMessage"/>. </summary>
91-
/// <returns> A new <see cref="OpenAI.Chat.UserChatMessage"/> instance for mocking. </returns>
92-
public static UserChatMessage UserChatMessage(
93-
string content = null,
94-
string participantName = null)
95-
{
96-
content ??= "User message content";
97-
var message = new UserChatMessage(content);
98-
if (participantName != null)
99-
{
100-
message.ParticipantName = participantName;
101-
}
102-
return message;
103-
}
104-
105-
/// <summary> Initializes a new instance of <see cref="OpenAI.Chat.AssistantChatMessage"/>. </summary>
106-
/// <returns> A new <see cref="OpenAI.Chat.AssistantChatMessage"/> instance for mocking. </returns>
107-
public static AssistantChatMessage AssistantChatMessage(
108-
string content = null,
109-
IEnumerable<ChatToolCall> toolCalls = null,
110-
string participantName = null)
111-
{
112-
AssistantChatMessage message;
113-
if (toolCalls != null)
114-
{
115-
message = new AssistantChatMessage(toolCalls);
116-
}
117-
else
118-
{
119-
content ??= "Assistant message content";
120-
message = new AssistantChatMessage(content);
121-
}
122-
123-
if (participantName != null)
124-
{
125-
message.ParticipantName = participantName;
126-
}
127-
return message;
128-
}
12990

130-
/// <summary> Initializes a new instance of <see cref="OpenAI.Chat.SystemChatMessage"/>. </summary>
131-
/// <returns> A new <see cref="OpenAI.Chat.SystemChatMessage"/> instance for mocking. </returns>
132-
public static SystemChatMessage SystemChatMessage(
133-
string content = null,
134-
string participantName = null)
135-
{
136-
content ??= "System message content";
137-
var message = new SystemChatMessage(content);
138-
if (participantName != null)
139-
{
140-
message.ParticipantName = participantName;
141-
}
142-
return message;
143-
}
144-
145-
/// <summary> Initializes a new instance of <see cref="OpenAI.Chat.ToolChatMessage"/>. </summary>
146-
/// <returns> A new <see cref="OpenAI.Chat.ToolChatMessage"/> instance for mocking. </returns>
147-
public static ToolChatMessage ToolChatMessage(
148-
string toolCallId = "tool_call_id",
149-
string content = null)
150-
{
151-
content ??= "Tool message content";
152-
return new ToolChatMessage(toolCallId, content);
153-
}
15491

15592
/// <summary> Initializes a new instance of <see cref="OpenAI.Chat.ChatTokenUsage"/>. </summary>
15693
/// <returns> A new <see cref="OpenAI.Chat.ChatTokenUsage"/> instance for mocking. </returns>

tests/Chat/ChatModelFactoryTests.cs

Lines changed: 0 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -146,77 +146,7 @@ public void ChatCompletionDeletionResultWorks()
146146
Assert.That(result.ChatCompletionId, Is.EqualTo(chatCompletionId));
147147
}
148148

149-
[Test]
150-
public void UserChatMessageWorks()
151-
{
152-
string content = "Hello, assistant!";
153-
string participantName = "user1";
154-
155-
UserChatMessage message = ChatModelFactory.UserChatMessage(
156-
content: content,
157-
participantName: participantName);
158-
159-
Assert.That(message.Content[0].Text, Is.EqualTo(content));
160-
Assert.That(message.ParticipantName, Is.EqualTo(participantName));
161-
Assert.That(message.Role, Is.EqualTo(ChatMessageRole.User));
162-
}
163-
164-
[Test]
165-
public void AssistantChatMessageWorks()
166-
{
167-
string content = "Hello, user!";
168-
IEnumerable<ChatToolCall> toolCalls = [
169-
ChatToolCall.CreateFunctionToolCall("id1", "get_weather", BinaryData.FromString("{}"))
170-
];
171-
string participantName = "assistant1";
172-
173-
AssistantChatMessage message = ChatModelFactory.AssistantChatMessage(
174-
content: content,
175-
participantName: participantName);
176-
177-
Assert.That(message.Content[0].Text, Is.EqualTo(content));
178-
Assert.That(message.ParticipantName, Is.EqualTo(participantName));
179-
Assert.That(message.Role, Is.EqualTo(ChatMessageRole.Assistant));
180-
181-
// Test with tool calls
182-
AssistantChatMessage messageWithToolCalls = ChatModelFactory.AssistantChatMessage(
183-
toolCalls: toolCalls,
184-
participantName: participantName);
185149

186-
Assert.That(messageWithToolCalls.ToolCalls.SequenceEqual(toolCalls), Is.True);
187-
Assert.That(messageWithToolCalls.ParticipantName, Is.EqualTo(participantName));
188-
Assert.That(messageWithToolCalls.Role, Is.EqualTo(ChatMessageRole.Assistant));
189-
}
190-
191-
[Test]
192-
public void SystemChatMessageWorks()
193-
{
194-
string content = "You are a helpful assistant";
195-
string participantName = "system";
196-
197-
SystemChatMessage message = ChatModelFactory.SystemChatMessage(
198-
content: content,
199-
participantName: participantName);
200-
201-
Assert.That(message.Content[0].Text, Is.EqualTo(content));
202-
Assert.That(message.ParticipantName, Is.EqualTo(participantName));
203-
Assert.That(message.Role, Is.EqualTo(ChatMessageRole.System));
204-
}
205-
206-
[Test]
207-
public void ToolChatMessageWorks()
208-
{
209-
string toolCallId = "tool_call_id";
210-
string content = "Weather is sunny";
211-
212-
ToolChatMessage message = ChatModelFactory.ToolChatMessage(
213-
toolCallId: toolCallId,
214-
content: content);
215-
216-
Assert.That(message.Content[0].Text, Is.EqualTo(content));
217-
Assert.That(message.ToolCallId, Is.EqualTo(toolCallId));
218-
Assert.That(message.Role, Is.EqualTo(ChatMessageRole.Tool));
219-
}
220150

221151
[Test]
222152
public void ChatTokenUsageWorks()

0 commit comments

Comments
 (0)