Skip to content

Commit fb1ce96

Browse files
ShivangiRejaShivangiReja
committed
Feedback
1 parent 243f987 commit fb1ce96

File tree

8 files changed

+93
-87
lines changed

8 files changed

+93
-87
lines changed

‎api/OpenAI.net8.0.cs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ public class OpenAIClient {
1313
public virtual BatchClient GetBatchClient();
1414
public virtual ChatClient GetChatClient(string model);
1515
[Experimental("OPENAI001")]
16-
public virtual Containers.ContainerClient GetContainerClient();
16+
public virtual ContainerClient GetContainerClient();
1717
public virtual EmbeddingClient GetEmbeddingClient(string model);
1818
[Experimental("OPENAI001")]
1919
public virtual EvaluationClient GetEvaluationClient();
2020
[Experimental("OPENAI001")]
2121
public virtual FineTuningClient GetFineTuningClient();
2222
[Experimental("OPENAI001")]
23-
public virtual Graders.GraderClient GetGraderClient();
23+
public virtual GraderClient GetGraderClient();
2424
public virtual ImageClient GetImageClient(string model);
2525
public virtual ModerationClient GetModerationClient(string model);
2626
public virtual OpenAIFileClient GetOpenAIFileClient();
@@ -2115,16 +2115,16 @@ public class ContainerClient {
21152115
public virtual Task<ClientResult> DeleteContainerAsync(string containerId, RequestOptions options = null);
21162116
public virtual ClientResult DeleteContainerFile(string containerId, string fileId, RequestOptions options = null);
21172117
public virtual Task<ClientResult> DeleteContainerFileAsync(string containerId, string fileId, RequestOptions options = null);
2118+
public virtual ClientResult GetContainer(string containerId, RequestOptions options = null);
2119+
public virtual Task<ClientResult> GetContainerAsync(string containerId, RequestOptions options = null);
2120+
public virtual ClientResult GetContainerFile(string containerId, string fileId, RequestOptions options = null);
2121+
public virtual Task<ClientResult> GetContainerFileAsync(string containerId, string fileId, RequestOptions options = null);
2122+
public virtual ClientResult GetContainerFileContent(string containerId, string fileId, RequestOptions options = null);
2123+
public virtual Task<ClientResult> GetContainerFileContentAsync(string containerId, string fileId, RequestOptions options = null);
21182124
public virtual ClientResult GetContainerFiles(string containerId, int? limit = null, string order = null, string after = null, RequestOptions options = null);
21192125
public virtual Task<ClientResult> GetContainerFilesAsync(string containerId, int? limit = null, string order = null, string after = null, RequestOptions options = null);
21202126
public virtual ClientResult GetContainers(int? limit = null, string order = null, string after = null, RequestOptions options = null);
21212127
public virtual Task<ClientResult> GetContainersAsync(int? limit = null, string order = null, string after = null, RequestOptions options = null);
2122-
public virtual ClientResult RetrieveContainer(string containerId, RequestOptions options = null);
2123-
public virtual Task<ClientResult> RetrieveContainerAsync(string containerId, RequestOptions options = null);
2124-
public virtual ClientResult RetrieveContainerFile(string containerId, string fileId, RequestOptions options = null);
2125-
public virtual Task<ClientResult> RetrieveContainerFileAsync(string containerId, string fileId, RequestOptions options = null);
2126-
public virtual ClientResult RetrieveContainerFileContent(string containerId, string fileId, RequestOptions options = null);
2127-
public virtual Task<ClientResult> RetrieveContainerFileContentAsync(string containerId, string fileId, RequestOptions options = null);
21282128
}
21292129
[Experimental("OPENAI001")]
21302130
public class ContainerFileListResource : IJsonModel<ContainerFileListResource>, IPersistableModel<ContainerFileListResource> {

‎api/OpenAI.netstandard2.0.cs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ public class OpenAIClient {
1010
public virtual AudioClient GetAudioClient(string model);
1111
public virtual BatchClient GetBatchClient();
1212
public virtual ChatClient GetChatClient(string model);
13-
public virtual Containers.ContainerClient GetContainerClient();
13+
public virtual ContainerClient GetContainerClient();
1414
public virtual EmbeddingClient GetEmbeddingClient(string model);
1515
public virtual EvaluationClient GetEvaluationClient();
1616
public virtual FineTuningClient GetFineTuningClient();
17-
public virtual Graders.GraderClient GetGraderClient();
17+
public virtual GraderClient GetGraderClient();
1818
public virtual ImageClient GetImageClient(string model);
1919
public virtual ModerationClient GetModerationClient(string model);
2020
public virtual OpenAIFileClient GetOpenAIFileClient();
@@ -1834,16 +1834,16 @@ public class ContainerClient {
18341834
public virtual Task<ClientResult> DeleteContainerAsync(string containerId, RequestOptions options = null);
18351835
public virtual ClientResult DeleteContainerFile(string containerId, string fileId, RequestOptions options = null);
18361836
public virtual Task<ClientResult> DeleteContainerFileAsync(string containerId, string fileId, RequestOptions options = null);
1837+
public virtual ClientResult GetContainer(string containerId, RequestOptions options = null);
1838+
public virtual Task<ClientResult> GetContainerAsync(string containerId, RequestOptions options = null);
1839+
public virtual ClientResult GetContainerFile(string containerId, string fileId, RequestOptions options = null);
1840+
public virtual Task<ClientResult> GetContainerFileAsync(string containerId, string fileId, RequestOptions options = null);
1841+
public virtual ClientResult GetContainerFileContent(string containerId, string fileId, RequestOptions options = null);
1842+
public virtual Task<ClientResult> GetContainerFileContentAsync(string containerId, string fileId, RequestOptions options = null);
18371843
public virtual ClientResult GetContainerFiles(string containerId, int? limit = null, string order = null, string after = null, RequestOptions options = null);
18381844
public virtual Task<ClientResult> GetContainerFilesAsync(string containerId, int? limit = null, string order = null, string after = null, RequestOptions options = null);
18391845
public virtual ClientResult GetContainers(int? limit = null, string order = null, string after = null, RequestOptions options = null);
18401846
public virtual Task<ClientResult> GetContainersAsync(int? limit = null, string order = null, string after = null, RequestOptions options = null);
1841-
public virtual ClientResult RetrieveContainer(string containerId, RequestOptions options = null);
1842-
public virtual Task<ClientResult> RetrieveContainerAsync(string containerId, RequestOptions options = null);
1843-
public virtual ClientResult RetrieveContainerFile(string containerId, string fileId, RequestOptions options = null);
1844-
public virtual Task<ClientResult> RetrieveContainerFileAsync(string containerId, string fileId, RequestOptions options = null);
1845-
public virtual ClientResult RetrieveContainerFileContent(string containerId, string fileId, RequestOptions options = null);
1846-
public virtual Task<ClientResult> RetrieveContainerFileContentAsync(string containerId, string fileId, RequestOptions options = null);
18471847
}
18481848
public class ContainerFileListResource : IJsonModel<ContainerFileListResource>, IPersistableModel<ContainerFileListResource> {
18491849
public IList<ContainerFileResource> Data { get; }

‎scripts/Export-Api.ps1‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,12 @@ function Invoke-GenAPI {
244244
$content = $content -creplace "Batch\.", ""
245245
$content = $content -creplace "Chat\.", ""
246246
$content = $content -creplace "Common\.", ""
247+
$content = $content -creplace "Containers\.", ""
247248
$content = $content -creplace "Embeddings\.", ""
248249
$content = $content -creplace "Evals\.", ""
249250
$content = $content -creplace "Files\.", ""
250251
$content = $content -creplace "FineTuning\.", ""
252+
$content = $content -creplace "Graders\.", ""
251253
$content = $content -creplace "Images\.", ""
252254
$content = $content -creplace "Models\.", ""
253255
$content = $content -creplace "Moderations\.", ""

‎specification/client/containers.client.tsp‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,8 @@ using Azure.ClientGenerator.Core;
1212
@@convenientAPI(Containers.listContainerFiles, false);
1313
@@convenientAPI(Containers.retrieveContainerFile, false);
1414
@@convenientAPI(Containers.deleteContainerFile, false);
15-
@@convenientAPI(Containers.retrieveContainerFileContent, false);
15+
@@convenientAPI(Containers.retrieveContainerFileContent, false);
16+
17+
@@clientName(Containers.retrieveContainer, "GetContainer");
18+
@@clientName(Containers.retrieveContainerFile, "GetContainerFile");
19+
@@clientName(Containers.retrieveContainerFileContent, "GetContainerFileContent");

‎specification/main.tsp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@ import "./client/assistants.client.tsp";
22
import "./client/audio.client.tsp";
33
import "./client/batch.client.tsp";
44
import "./client/chat.client.tsp";
5+
import "./client/containers.client.tsp";
56
import "./client/embeddings.client.tsp";
67
import "./client/files.client.tsp";
78
import "./client/fine-tuning.client.tsp";
9+
import "./client/graders.client.tsp";
810
import "./client/images.client.tsp";
911
import "./client/messages.client.tsp";
1012
import "./client/moderations.client.tsp";
1113
import "./client/runs.client.tsp";
1214
import "./client/threads.client.tsp";
1315
import "./client/vector-stores.client.tsp";
14-
import "./client/graders.client.tsp";
15-
import "./client/containers.client.tsp";
1616

1717
import "./client/models/audio.models.tsp";
1818
import "./client/models/common.models.tsp";

‎src/Generated/ContainerClient.RestClient.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ internal virtual PipelineMessage CreateCreateContainerRequest(BinaryContent cont
5858
return message;
5959
}
6060

61-
internal virtual PipelineMessage CreateRetrieveContainerRequest(string containerId, RequestOptions options)
61+
internal virtual PipelineMessage CreateGetContainerRequest(string containerId, RequestOptions options)
6262
{
6363
PipelineMessage message = Pipeline.CreateMessage();
6464
message.ResponseClassifier = PipelineMessageClassifier200;
@@ -138,7 +138,7 @@ internal virtual PipelineMessage CreateGetContainerFilesRequest(string container
138138
return message;
139139
}
140140

141-
internal virtual PipelineMessage CreateRetrieveContainerFileRequest(string containerId, string fileId, RequestOptions options)
141+
internal virtual PipelineMessage CreateGetContainerFileRequest(string containerId, string fileId, RequestOptions options)
142142
{
143143
PipelineMessage message = Pipeline.CreateMessage();
144144
message.ResponseClassifier = PipelineMessageClassifier200;
@@ -174,7 +174,7 @@ internal virtual PipelineMessage CreateDeleteContainerFileRequest(string contain
174174
return message;
175175
}
176176

177-
internal virtual PipelineMessage CreateRetrieveContainerFileContentRequest(string containerId, string fileId, RequestOptions options)
177+
internal virtual PipelineMessage CreateGetContainerFileContentRequest(string containerId, string fileId, RequestOptions options)
178178
{
179179
PipelineMessage message = Pipeline.CreateMessage();
180180
message.ResponseClassifier = PipelineMessageClassifier200;

‎src/Generated/ContainerClient.cs‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,19 @@ public virtual async Task<ClientResult> CreateContainerAsync(BinaryContent conte
5050
return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
5151
}
5252

53-
public virtual ClientResult RetrieveContainer(string containerId, RequestOptions options = null)
53+
public virtual ClientResult GetContainer(string containerId, RequestOptions options = null)
5454
{
5555
Argument.AssertNotNullOrEmpty(containerId, nameof(containerId));
5656

57-
using PipelineMessage message = CreateRetrieveContainerRequest(containerId, options);
57+
using PipelineMessage message = CreateGetContainerRequest(containerId, options);
5858
return ClientResult.FromResponse(Pipeline.ProcessMessage(message, options));
5959
}
6060

61-
public virtual async Task<ClientResult> RetrieveContainerAsync(string containerId, RequestOptions options = null)
61+
public virtual async Task<ClientResult> GetContainerAsync(string containerId, RequestOptions options = null)
6262
{
6363
Argument.AssertNotNullOrEmpty(containerId, nameof(containerId));
6464

65-
using PipelineMessage message = CreateRetrieveContainerRequest(containerId, options);
65+
using PipelineMessage message = CreateGetContainerRequest(containerId, options);
6666
return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
6767
}
6868

@@ -116,21 +116,21 @@ public virtual async Task<ClientResult> GetContainerFilesAsync(string containerI
116116
return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
117117
}
118118

119-
public virtual ClientResult RetrieveContainerFile(string containerId, string fileId, RequestOptions options = null)
119+
public virtual ClientResult GetContainerFile(string containerId, string fileId, RequestOptions options = null)
120120
{
121121
Argument.AssertNotNullOrEmpty(containerId, nameof(containerId));
122122
Argument.AssertNotNullOrEmpty(fileId, nameof(fileId));
123123

124-
using PipelineMessage message = CreateRetrieveContainerFileRequest(containerId, fileId, options);
124+
using PipelineMessage message = CreateGetContainerFileRequest(containerId, fileId, options);
125125
return ClientResult.FromResponse(Pipeline.ProcessMessage(message, options));
126126
}
127127

128-
public virtual async Task<ClientResult> RetrieveContainerFileAsync(string containerId, string fileId, RequestOptions options = null)
128+
public virtual async Task<ClientResult> GetContainerFileAsync(string containerId, string fileId, RequestOptions options = null)
129129
{
130130
Argument.AssertNotNullOrEmpty(containerId, nameof(containerId));
131131
Argument.AssertNotNullOrEmpty(fileId, nameof(fileId));
132132

133-
using PipelineMessage message = CreateRetrieveContainerFileRequest(containerId, fileId, options);
133+
using PipelineMessage message = CreateGetContainerFileRequest(containerId, fileId, options);
134134
return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
135135
}
136136

@@ -152,21 +152,21 @@ public virtual async Task<ClientResult> DeleteContainerFileAsync(string containe
152152
return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
153153
}
154154

155-
public virtual ClientResult RetrieveContainerFileContent(string containerId, string fileId, RequestOptions options = null)
155+
public virtual ClientResult GetContainerFileContent(string containerId, string fileId, RequestOptions options = null)
156156
{
157157
Argument.AssertNotNullOrEmpty(containerId, nameof(containerId));
158158
Argument.AssertNotNullOrEmpty(fileId, nameof(fileId));
159159

160-
using PipelineMessage message = CreateRetrieveContainerFileContentRequest(containerId, fileId, options);
160+
using PipelineMessage message = CreateGetContainerFileContentRequest(containerId, fileId, options);
161161
return ClientResult.FromResponse(Pipeline.ProcessMessage(message, options));
162162
}
163163

164-
public virtual async Task<ClientResult> RetrieveContainerFileContentAsync(string containerId, string fileId, RequestOptions options = null)
164+
public virtual async Task<ClientResult> GetContainerFileContentAsync(string containerId, string fileId, RequestOptions options = null)
165165
{
166166
Argument.AssertNotNullOrEmpty(containerId, nameof(containerId));
167167
Argument.AssertNotNullOrEmpty(fileId, nameof(fileId));
168168

169-
using PipelineMessage message = CreateRetrieveContainerFileContentRequest(containerId, fileId, options);
169+
using PipelineMessage message = CreateGetContainerFileContentRequest(containerId, fileId, options);
170170
return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
171171
}
172172
}

0 commit comments

Comments
 (0)