Missing ID parameter to ResponseItem.CreateMcpApprovalRequestItem

[stephentoub]

Both ResponseItem.CreateFunctionCallItem and CreateFunctionCallOutputItem accept a callId parameter, because they come in a pair, with the response needing to refer back to the corresponding ID from the request.

In contrast, ResponseItem.CreateMcpApprovalResponseItem accepts an approvalRequestId, but ResponseItem.CreateMcpApprovalRequestItem does not. It ends up creating an McpToolCallApprovalRequestItem with a null Id and no way that I can find to set it or an approval ID that could be correlated with the one for the response.

[jsquire]

@joseharriaga: Can you please take a look and offer your thoughts?

[joseharriaga]

Hi, @stephentoub . Could you provide more information to help me understand your scenario? Why do you need to create your own Id or CallId instead of using the one returned by the service? Is it for mock testing?

We currently consider the setter of the CallId property in FunctionCallResponseItem and FunctionCallOutputResponseItem to be a bug (which itself comes from a bug in our code generator). The reason why we think neither Id nor CallId should have setters is because these values are output-only. As such, in the standard scenario, these values are provided by the service, and users should simply echo them back instead of modifying them.

Having said that, I do agree that we need to add a way to set these values for the purposes of mock testing. In that case, the fix that we need to make is to add the ResponseItem derived classes to the OpenAIResponsesModelFactory.

[stephentoub]

Why do you need to create your own Id or CallId instead of using the one returned by the service?

I don't, but I need to be able to re-create an McpApprovalRequestItem using the ID previously provided by the service. I get back an McpApprovalRequestItem, extract from it relevant information, and then later if the store=false, that McpApprovalRequestItem needs to be passed back to the service. I need to create a new McpApprovalRequestItem using the previously extracted information, and I can't right now because there's no way to pass back in the original approval id.

[joseharriaga]

Got it. Thank you for the clarification. I just submitted a PR to fix this:
🔗 #671