Skip to content

Fix casing of MessageImageDetail in MessageContent factory methods #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Fix casing of MessageImageDetail in MessageContent factory methods #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e29a1
Fix casing of MessageImageDetail in MessageContent factory methods
ShivangiReja Jul 17, 2025
09b60d5
Feedback
ShivangiReja Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Custom/Assistants/MessageContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public static MessageContent FromImageFileId(
=> new InternalMessageContentImageFileObject(
imageFile: new(
fileId: imageFileId,
detail: detail?.ToString(),
detail: detail?.ToSerialString(),
additionalBinaryDataProperties: null));

/// <summary>
Expand All @@ -33,7 +33,7 @@ public static MessageContent FromImageUri(Uri imageUri, MessageImageDetail? deta
=> new InternalMessageContentImageUrlObject(
imageUrl: new(
url: imageUri,
detail: detail?.ToString(),
detail: detail?.ToSerialString(),
additionalBinaryDataProperties: null));

/// <summary>
Expand Down
39 changes: 39 additions & 0 deletions tests/Assistants/AssistantsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,45 @@ public async Task ThreadWithInitialMessagesWorks()
Assert.That(messages[1].Content[1].ImageUri.AbsoluteUri, Is.EqualTo("https://test.openai.com/image.png"));
}

[Test]
public async Task ThreadWithImageDetailWorks()
{
AssistantClient client = GetTestClient();

ThreadCreationOptions options = new()
{
InitialMessages =
{
new(
MessageRole.User,
[
"Describe this image with auto detail:",
MessageContent.FromImageUri(
new Uri("https://test.openai.com/image.png"),
MessageImageDetail.Auto)
])
}
};

AssistantThread thread = IsAsync
? await client.CreateThreadAsync(options)
: client.CreateThread(options);

Validate(thread);

MessageCollectionOptions collectionOptions = new() { Order = MessageCollectionOrder.Ascending };
List<ThreadMessage> messages = IsAsync
? await client.GetMessagesAsync(thread.Id, collectionOptions).ToListAsync()
: client.GetMessages(thread.Id, collectionOptions).ToList();

Assert.That(messages.Count, Is.EqualTo(1));
Assert.That(messages[0].Role, Is.EqualTo(MessageRole.User));
Assert.That(messages[0].Content?.Count, Is.EqualTo(2));

Assert.That(messages[0].Content[0].Text, Is.EqualTo("Describe this image with auto detail:"));
Assert.That(messages[0].Content[1].ImageUri.AbsoluteUri, Is.EqualTo("https://test.openai.com/image.png"));
}

[Test]
public async Task BasicRunOperationsWork()
{
Expand Down