Skip to content

Commit b956e3a

Browse files
stainless-app[bot]stainless-app[bot]
committed
chore: refactor client tests (#187)
1 parent 8a8855d commit b956e3a

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

‎client_test.go

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,15 @@ func TestRetryAfter(t *testing.T) {
6666
},
6767
}),
6868
)
69-
res, err := client.Chat.Completions.New(context.Background(), openai.ChatCompletionNewParams{
69+
_, err := client.Chat.Completions.New(context.Background(), openai.ChatCompletionNewParams{
7070
Messages: openai.F([]openai.ChatCompletionMessageParamUnion{openai.ChatCompletionUserMessageParam{
7171
Role: openai.F(openai.ChatCompletionUserMessageParamRoleUser),
7272
Content: openai.F([]openai.ChatCompletionContentPartUnionParam{openai.ChatCompletionContentPartTextParam{Text: openai.F("text"), Type: openai.F(openai.ChatCompletionContentPartTextTypeText)}}),
7373
}}),
7474
Model: openai.F(openai.ChatModelO1),
7575
})
76-
if err == nil || res != nil {
77-
t.Error("Expected there to be a cancel error and for the response to be nil")
76+
if err == nil {
77+
t.Error("Expected there to be a cancel error")
7878
}
7979

8080
attempts := len(retryCountHeaders)
@@ -106,15 +106,15 @@ func TestDeleteRetryCountHeader(t *testing.T) {
106106
}),
107107
option.WithHeaderDel("X-Stainless-Retry-Count"),
108108
)
109-
res, err := client.Chat.Completions.New(context.Background(), openai.ChatCompletionNewParams{
109+
_, err := client.Chat.Completions.New(context.Background(), openai.ChatCompletionNewParams{
110110
Messages: openai.F([]openai.ChatCompletionMessageParamUnion{openai.ChatCompletionUserMessageParam{
111111
Role: openai.F(openai.ChatCompletionUserMessageParamRoleUser),
112112
Content: openai.F([]openai.ChatCompletionContentPartUnionParam{openai.ChatCompletionContentPartTextParam{Text: openai.F("text"), Type: openai.F(openai.ChatCompletionContentPartTextTypeText)}}),
113113
}}),
114114
Model: openai.F(openai.ChatModelO1),
115115
})
116-
if err == nil || res != nil {
117-
t.Error("Expected there to be a cancel error and for the response to be nil")
116+
if err == nil {
117+
t.Error("Expected there to be a cancel error")
118118
}
119119

120120
expectedRetryCountHeaders := []string{"", "", ""}
@@ -141,15 +141,15 @@ func TestOverwriteRetryCountHeader(t *testing.T) {
141141
}),
142142
option.WithHeader("X-Stainless-Retry-Count", "42"),
143143
)
144-
res, err := client.Chat.Completions.New(context.Background(), openai.ChatCompletionNewParams{
144+
_, err := client.Chat.Completions.New(context.Background(), openai.ChatCompletionNewParams{
145145
Messages: openai.F([]openai.ChatCompletionMessageParamUnion{openai.ChatCompletionUserMessageParam{
146146
Role: openai.F(openai.ChatCompletionUserMessageParamRoleUser),
147147
Content: openai.F([]openai.ChatCompletionContentPartUnionParam{openai.ChatCompletionContentPartTextParam{Text: openai.F("text"), Type: openai.F(openai.ChatCompletionContentPartTextTypeText)}}),
148148
}}),
149149
Model: openai.F(openai.ChatModelO1),
150150
})
151-
if err == nil || res != nil {
152-
t.Error("Expected there to be a cancel error and for the response to be nil")
151+
if err == nil {
152+
t.Error("Expected there to be a cancel error")
153153
}
154154

155155
expectedRetryCountHeaders := []string{"42", "42", "42"}
@@ -175,15 +175,15 @@ func TestRetryAfterMs(t *testing.T) {
175175
},
176176
}),
177177
)
178-
res, err := client.Chat.Completions.New(context.Background(), openai.ChatCompletionNewParams{
178+
_, err := client.Chat.Completions.New(context.Background(), openai.ChatCompletionNewParams{
179179
Messages: openai.F([]openai.ChatCompletionMessageParamUnion{openai.ChatCompletionUserMessageParam{
180180
Role: openai.F(openai.ChatCompletionUserMessageParamRoleUser),
181181
Content: openai.F([]openai.ChatCompletionContentPartUnionParam{openai.ChatCompletionContentPartTextParam{Text: openai.F("text"), Type: openai.F(openai.ChatCompletionContentPartTextTypeText)}}),
182182
}}),
183183
Model: openai.F(openai.ChatModelO1),
184184
})
185-
if err == nil || res != nil {
186-
t.Error("Expected there to be a cancel error and for the response to be nil")
185+
if err == nil {
186+
t.Error("Expected there to be a cancel error")
187187
}
188188
if want := 3; attempts != want {
189189
t.Errorf("Expected %d attempts, got %d", want, attempts)
@@ -203,15 +203,15 @@ func TestContextCancel(t *testing.T) {
203203
)
204204
cancelCtx, cancel := context.WithCancel(context.Background())
205205
cancel()
206-
res, err := client.Chat.Completions.New(cancelCtx, openai.ChatCompletionNewParams{
206+
_, err := client.Chat.Completions.New(cancelCtx, openai.ChatCompletionNewParams{
207207
Messages: openai.F([]openai.ChatCompletionMessageParamUnion{openai.ChatCompletionUserMessageParam{
208208
Role: openai.F(openai.ChatCompletionUserMessageParamRoleUser),
209209
Content: openai.F([]openai.ChatCompletionContentPartUnionParam{openai.ChatCompletionContentPartTextParam{Text: openai.F("text"), Type: openai.F(openai.ChatCompletionContentPartTextTypeText)}}),
210210
}}),
211211
Model: openai.F(openai.ChatModelO1),
212212
})
213-
if err == nil || res != nil {
214-
t.Error("Expected there to be a cancel error and for the response to be nil")
213+
if err == nil {
214+
t.Error("Expected there to be a cancel error")
215215
}
216216
}
217217

@@ -228,15 +228,15 @@ func TestContextCancelDelay(t *testing.T) {
228228
)
229229
cancelCtx, cancel := context.WithTimeout(context.Background(), 2*time.Millisecond)
230230
defer cancel()
231-
res, err := client.Chat.Completions.New(cancelCtx, openai.ChatCompletionNewParams{
231+
_, err := client.Chat.Completions.New(cancelCtx, openai.ChatCompletionNewParams{
232232
Messages: openai.F([]openai.ChatCompletionMessageParamUnion{openai.ChatCompletionUserMessageParam{
233233
Role: openai.F(openai.ChatCompletionUserMessageParamRoleUser),
234234
Content: openai.F([]openai.ChatCompletionContentPartUnionParam{openai.ChatCompletionContentPartTextParam{Text: openai.F("text"), Type: openai.F(openai.ChatCompletionContentPartTextTypeText)}}),
235235
}}),
236236
Model: openai.F(openai.ChatModelO1),
237237
})
238-
if err == nil || res != nil {
239-
t.Error("expected there to be a cancel error and for the response to be nil")
238+
if err == nil {
239+
t.Error("expected there to be a cancel error")
240240
}
241241
}
242242

@@ -259,15 +259,15 @@ func TestContextDeadline(t *testing.T) {
259259
},
260260
}),
261261
)
262-
res, err := client.Chat.Completions.New(deadlineCtx, openai.ChatCompletionNewParams{
262+
_, err := client.Chat.Completions.New(deadlineCtx, openai.ChatCompletionNewParams{
263263
Messages: openai.F([]openai.ChatCompletionMessageParamUnion{openai.ChatCompletionUserMessageParam{
264264
Role: openai.F(openai.ChatCompletionUserMessageParamRoleUser),
265265
Content: openai.F([]openai.ChatCompletionContentPartUnionParam{openai.ChatCompletionContentPartTextParam{Text: openai.F("text"), Type: openai.F(openai.ChatCompletionContentPartTextTypeText)}}),
266266
}}),
267267
Model: openai.F(openai.ChatModelO1),
268268
})
269-
if err == nil || res != nil {
270-
t.Error("expected there to be a deadline error and for the response to be nil")
269+
if err == nil {
270+
t.Error("expected there to be a deadline error")
271271
}
272272
close(testDone)
273273
}()

0 commit comments

Comments
 (0)